From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 594B938555B9 for ; Thu, 6 Jul 2023 19:30:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 594B938555B9 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-557790487feso824984a12.0 for ; Thu, 06 Jul 2023 12:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1688671801; x=1691263801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TzZCzP51tI2Kmf6IzjQzegq47jrOLoeCA9W09QZCblE=; b=PnlLfM/VkRJ6HujbMbrIcqvSvtHHiIgtcSqhKWl3KqIFwk63FRlIMP3gXTb588wmnB 1s/v/WuJluEQ3eotojo5sgi8ts7FzJg38l6yMj/dqRFHhsQyelS85WlzWLAtGIvy31KG NvNXMdNJ6kPmwQ2bCoi8rhg2S2gcvU6J2fIF7ypckdX1wI+JH9klr1yYryNckeHkjXJW D3A/77nP0VSLsxEys218cCKbg6romvKoYypgKxez7zaCZ50fyTSJgXJsvoSxO9CkgTc6 mhHgKPXAzMioIoLkH7UMBdzXmqrAMnrCnOF27zTSHYTVL+A2XDIF2CCGlCCEsENN6Ihs vFhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688671801; x=1691263801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TzZCzP51tI2Kmf6IzjQzegq47jrOLoeCA9W09QZCblE=; b=bWGZMoCmDLDaCZ19/egoK8ReqUilb2CBTEVlbQDQvo5OdV3JckHvR2Aw0h+K6/n4Y9 5/pablRMkYiYP0jWEOvd1HHf1J9jEzySxEnUkExNDBHTvq1md9KBTh33hTpWS9Eb0B02 2VXxZYDgfA6YBVzy45z1/CW77GNqnf491RBJjwRd1+gjU7+LWjC2xCzezr2csCyXA8b4 vOJHfUamwlbHJSu+P4aWA9QNuBzikVfiaV0f1NZqN4f7Loz/Yi2Dy5jHaXTPxM8hgsbm cn2muobC2giKfvYa8eUt3W3fNAPz7OJpcsUMQdcHsxUJI9+5D45ljks6tt+qZUzOD61u eR1w== X-Gm-Message-State: ABy/qLaBaAB7k/utl/a/tf7n9YZBGTheNKl/JBBvpEKZ+Iy2v/CA+swj Gt63+vCnAFo44cjySKWtaR+6xPsjF1G2lQP6MOg= X-Google-Smtp-Source: APBJJlH5gxq+t/2OqZXZSI5CsKnJDfbKCEUl42UsyHGlGBHQhz73B14cEb3Y5UGH7ZULBr53qzqOzw== X-Received: by 2002:a05:6a20:7347:b0:12e:cb9e:83 with SMTP id v7-20020a056a20734700b0012ecb9e0083mr2859976pzc.62.1688671800596; Thu, 06 Jul 2023 12:30:00 -0700 (PDT) Received: from evan.ba.rivosinc.com ([66.220.2.162]) by smtp.gmail.com with ESMTPSA id c5-20020aa78805000000b0067a50223e3bsm1606489pfo.111.2023.07.06.12.29.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 12:30:00 -0700 (PDT) From: Evan Green To: libc-alpha@sourceware.org Cc: palmer@rivosinc.com, slewis@rivosinc.com, vineetg@rivosinc.com, Florian Weimer , Evan Green Subject: [PATCH v4 2/3] riscv: Add hwprobe vdso call support Date: Thu, 6 Jul 2023 12:29:45 -0700 Message-Id: <20230706192947.1566767-3-evan@rivosinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230706192947.1566767-1-evan@rivosinc.com> References: <20230706192947.1566767-1-evan@rivosinc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The new riscv_hwprobe syscall also comes with a vDSO for faster answers to your most common questions. Call in today to speak with a kernel representative near you! Signed-off-by: Evan Green Reviewed-by: Palmer Dabbelt --- (no changes since v3) Changes in v3: - Add the "return" to the vsyscall - Fix up vdso arg types to match kernel v4 version - Remove ifdef around INLINE_VSYSCALL (Adhemerval) Changes in v2: - Add vDSO interface sysdeps/unix/sysv/linux/dl-vdso-setup.c | 10 ++++++++++ sysdeps/unix/sysv/linux/dl-vdso-setup.h | 3 +++ sysdeps/unix/sysv/linux/riscv/hwprobe.c | 5 +++-- sysdeps/unix/sysv/linux/riscv/sysdep.h | 1 + 4 files changed, 17 insertions(+), 2 deletions(-) diff --git a/sysdeps/unix/sysv/linux/dl-vdso-setup.c b/sysdeps/unix/sysv/linux/dl-vdso-setup.c index 97eaaeac37..ed8b1ef426 100644 --- a/sysdeps/unix/sysv/linux/dl-vdso-setup.c +++ b/sysdeps/unix/sysv/linux/dl-vdso-setup.c @@ -71,6 +71,16 @@ PROCINFO_CLASS int (*_dl_vdso_clock_getres_time64) (clockid_t, # ifdef HAVE_GET_TBFREQ PROCINFO_CLASS uint64_t (*_dl_vdso_get_tbfreq)(void) RELRO; # endif + +/* RISC-V specific ones. */ +# ifdef HAVE_RISCV_HWPROBE +PROCINFO_CLASS int (*_dl_vdso_riscv_hwprobe)(void *, + size_t, + size_t, + unsigned long *, + unsigned int) RELRO; +# endif + #endif #undef RELRO diff --git a/sysdeps/unix/sysv/linux/dl-vdso-setup.h b/sysdeps/unix/sysv/linux/dl-vdso-setup.h index 867072b897..39eafd5316 100644 --- a/sysdeps/unix/sysv/linux/dl-vdso-setup.h +++ b/sysdeps/unix/sysv/linux/dl-vdso-setup.h @@ -47,6 +47,9 @@ setup_vdso_pointers (void) #ifdef HAVE_GET_TBFREQ GLRO(dl_vdso_get_tbfreq) = dl_vdso_vsym (HAVE_GET_TBFREQ); #endif +#ifdef HAVE_RISCV_HWPROBE + GLRO(dl_vdso_riscv_hwprobe) = dl_vdso_vsym (HAVE_RISCV_HWPROBE); +#endif } #endif diff --git a/sysdeps/unix/sysv/linux/riscv/hwprobe.c b/sysdeps/unix/sysv/linux/riscv/hwprobe.c index a8a14d29a5..14f7136998 100644 --- a/sysdeps/unix/sysv/linux/riscv/hwprobe.c +++ b/sysdeps/unix/sysv/linux/riscv/hwprobe.c @@ -20,11 +20,12 @@ #include #include #include +#include int __riscv_hwprobe (struct riscv_hwprobe *pairs, size_t pair_count, size_t cpu_count, unsigned long int *cpus, unsigned int flags) { - return INLINE_SYSCALL_CALL (riscv_hwprobe, pairs, pair_count, - cpu_count, cpus, flags); + /* The vDSO may be able to provide the answer without a syscall. */ + return INLINE_VSYSCALL(riscv_hwprobe, 5, pairs, pair_count, cpu_count, cpus, flags); } diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h index 5583b96d23..ee015dfeb6 100644 --- a/sysdeps/unix/sysv/linux/riscv/sysdep.h +++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h @@ -156,6 +156,7 @@ /* List of system calls which are supported as vsyscalls (for RV32 and RV64). */ # define HAVE_GETCPU_VSYSCALL "__vdso_getcpu" +# define HAVE_RISCV_HWPROBE "__vdso_riscv_hwprobe" # undef HAVE_INTERNAL_BRK_ADDR_SYMBOL # define HAVE_INTERNAL_BRK_ADDR_SYMBOL 1 -- 2.34.1