From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id C02E53857C4F for ; Mon, 10 Jul 2023 05:23:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C02E53857C4F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-666683eb028so2011466b3a.0 for ; Sun, 09 Jul 2023 22:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688966635; x=1691558635; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m2MAEiaCikhgI8YTh34+uvs+uqGVvdDFXJIeX7wZKFQ=; b=FZoggRNG76YQK6DUMJpZLIw6wfLp3afIuxHnw3D9OqxkY+XLPDMtRTQdqcsnG3bXww DSiqxkVv2pw2KcZnuH8kZgevrxDKzMJ80vRtzSBgw9ClmNQxxh9YccFcBUIQj5mXm2hp HMi8ORmT/vDkgvumEkTa+C8mCbf5VzAMozpZ0oTA6oY1Jz4i1EO555H/ami9cUtV2Dgl BDAzZ79miQvyoCyKTTTGfoyyiNae5Lr/nJYJKouyNeLSsvJ7bQ6LMpvnozbyLmmnycoi 8icVNQZim6PM6p1aI4vrLWv09rgsjoEJIWVK0kekYxADiJ/HUSRJPooOAli3u+aFxIIQ 0wXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688966635; x=1691558635; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m2MAEiaCikhgI8YTh34+uvs+uqGVvdDFXJIeX7wZKFQ=; b=UHGLINiqWdzBwVvUxFrYeF+3PiXF+HMVWTNlK42v5HR1cwaAT/A0kaX4IozoEBdrwb Gppoiwt7tADmg0UUA/8nJWwTkE5KD3WOyuu9TNWfe10Pdqpf6pvoymui2nJ3IVOe1sSP gZU3K1dMexMnxNJ1gpf6QN764Lv3O6q3eJveALcKlpAdpsL+b5bjNeIWj3k6FDEy68K6 M17oGC61ui79TIOor2DDdTfhVhbsnYGUs2kGm73EY8roqS7h4JhazWpCSr/xiGUZgFGt vzjuwT2b0VWkd9YrUZWkWb9YBp4IupKy1NHF5iDr8YE0EaJC2sQq7xoy65dKtByLmBVN mETw== X-Gm-Message-State: ABy/qLbXEXHJYEqdKcJK5btf/2xndMO0aasDVDDDOJ42eRmfZHOUZAnF YvnVMtl6iEYYAg3MhuiYef0= X-Google-Smtp-Source: APBJJlEUWeNvvo1Are3C4nd1wp8upTviZf1Nh6kLb0cKVWENli45CRl2A15ZbOMlowyCHQl2szx14Q== X-Received: by 2002:a05:6a20:4003:b0:125:5693:4270 with SMTP id z3-20020a056a20400300b0012556934270mr7804824pze.17.1688966634630; Sun, 09 Jul 2023 22:23:54 -0700 (PDT) Received: from lib-genoa-01.amd.com ([165.204.156.251]) by smtp.gmail.com with ESMTPSA id bg5-20020a1709028e8500b001b9dab0397bsm1910782plb.29.2023.07.09.22.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Jul 2023 22:23:54 -0700 (PDT) From: Sajan Karumanchi X-Google-Original-From: Sajan Karumanchi To: goldstein.w.n@gmail.com Cc: premachandra.mallappa@amd.com, dj@redhat.com, hjl.tools@gmail.com, libc-alpha@sourceware.org, carlos@systemhalted.org Subject: Date: Mon, 10 Jul 2023 05:23:17 +0000 Message-Id: <20230710052317.828308-1-sajan.karumanchi@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230527184632.694761-3-goldstein.w.n@gmail.com> References: <20230527184632.694761-3-goldstein.w.n@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_BLANKSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Noah, I verified your patches on the master branch that impacts the non-threshold parameter on x86 CPUs. This patch modifies the non-temporal threshold value from 24MB(3/4th of L3$) to 8MB(1/4th of L3$) on ZEN4. >From the Glibc benchmarks, we saw a significant performance drop ranging from 15% to 99% for size ranges of 8MB to 16MB. I also ran the new tool developed by you on all Zen architectures and the results conclude that 3/4th L3 size holds good on AMD CPUs. Hence the current patch degrades the performance of AMD CPUs. We strongly recommend marking this change to Intel CPUs only. Thanks, Sajan K.