From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by sourceware.org (Postfix) with ESMTPS id 6FD453856DDC for ; Tue, 18 Jul 2023 13:38:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6FD453856DDC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linuxfoundation.org Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-579efc32377so53205507b3.1 for ; Tue, 18 Jul 2023 06:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1689687529; x=1692279529; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gOW58gb/ja+tXvY1lZ2Ay78dOcRH5jyQPfO8SqHYIpU=; b=OD5jZ15K89K/C/IZ0paNGRBdBicQvvUJA6Jkwiqn8H8apZuKjnC7gJFvvtSoxAN0hB Ob9pMb9hTZ3Ylxa09rSGin6N8g/+42c4CQ1iobiXRwvOnuSOcNxSwKBzW1KLTFMTdZFB K2BPCdTYHpCgsLVE0H0o2GHteSOseOrGTPQcE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689687529; x=1692279529; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gOW58gb/ja+tXvY1lZ2Ay78dOcRH5jyQPfO8SqHYIpU=; b=ehIuH4NPjVNmaFmXvKVPFAMFMBLQFH/a6qU7u2BDiCIMBdocPrOp369OMR+SFv77ui 62t4DT5IVGNOqqNZQj7vXhn78MLsOWOUBQjgDy+wrTRxzxMr7ilNj26WqCTfQ6sz49At c/7PVOIyJK1dgWX4DL6Uxy70IeKCAfTT1yClN21Q33YtJDKztrs2JvAEGCtUiwAEtvps WeJTnZfWnrLwWfsOrx8qJJahlLJGD3abMrk3u/lur631rf5WTFCpdodNOTqxacjZaoBa EPp8cY42Yj9sDEmiw+i3EFZb+/Z61Tfu1wFHp8MAo4ms1MkuDXViJA/DqpA5ya+1tzGF 9OiA== X-Gm-Message-State: ABy/qLZ2ju/rbAwf6LBXz57gUmS+OgzgHgwM0D7TQRxq0rfgFkmQ07H+ 4+1b6qRle5xJXK0IhakD5V7kdw== X-Google-Smtp-Source: APBJJlFQx3uXCKXu2m7D6qjDfhPk+wnbFZTneokn0A6JHhhWNBAnZUDkojIMRKPosaavFjbq3omewA== X-Received: by 2002:a0d:d88d:0:b0:569:479f:6d7f with SMTP id a135-20020a0dd88d000000b00569479f6d7fmr12794198ywe.43.1689687529540; Tue, 18 Jul 2023 06:38:49 -0700 (PDT) Received: from meerkat.local ([142.113.79.114]) by smtp.gmail.com with ESMTPSA id b18-20020ac85412000000b00403af2cf825sm645982qtq.34.2023.07.18.06.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 06:38:49 -0700 (PDT) Date: Tue, 18 Jul 2023 09:38:40 -0400 From: Konstantin Ryabitsev To: Jakub Jelinek Cc: Siddhesh Poyarekar , Florian Weimer , Carlos O'Donell via Libc-alpha , Carlos O'Donell , Joseph Myers , "Ryan S. Arnold" , Paul Eggert , Maxim Kuvyrkov , Andreas Schwab Subject: Re: Core Toolchain Infrastructure - Services for glibc Message-ID: <20230718-reshuffle-backlight-7f220c@meerkat> References: <45e98807-908f-0968-b6fe-5dbb0af265b1@redhat.com> <87ttu6oh9j.fsf@oldenburg.str.redhat.com> <20230714-card-radium-prow-27d2f1@meerkat> <2b743481-4dc3-07a1-fe65-a32a9d1df09a@gotplt.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jul 18, 2023 at 02:26:44PM +0200, Jakub Jelinek wrote: > > This would mean porting AdaCore hooks to a patchwork trybot. This would be > > an acceptable solution for glibc, but I'm not sure how useful this would be > > on the whole since gcc doesn't use patchwork as extensively at the moment. > > Also, we need to figure out who's going to do this. > > It is definitely not acceptable for gcc, we strongly rely on server side > pre-commit hooks for various different tasks. I'm not saying "no hooks at all," but the general rule is: - a hook can run checks on the contents of the commit message - a hook can query external systems for validation results (with a reasonably short timeout) The core principle is that hooks should be fast and shouldn't have a large attack surface, because hooks are running with full access to the underlying repository. Any CI builds or other validations should run prior to the push and visible to the committer before the push is attempted. I mention patchwork because it's a system we use, but other options exist (e.g. gerrit, though I wouldn't use it just for CI purposes). Regards, -K