* [PATCH] Include sys/rseq.h in tst-rseq-disable.c
@ 2023-07-25 9:34 Stefan Liebler
2023-07-25 10:19 ` Florian Weimer
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Liebler @ 2023-07-25 9:34 UTC (permalink / raw)
To: libc-alpha; +Cc: fweimer, dilfridge, Stefan Liebler
Starting with commit 2c6b4b272e6b4d07303af25709051c3e96288f2d
"nptl: Unconditionally use a 32-byte rseq area", the testcase
misc/tst-rseq-disable is UNSUPPORTED as RSEQ_SIG is not defined.
The mentioned commit removes inclusion of sys/rseq.h in nptl/descr.h.
Thus just include sys/rseq.h in the tst-rseq-disable.c as also done
in tst-rseq.c and tst-rseq-nptl.c.
---
sysdeps/unix/sysv/linux/tst-rseq-disable.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sysdeps/unix/sysv/linux/tst-rseq-disable.c b/sysdeps/unix/sysv/linux/tst-rseq-disable.c
index d0db81b29d..cc7e94b3fe 100644
--- a/sysdeps/unix/sysv/linux/tst-rseq-disable.c
+++ b/sysdeps/unix/sysv/linux/tst-rseq-disable.c
@@ -22,6 +22,7 @@
#include <support/xthread.h>
#include <sysdep.h>
#include <thread_pointer.h>
+#include <sys/rseq.h>
#include <unistd.h>
#ifdef RSEQ_SIG
--
2.41.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Include sys/rseq.h in tst-rseq-disable.c
2023-07-25 9:34 [PATCH] Include sys/rseq.h in tst-rseq-disable.c Stefan Liebler
@ 2023-07-25 10:19 ` Florian Weimer
2023-07-25 10:29 ` Stefan Liebler
0 siblings, 1 reply; 3+ messages in thread
From: Florian Weimer @ 2023-07-25 10:19 UTC (permalink / raw)
To: Stefan Liebler; +Cc: libc-alpha, dilfridge
* Stefan Liebler:
> Starting with commit 2c6b4b272e6b4d07303af25709051c3e96288f2d
> "nptl: Unconditionally use a 32-byte rseq area", the testcase
> misc/tst-rseq-disable is UNSUPPORTED as RSEQ_SIG is not defined.
>
> The mentioned commit removes inclusion of sys/rseq.h in nptl/descr.h.
> Thus just include sys/rseq.h in the tst-rseq-disable.c as also done
> in tst-rseq.c and tst-rseq-nptl.c.
> ---
> sysdeps/unix/sysv/linux/tst-rseq-disable.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sysdeps/unix/sysv/linux/tst-rseq-disable.c b/sysdeps/unix/sysv/linux/tst-rseq-disable.c
> index d0db81b29d..cc7e94b3fe 100644
> --- a/sysdeps/unix/sysv/linux/tst-rseq-disable.c
> +++ b/sysdeps/unix/sysv/linux/tst-rseq-disable.c
> @@ -22,6 +22,7 @@
> #include <support/xthread.h>
> #include <sysdep.h>
> #include <thread_pointer.h>
> +#include <sys/rseq.h>
> #include <unistd.h>
>
> #ifdef RSEQ_SIG
Uh-oh. Good catch. Maybe sort the #include lexicographically? Either
way:
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Include sys/rseq.h in tst-rseq-disable.c
2023-07-25 10:19 ` Florian Weimer
@ 2023-07-25 10:29 ` Stefan Liebler
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Liebler @ 2023-07-25 10:29 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha, dilfridge
On 25.07.23 12:19, Florian Weimer wrote:
> * Stefan Liebler:
>
>> Starting with commit 2c6b4b272e6b4d07303af25709051c3e96288f2d
>> "nptl: Unconditionally use a 32-byte rseq area", the testcase
>> misc/tst-rseq-disable is UNSUPPORTED as RSEQ_SIG is not defined.
>>
>> The mentioned commit removes inclusion of sys/rseq.h in nptl/descr.h.
>> Thus just include sys/rseq.h in the tst-rseq-disable.c as also done
>> in tst-rseq.c and tst-rseq-nptl.c.
>> ---
>> sysdeps/unix/sysv/linux/tst-rseq-disable.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/sysdeps/unix/sysv/linux/tst-rseq-disable.c b/sysdeps/unix/sysv/linux/tst-rseq-disable.c
>> index d0db81b29d..cc7e94b3fe 100644
>> --- a/sysdeps/unix/sysv/linux/tst-rseq-disable.c
>> +++ b/sysdeps/unix/sysv/linux/tst-rseq-disable.c
>> @@ -22,6 +22,7 @@
>> #include <support/xthread.h>
>> #include <sysdep.h>
>> #include <thread_pointer.h>
>> +#include <sys/rseq.h>
>> #include <unistd.h>
>>
>> #ifdef RSEQ_SIG
>
> Uh-oh. Good catch. Maybe sort the #include lexicographically? Either
> way:
>
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
>
> Thanks,
> Florian
>
I've just committed it as is. I haven't changed the order as the other
mentioned tests also use it this way.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-25 10:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-25 9:34 [PATCH] Include sys/rseq.h in tst-rseq-disable.c Stefan Liebler
2023-07-25 10:19 ` Florian Weimer
2023-07-25 10:29 ` Stefan Liebler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).