public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Evan Green <evan@rivosinc.com>
To: libc-alpha@sourceware.org
Cc: slewis@rivosinc.com, Florian Weimer <fweimer@redhat.com>,
	palmer@rivosinc.com, vineetg@rivosinc.com,
	Evan Green <evan@rivosinc.com>
Subject: [PATCH v6 2/5] riscv: Add hwprobe vdso call support
Date: Wed,  2 Aug 2023 08:59:00 -0700	[thread overview]
Message-ID: <20230802155903.2552780-3-evan@rivosinc.com> (raw)
In-Reply-To: <20230802155903.2552780-1-evan@rivosinc.com>

The new riscv_hwprobe syscall also comes with a vDSO for faster answers
to your most common questions. Call in today to speak with a kernel
representative near you!

Signed-off-by: Evan Green <evan@rivosinc.com>
Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
---

(no changes since v3)

Changes in v3:
 - Add the "return" to the vsyscall
 - Fix up vdso arg types to match kernel v4 version
 - Remove ifdef around INLINE_VSYSCALL (Adhemerval)

Changes in v2:
 - Add vDSO interface

 sysdeps/unix/sysv/linux/dl-vdso-setup.c | 10 ++++++++++
 sysdeps/unix/sysv/linux/dl-vdso-setup.h |  3 +++
 sysdeps/unix/sysv/linux/riscv/hwprobe.c |  6 ++++--
 sysdeps/unix/sysv/linux/riscv/sysdep.h  |  1 +
 4 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/sysdeps/unix/sysv/linux/dl-vdso-setup.c b/sysdeps/unix/sysv/linux/dl-vdso-setup.c
index 97eaaeac37..ed8b1ef426 100644
--- a/sysdeps/unix/sysv/linux/dl-vdso-setup.c
+++ b/sysdeps/unix/sysv/linux/dl-vdso-setup.c
@@ -71,6 +71,16 @@ PROCINFO_CLASS int (*_dl_vdso_clock_getres_time64) (clockid_t,
 # ifdef HAVE_GET_TBFREQ
 PROCINFO_CLASS uint64_t (*_dl_vdso_get_tbfreq)(void) RELRO;
 # endif
+
+/* RISC-V specific ones.  */
+# ifdef HAVE_RISCV_HWPROBE
+PROCINFO_CLASS int (*_dl_vdso_riscv_hwprobe)(void *,
+                                             size_t,
+                                             size_t,
+                                             unsigned long *,
+                                             unsigned int) RELRO;
+# endif
+
 #endif
 
 #undef RELRO
diff --git a/sysdeps/unix/sysv/linux/dl-vdso-setup.h b/sysdeps/unix/sysv/linux/dl-vdso-setup.h
index 867072b897..39eafd5316 100644
--- a/sysdeps/unix/sysv/linux/dl-vdso-setup.h
+++ b/sysdeps/unix/sysv/linux/dl-vdso-setup.h
@@ -47,6 +47,9 @@ setup_vdso_pointers (void)
 #ifdef HAVE_GET_TBFREQ
   GLRO(dl_vdso_get_tbfreq) = dl_vdso_vsym (HAVE_GET_TBFREQ);
 #endif
+#ifdef HAVE_RISCV_HWPROBE
+  GLRO(dl_vdso_riscv_hwprobe) = dl_vdso_vsym (HAVE_RISCV_HWPROBE);
+#endif
 }
 
 #endif
diff --git a/sysdeps/unix/sysv/linux/riscv/hwprobe.c b/sysdeps/unix/sysv/linux/riscv/hwprobe.c
index 81f24dbc19..57b06c22a5 100644
--- a/sysdeps/unix/sysv/linux/riscv/hwprobe.c
+++ b/sysdeps/unix/sysv/linux/riscv/hwprobe.c
@@ -20,11 +20,13 @@
 #include <sys/syscall.h>
 #include <sys/hwprobe.h>
 #include <sysdep.h>
+#include <sysdep-vdso.h>
 
 int __riscv_hwprobe (struct riscv_hwprobe *__pairs, size_t __pair_count,
 		     size_t __cpu_count, unsigned long int *__cpus,
 		     unsigned int __flags)
 {
-  return INLINE_SYSCALL_CALL (riscv_hwprobe, __pairs, __pair_count,
-                              __cpu_count, __cpus, __flags);
+ /* The vDSO may be able to provide the answer without a syscall. */
+  return INLINE_VSYSCALL(riscv_hwprobe, 5, __pairs, __pair_count,
+                         __cpu_count, __cpus, __flags);
 }
diff --git a/sysdeps/unix/sysv/linux/riscv/sysdep.h b/sysdeps/unix/sysv/linux/riscv/sysdep.h
index 5583b96d23..ee015dfeb6 100644
--- a/sysdeps/unix/sysv/linux/riscv/sysdep.h
+++ b/sysdeps/unix/sysv/linux/riscv/sysdep.h
@@ -156,6 +156,7 @@
 /* List of system calls which are supported as vsyscalls (for RV32 and
    RV64).  */
 # define HAVE_GETCPU_VSYSCALL		"__vdso_getcpu"
+# define HAVE_RISCV_HWPROBE		"__vdso_riscv_hwprobe"
 
 # undef HAVE_INTERNAL_BRK_ADDR_SYMBOL
 # define HAVE_INTERNAL_BRK_ADDR_SYMBOL 1
-- 
2.34.1


  parent reply	other threads:[~2023-08-02 15:59 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02 15:58 [PATCH v6 0/5] RISC-V: ifunced memcpy using new kernel hwprobe interface Evan Green
2023-08-02 15:58 ` [PATCH v6 1/5] riscv: Add Linux hwprobe syscall support Evan Green
2023-08-02 16:52   ` Joseph Myers
2023-08-03  7:24   ` Florian Weimer
2023-08-02 15:59 ` Evan Green [this message]
2023-08-02 15:59 ` [PATCH v6 3/5] riscv: Add __riscv_hwprobe pointer to ifunc calls Evan Green
2023-08-02 15:59 ` [PATCH v6 4/5] riscv: Enable multi-arg ifunc resolvers Evan Green
2023-08-02 15:59 ` [PATCH v6 5/5] riscv: Add and use alignment-ignorant memcpy Evan Green
2023-08-03  7:25   ` Florian Weimer
2023-08-03 17:50     ` Richard Henderson
2023-08-03 18:42       ` Evan Green
2023-08-03 22:30         ` Richard Henderson
2023-08-07 22:10           ` Evan Green
2023-08-07 22:21             ` Florian Weimer
2023-08-07 22:30               ` Evan Green
2023-08-07 22:48             ` enh
2023-08-08  0:01               ` Evan Green
2023-08-12  0:01                 ` enh
2023-08-15 16:40                   ` Evan Green
2023-08-15 21:53                     ` enh
2023-08-15 23:01                       ` Evan Green
2023-08-16 23:18                         ` enh
2023-08-17 16:27                           ` Evan Green
2023-08-17 16:37                             ` enh
2023-08-17 17:40                               ` Evan Green
2023-08-22 15:06                                 ` enh
2023-08-02 16:03 ` [PATCH v6 0/5] RISC-V: ifunced memcpy using new kernel hwprobe interface Evan Green

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230802155903.2552780-3-evan@rivosinc.com \
    --to=evan@rivosinc.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=palmer@rivosinc.com \
    --cc=slewis@rivosinc.com \
    --cc=vineetg@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).