From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hera.aquilenet.fr (hera.aquilenet.fr [IPv6:2a0c:e300::1]) by sourceware.org (Postfix) with ESMTPS id 80E3B3858D1E for ; Wed, 2 Aug 2023 20:39:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 80E3B3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=aquilenet.fr Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aquilenet.fr Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 14E1629D; Wed, 2 Aug 2023 22:39:39 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 46_6lKonZ_ag; Wed, 2 Aug 2023 22:39:38 +0200 (CEST) Received: from begin.home (unknown [IPv6:2a01:cb19:4a:a400:de41:a9ff:fe47:ec49]) by hera.aquilenet.fr (Postfix) with ESMTPSA id E3CFCFE; Wed, 2 Aug 2023 22:39:37 +0200 (CEST) Received: from samy by begin.home with local (Exim 4.96) (envelope-from ) id 1qRId7-009oFV-0F; Wed, 02 Aug 2023 22:39:37 +0200 Date: Wed, 2 Aug 2023 22:39:37 +0200 From: Samuel Thibault To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] hurd: Do not include full in Message-ID: <20230802203937.ktc4hkhpytqr2bjp@begin> References: <87jzug9wqt.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87jzug9wqt.fsf@oldenburg.str.redhat.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Florian Weimer via Libc-alpha, le lun. 31 juil. 2023 12:54:50 +0200, a ecrit: > This fixes a hurd/check-installed-headers-c failure with > -std=c89 #define _FORTIFY_SOURCE 1: > > In file included from ../hurd/hurd.h:354, > from ../sysdeps/hurd/include/hurd.h:2, > from /tmp/cih_test_9IaUwa.c:10: > …/i686-gnu/lib/gcc/i686-glibc-gnu/13.2.1/include/stdarg.h:54:34: error: "__STDC_VERSION__" is not defined, evaluates to 0 [-Werror=undef] > 54 | #if !defined(__STRICT_ANSI__) || __STDC_VERSION__ + 0 >= 199900L \ > | ^~~~~~~~~~~~~~~~ > …/i686-gnu/lib/gcc/i686-glibc-gnu/13.2.1/include/stdarg.h:55:8: error: "__cplusplus" is not defined, evaluates to 0 [-Werror=undef] > 55 | || __cplusplus + 0 >= 201103L > | ^~~~~~~~~~~ > cc1: all warnings being treated as errors Reviewed-by: Samuel Thibault Thanks! > --- > hurd/hurd.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hurd/hurd.h b/hurd/hurd.h > index 06f00e93d6..a38e665676 100644 > --- a/hurd/hurd.h > +++ b/hurd/hurd.h > @@ -350,12 +350,12 @@ extern int hurd_check_cancel (void); > > extern io_t __getdport (int fd), getdport (int fd); > > - > +#define __need___va_list > #include > > /* Write formatted output to PORT, a Mach port supporting the i/o protocol, > according to the format string FORMAT, using the argument list in ARG. */ > -int vpprintf (io_t port, const char *format, va_list arg); > +int vpprintf (io_t port, const char *format, __gnuc_va_list arg); > > > #endif /* hurd.h */ >