* [PATCH 1/5] Define `am_pm` string
@ 2023-08-04 4:06 rushing27alien
2023-08-04 4:06 ` [PATCH 2/5] Define time_fmt_ampm, change from an empty string rushing27alien
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: rushing27alien @ 2023-08-04 4:06 UTC (permalink / raw)
To: libc-alpha; +Cc: RushingAlien
From: RushingAlien <rushing27alien@gmail.com>
Current formatting does not define am_pm string, leading to AM and PM
not being specified in 12 H time format. This change defines the string
by changing it from an empty string to "AM";"PM".
`date +%r`
before: 01:23
after : 01.23 AM
---
localedata/locales/id_ID | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/localedata/locales/id_ID b/localedata/locales/id_ID
index c10306deb7..e306076e8b 100644
--- a/localedata/locales/id_ID
+++ b/localedata/locales/id_ID
@@ -119,7 +119,7 @@ d_t_fmt "%a %d %b %Y %r"
date_fmt "%a %d %b %Y %r %Z"
d_fmt "%d//%m//%y"
t_fmt "%T"
-am_pm "";""
+am_pm "AM";"PM"
t_fmt_ampm ""
week 7;19971130;1
END LC_TIME
--
2.41.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/5] Define time_fmt_ampm, change from an empty string
2023-08-04 4:06 [PATCH 1/5] Define `am_pm` string rushing27alien
@ 2023-08-04 4:06 ` rushing27alien
2023-08-04 4:06 ` [PATCH 3/5] Use 24-hour format for time_fmt rushing27alien
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: rushing27alien @ 2023-08-04 4:06 UTC (permalink / raw)
To: libc-alpha; +Cc: RushingAlien
From: RushingAlien <rushing27alien@gmail.com>
Currently, time_fmpt_ampm is set to an empty string, causing some
programs to not be able to display time in the 12-hour format. This
commit changes it from an empty string to "%I:%M:%S %p"
---
localedata/locales/id_ID | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/localedata/locales/id_ID b/localedata/locales/id_ID
index e306076e8b..e124b27b17 100644
--- a/localedata/locales/id_ID
+++ b/localedata/locales/id_ID
@@ -120,7 +120,7 @@ date_fmt "%a %d %b %Y %r %Z"
d_fmt "%d//%m//%y"
t_fmt "%T"
am_pm "AM";"PM"
-t_fmt_ampm ""
+t_fmt_ampm "%I:%M:%S %p"
week 7;19971130;1
END LC_TIME
--
2.41.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/5] Use 24-hour format for time_fmt
2023-08-04 4:06 [PATCH 1/5] Define `am_pm` string rushing27alien
2023-08-04 4:06 ` [PATCH 2/5] Define time_fmt_ampm, change from an empty string rushing27alien
@ 2023-08-04 4:06 ` rushing27alien
2023-08-04 4:06 ` [PATCH 4/5] Use 24-hour format for d_t_fmt rushing27alien
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: rushing27alien @ 2023-08-04 4:06 UTC (permalink / raw)
To: libc-alpha; +Cc: RushingAlien
From: RushingAlien <rushing27alien@gmail.com>
Indonesian standard and formal time format uses the 24-hour format inst-
ead of the 12-hour format. This commit aims to change the id_ID locale's
time_fmt to match that accordingly.
---
localedata/locales/id_ID | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/localedata/locales/id_ID b/localedata/locales/id_ID
index e124b27b17..4fc4c245d3 100644
--- a/localedata/locales/id_ID
+++ b/localedata/locales/id_ID
@@ -116,7 +116,7 @@ mon "Januari";/
"November";/
"Desember"
d_t_fmt "%a %d %b %Y %r"
-date_fmt "%a %d %b %Y %r %Z"
+date_fmt "%a %d %b %Y %T %Z"
d_fmt "%d//%m//%y"
t_fmt "%T"
am_pm "AM";"PM"
--
2.41.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 4/5] Use 24-hour format for d_t_fmt.
2023-08-04 4:06 [PATCH 1/5] Define `am_pm` string rushing27alien
2023-08-04 4:06 ` [PATCH 2/5] Define time_fmt_ampm, change from an empty string rushing27alien
2023-08-04 4:06 ` [PATCH 3/5] Use 24-hour format for time_fmt rushing27alien
@ 2023-08-04 4:06 ` rushing27alien
2023-08-04 4:06 ` [PATCH 5/5] Change first_weekday to monday rushing27alien
2023-08-07 13:20 ` [PATCH 1/5] Define `am_pm` string Florian Weimer
4 siblings, 0 replies; 6+ messages in thread
From: rushing27alien @ 2023-08-04 4:06 UTC (permalink / raw)
To: libc-alpha; +Cc: RushingAlien
From: RushingAlien <rushing27alien@gmail.com>
Indonesian standard and formal time format uses the 24-hour format inst-
ead of the 12-hour format. This commit aims to change the id_ID locale's
d_t_fmt to match that accordingly.
---
localedata/locales/id_ID | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/localedata/locales/id_ID b/localedata/locales/id_ID
index 4fc4c245d3..34c7bf8f35 100644
--- a/localedata/locales/id_ID
+++ b/localedata/locales/id_ID
@@ -115,7 +115,7 @@ mon "Januari";/
"Oktober";/
"November";/
"Desember"
-d_t_fmt "%a %d %b %Y %r"
+d_t_fmt "%a %d %b %Y %T"
date_fmt "%a %d %b %Y %T %Z"
d_fmt "%d//%m//%y"
t_fmt "%T"
--
2.41.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 5/5] Change first_weekday to monday
2023-08-04 4:06 [PATCH 1/5] Define `am_pm` string rushing27alien
` (2 preceding siblings ...)
2023-08-04 4:06 ` [PATCH 4/5] Use 24-hour format for d_t_fmt rushing27alien
@ 2023-08-04 4:06 ` rushing27alien
2023-08-07 13:20 ` [PATCH 1/5] Define `am_pm` string Florian Weimer
4 siblings, 0 replies; 6+ messages in thread
From: rushing27alien @ 2023-08-04 4:06 UTC (permalink / raw)
To: libc-alpha; +Cc: RushingAlien
From: RushingAlien <rushing27alien@gmail.com>
Indonesian calendar starts of the week with Monday, let's comply
---
localedata/locales/id_ID | 1 +
1 file changed, 1 insertion(+)
diff --git a/localedata/locales/id_ID b/localedata/locales/id_ID
index 34c7bf8f35..5957ebaf0f 100644
--- a/localedata/locales/id_ID
+++ b/localedata/locales/id_ID
@@ -122,6 +122,7 @@ t_fmt "%T"
am_pm "AM";"PM"
t_fmt_ampm "%I:%M:%S %p"
week 7;19971130;1
+first_weekday 2
END LC_TIME
LC_MESSAGES
--
2.41.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/5] Define `am_pm` string
2023-08-04 4:06 [PATCH 1/5] Define `am_pm` string rushing27alien
` (3 preceding siblings ...)
2023-08-04 4:06 ` [PATCH 5/5] Change first_weekday to monday rushing27alien
@ 2023-08-07 13:20 ` Florian Weimer
4 siblings, 0 replies; 6+ messages in thread
From: Florian Weimer @ 2023-08-07 13:20 UTC (permalink / raw)
To: rushing27alien--- via Libc-alpha; +Cc: rushing27alien
* rushing27alien:
> From: RushingAlien <rushing27alien@gmail.com>
>
> Current formatting does not define am_pm string, leading to AM and PM
> not being specified in 12 H time format. This change defines the string
> by changing it from an empty string to "AM";"PM".
>
> `date +%r`
> before: 01:23
> after : 01.23 AM
> ---
> localedata/locales/id_ID | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/localedata/locales/id_ID b/localedata/locales/id_ID
> index c10306deb7..e306076e8b 100644
> --- a/localedata/locales/id_ID
> +++ b/localedata/locales/id_ID
> @@ -119,7 +119,7 @@ d_t_fmt "%a %d %b %Y %r"
> date_fmt "%a %d %b %Y %r %Z"
> d_fmt "%d//%m//%y"
> t_fmt "%T"
> -am_pm "";""
> +am_pm "AM";"PM"
> t_fmt_ampm ""
> week 7;19971130;1
> END LC_TIME
Would you please add id_ID to the commit subject? Thanks.
Maybe fold together some of the patches, too.
I don't know if we have any Indonesian cultural experts on this list who
could review this. The first-day-of-week change seems correct based on
a quick web search.
Has this already been changed in CLDR?
Thanks,
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-08-07 13:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-04 4:06 [PATCH 1/5] Define `am_pm` string rushing27alien
2023-08-04 4:06 ` [PATCH 2/5] Define time_fmt_ampm, change from an empty string rushing27alien
2023-08-04 4:06 ` [PATCH 3/5] Use 24-hour format for time_fmt rushing27alien
2023-08-04 4:06 ` [PATCH 4/5] Use 24-hour format for d_t_fmt rushing27alien
2023-08-04 4:06 ` [PATCH 5/5] Change first_weekday to monday rushing27alien
2023-08-07 13:20 ` [PATCH 1/5] Define `am_pm` string Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).