From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 386213858C33 for ; Mon, 16 Oct 2023 16:52:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 386213858C33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 386213858C33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697475148; cv=none; b=fHiwNkmhWhyd1e71TOkz8iboMQhJ36rKsHzA+TgCrrBcgM8gG4SqcM3dC6kZdxm22fCzKzCF2K76dln5u9JHphS9uIhNgwGeNSlgcByWtfkjdVzx99+KuQx5sJhCq9xWqTXNc+JimvhAOeBkFRlFPoLlqU6wHarn4xXkhKc59PE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697475148; c=relaxed/simple; bh=RfauuLdeKSa0mqpUv5O7lI+12xRi6By0hxigIjk/R58=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ij3JjMB7X14nkyA9ESXR5vzjUHllNzQWT+NzMZQhk8PRpIupO5HUeyEW72lsIKcO7IMuEcxphkH5keGis7rexnuWdqo26CfKVP+JV8QCOfhz+ngBqIuoKll1WalJVMvot2waak2l8Mk0sC8NphOIgGphYYwlmjZ9FSJkjXOpMb4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697475146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IVxE55Cm3McDmcUBGPOQQ3yWOiPQa/qsmqOrjro8Tuw=; b=EsCgi/G1STtQzPs92P5PBHJLu5XgpzRE+h3tDM0vWT9+oEVRGbW/AmdGpHyVDLx6YFhH6I 8Q8sdaJtco0aWh6Vl+/lLCLdMiPfEwuHvTUb8n2rpnlg5rRsGuelgcDHaghFPO7eGrB2rD I12nE31S/KA94/XPSZ6A7l7Ai8BQO6g= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-452-Zzo9PraDO4aLfWvlLp_-Uw-1; Mon, 16 Oct 2023 12:52:03 -0400 X-MC-Unique: Zzo9PraDO4aLfWvlLp_-Uw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD8CA81D9F7; Mon, 16 Oct 2023 16:52:01 +0000 (UTC) Received: from oak (unknown [10.22.32.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A6C9492BFA; Mon, 16 Oct 2023 16:52:01 +0000 (UTC) Date: Mon, 16 Oct 2023 12:52:00 -0400 From: Joe Simmons-Talbott To: Xi Ruoyao Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] posix: Deprecate group_member for Linux Message-ID: <20231016165200.GQ4098455@oak> References: <20230921162057.3610289-1-josimmon@redhat.com> <4b80d08c6263790f1694085c0f5a862c883fbd67.camel@xry111.site> MIME-Version: 1.0 In-Reply-To: <4b80d08c6263790f1694085c0f5a862c883fbd67.camel@xry111.site> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Oct 04, 2023 at 09:06:03PM +0800, Xi Ruoyao wrote: > On Thu, 2023-09-21 at 12:20 -0400, Joe Simmons-Talbott wrote: > > diff --git a/sysdeps/unix/sysv/linux/group_member.h b/sysdeps/unix/sysv/linux/group_member.h > > new file mode 100644 > > index 0000000000..9b24569d4e > > --- /dev/null > > +++ b/sysdeps/unix/sysv/linux/group_member.h > > @@ -0,0 +1,27 @@ > > +/* Copyright (C) 2023 Free Software Foundation, Inc. > > +   This file is part of the GNU C Library. > > + > > +   The GNU C Library is free software; you can redistribute it and/or > > +   modify it under the terms of the GNU Lesser General Public > > +   License as published by the Free Software Foundation; either > > +   version 2.1 of the License, or (at your option) any later version. > > + > > +   The GNU C Library is distributed in the hope that it will be useful, > > +   but WITHOUT ANY WARRANTY; without even the implied warranty of > > +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU > > +   Lesser General Public License for more details. > > + > > +   You should have received a copy of the GNU Lesser General Public > > +   License along with the GNU C Library; if not, see > > +   .  */ > > + > > +#ifndef _GROUP_MEMBER_H > > +#define _GROUP_MEMBER_H 1 > > + > > +#ifdef __USE_GNU > > +/* Return nonzero iff the calling process is in group GID.  Deprecated */ > > +extern int group_member (__gid_t __gid) __THROW > > + __attribute_deprecated__; > > Maybe `__attribute_deprecated_msg__ ("may overflow the stack")` is > better? And should we have an alternate interface to replace it? I'll add your suggestion in v2. There is opposition to adding a replacement group_member interface since it would require converting from a boolean interface to a tri-state interface which are difficult for programmers. Thanks, Joe