From: Peter Zijlstra <peterz@infradead.org>
To: Xi Ruoyao <xry111@xry111.site>
Cc: libc-alpha@sourceware.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, linux-mm@kvack.org,
linux-arch@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"André Almeida" <andrealmeid@igalia.com>
Subject: Re: Several tst-robust* tests time out with recent Linux kernel
Date: Tue, 14 Nov 2023 16:40:17 +0100 [thread overview]
Message-ID: <20231114154017.GI4779@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20231114153100.GY8262@noisy.programming.kicks-ass.net>
On Tue, Nov 14, 2023 at 04:31:00PM +0100, Peter Zijlstra wrote:
> On Tue, Nov 14, 2023 at 05:46:43PM +0800, Xi Ruoyao wrote:
> > On Tue, 2023-11-14 at 02:33 +0800, Xi Ruoyao wrote:
> > > Hi,
> > >
> > > With Linux 6.7.0-rc1, several tst-robust* tests time out on x86_64:
> > >
> > > FAIL: nptl/tst-robust1
> > > FAIL: nptl/tst-robust3
> > > FAIL: nptl/tst-robust4
> > > FAIL: nptl/tst-robust6
> > > FAIL: nptl/tst-robust7
> > > FAIL: nptl/tst-robust9
> > >
> > > This does not happen with Linux 6.6.0. Do you have some clue about
> > > it?
> >
> > Bisected to the kernel commit:
> >
> > commit 5694289ce183bc3336407a78c8c722a0b9208f9b (HEAD)
> > Author: peterz@infradead.org <peterz@infradead.org>
> > Date: Thu Sep 21 12:45:08 2023 +0200
> >
> > futex: Flag conversion
> >
> > Futex has 3 sets of flags:
> >
> > - legacy futex op bits
> > - futex2 flags
> > - internal flags
> >
> > Add a few helpers to convert from the API flags into the internal
> > flags.
> >
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
> > Reviewed-by: Andr<C3><A9> Almeida <andrealmeid@igalia.com>
> > Link: https://lore.kernel.org/r/20230921105247.722140574@noisy.programming.kicks-ass.net
>
> I can confirm. I'm also going crazy trying to figure out how this
> happens.
>
> The below is sufficient to make it unhappy...
>
> /me most puzzled
>
> ---
> diff --git a/kernel/futex/futex.h b/kernel/futex/futex.h
> index b5379c0e6d6d..1a1f9301251f 100644
> --- a/kernel/futex/futex.h
> +++ b/kernel/futex/futex.h
> @@ -17,7 +17,7 @@
> * restarts.
> */
> #ifdef CONFIG_MMU
> -# define FLAGS_SHARED 0x01
> +# define FLAGS_SHARED 0x10
> #else
> /*
> * NOMMU does not have per process address space. Let the compiler optimize
Just the above seems sufficient.
next prev parent reply other threads:[~2023-11-14 15:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 18:33 Xi Ruoyao
2023-11-14 9:46 ` Xi Ruoyao
2023-11-14 15:31 ` Peter Zijlstra
2023-11-14 15:40 ` Peter Zijlstra [this message]
2023-11-14 16:43 ` Florian Weimer
2023-11-14 20:14 ` Peter Zijlstra
2023-11-15 1:11 ` Edgecombe, Rick P
2023-11-15 8:51 ` Peter Zijlstra
2023-11-15 23:28 ` Edgecombe, Rick P
2023-11-17 1:22 ` Edgecombe, Rick P
2024-01-19 13:56 ` Stefan Liebler
2024-01-22 14:34 ` Stefan Liebler
2024-01-29 22:23 ` Edgecombe, Rick P
2024-01-30 10:12 ` Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231114154017.GI4779@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andrealmeid@igalia.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tglx@linutronix.de \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).