From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: [PATCH v2] linux: Fix fstat64 on alpha and sparc64
Date: Fri, 29 Dec 2023 16:44:43 -0300 [thread overview]
Message-ID: <20231229194443.3213761-1-adhemerval.zanella@linaro.org> (raw)
The 551101e8240b7514fc646d1722f8b79c90362b8f change is incorrect for
alpha and sparc, since __NR_stat is defined by both kABI. Use
__NR_newfstat ti check whether fallback to __NR_fstat64 (similar to
what fstatat64).
Checked on sparc64-linux-gnu and x86_64-linux-gnu.
---
sysdeps/unix/sysv/linux/fstat64.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sysdeps/unix/sysv/linux/fstat64.c b/sysdeps/unix/sysv/linux/fstat64.c
index a291f0825b..0f1391067b 100644
--- a/sysdeps/unix/sysv/linux/fstat64.c
+++ b/sysdeps/unix/sysv/linux/fstat64.c
@@ -30,7 +30,10 @@ __fstat64_time64 (int fd, struct __stat64_t64 *buf)
{
#if !FSTATAT_USE_STATX
# if XSTAT_IS_XSTAT64
-# ifdef __NR_fstat
+ /* The __NR_stat is defined for all ABIs that also define XSTAT_IS_STAT64,
+ so to correctly identify alpha and sparc check __NR_newfstatat (similar
+ to what fstatat64 does). */
+# ifdef __NR_newfstatat
/* 64-bit kABI, e.g. aarch64, ia64, powerpc64*, s390x, riscv64, and
x86_64. */
return INLINE_SYSCALL_CALL (fstat, fd, buf);
--
2.34.1
next reply other threads:[~2023-12-29 19:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 19:44 Adhemerval Zanella [this message]
2023-12-30 0:36 ` Andreas Schwab
2023-12-30 12:16 ` Florian Weimer
2024-01-02 14:31 Adhemerval Zanella
2024-01-12 13:37 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231229194443.3213761-1-adhemerval.zanella@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).