public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Stefan Liebler <stli@linux.ibm.com>
To: libc-alpha@sourceware.org
Cc: Stefan Liebler <stli@linux.ibm.com>
Subject: [PATCH] Fix stringop-overflow warning in tst-strlcat2.
Date: Tue, 16 Jan 2024 09:44:30 +0100	[thread overview]
Message-ID: <20240116084430.1082389-1-stli@linux.ibm.com> (raw)

On s390x, I get warnings like this when do_one_test is inlined with SIZE_MAX:
In function ‘do_one_test’,
    inlined from ‘do_overflow_tests’ at tst-strlcat2.c:184:2:
tst-strlcat2.c:49:18: error: ‘strnlen’ specified bound [18446744073709550866, 18446744073709551615] exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=]
   49 | # define STRNLEN strnlen
      |                  ^
tst-strlcat2.c:89:23: note: in expansion of macro ‘STRNLEN’
   89 |   size_t dst_length = STRNLEN (dst, n);
      |                       ^~~~~~~

This patch just marks the do_one_test function as noinline as also done in test-strncat.c:
Fix stringop-overflow warning in test-strncat.
https://sourceware.org/git/?p=glibc.git;a=commit;h=51aeab9a363a0d000d0912aa3d6490463a26fba2
---
 string/tst-strlcat2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/string/tst-strlcat2.c b/string/tst-strlcat2.c
index 225520a46b..1ec26a2432 100644
--- a/string/tst-strlcat2.c
+++ b/string/tst-strlcat2.c
@@ -81,6 +81,7 @@ IMPL (STRLCAT, 1)
 typedef size_t (*proto_t) (CHAR *, const CHAR *, size_t);
 
 static void
+__attribute__((noinline))
 do_one_test (impl_t *impl, CHAR *dst, const CHAR *src,
 	     size_t n)
 {
-- 
2.43.0


             reply	other threads:[~2024-01-16  8:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-16  8:44 Stefan Liebler [this message]
2024-02-05 13:28 ` Stefan Liebler
2024-02-05 13:29 ` Stefan Liebler
2024-02-05 13:53 ` Adhemerval Zanella Netto
2024-02-05 14:15   ` Stefan Liebler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240116084430.1082389-1-stli@linux.ibm.com \
    --to=stli@linux.ibm.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).