From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9E2F638460BD for ; Wed, 10 Apr 2024 16:00:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E2F638460BD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9E2F638460BD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712764822; cv=none; b=jHTT2DilguU6bqRK8Z2FW2Srvp7vxVRdKAgFLwnbFsBNxkGSuR6qx0jaQlDZC7ixmK92sdhAIR2liRXyZMwagCYv2ytmy2M37w1ll5/Inot8XQ4dClWBQZvfWW1Nq3yoZJnDmnb8G7bnlrlnIInPtWT1rXGoA4g9zyeYJHB/IO4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712764822; c=relaxed/simple; bh=uZCCBWW6SDjGHiJvbSRCTO5AFoZIAQ3GUcFVJFIClRE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=qP63iNKyZ0XPjtRprtxW7y3l/NTmUneW9NRL6WWler0p+XIoPwuFwD1+ya7YGP//UcDnwKPcMP/YguM1XiqibTyE2xndfWOTIl4WC1OYVyK1HWUxQXTslCSH7G8T8ojT6N3A0WAWQdrzBhWHGkF55KSrja6b0bYptH8CrgNOkHw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712764819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hdUAiLdJY5sDGEZ94w0TVO00tQ/bZ3yBAjGz5R/cMIU=; b=R0lciM75AAmuo3vsTU4vQtwLQwrCPU9pydQnHi41wsgEETTyG1UUTT/lAzEFkrkt123KlO c1u8dG8XxdjRFGWiD8I7ceMr8++s0O3P8cGpYmdgK/IeJZhiUiTf1O+spP400CcK/11G6N WrXPU5nASUzTY0HGEI/Yb/9QyT2rY/M= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-oCOfJg5VOIOdVqoopWNUHQ-1; Wed, 10 Apr 2024 12:00:17 -0400 X-MC-Unique: oCOfJg5VOIOdVqoopWNUHQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4D57729AA395 for ; Wed, 10 Apr 2024 16:00:17 +0000 (UTC) Received: from sk-carbon-x9.redhat.com (unknown [10.45.224.126]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 975B51C060A6; Wed, 10 Apr 2024 16:00:16 +0000 (UTC) From: Sergey Kolosov To: libc-alpha@sourceware.org Cc: Arjun Shankar Subject: [PATCH v3 2/2] socket: Add new test for connect Date: Wed, 10 Apr 2024 17:58:05 +0200 Message-ID: <20240410160006.176758-2-skolosov@redhat.com> In-Reply-To: <20240410160006.176758-1-skolosov@redhat.com> References: <20240410160006.176758-1-skolosov@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-14.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This commit adds a simple bind/accept/connect test for an IPv4 TCP connection to a local process via the loopback interface. --- Changes from v2: fix some indentation issues. --- socket/Makefile | 1 + socket/tst-connect.c | 113 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 114 insertions(+) create mode 100644 socket/tst-connect.c diff --git a/socket/Makefile b/socket/Makefile index 74ca5b8452..fc1bd0a260 100644 --- a/socket/Makefile +++ b/socket/Makefile @@ -70,6 +70,7 @@ tests := \ tst-accept4 \ tst-cmsg_cloexec \ tst-cmsghdr \ + tst-connect \ tst-sockopt \ # tests diff --git a/socket/tst-connect.c b/socket/tst-connect.c new file mode 100644 index 0000000000..ec2fdd92c0 --- /dev/null +++ b/socket/tst-connect.c @@ -0,0 +1,113 @@ +/* Test the connect function. + Copyright (C) 2024 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +static struct sockaddr_in server_address; + +int +open_socket_inet_tcp (void) +{ + int fd = socket (AF_INET, SOCK_STREAM, IPPROTO_TCP); + if (fd < 0) + { + if (errno == EAFNOSUPPORT) + FAIL_UNSUPPORTED ("The host does not support IPv4"); + else + FAIL_EXIT1 ("socket (AF_INET, SOCK_STREAM, IPPROTO_TCP): %m\n"); + } + return fd; +} + +static pid_t +start_server (void) +{ + server_address.sin_family = AF_INET; + server_address.sin_port = 0; + server_address.sin_addr.s_addr = htonl (INADDR_LOOPBACK); + + int server_sock = open_socket_inet_tcp (); + + xbind (server_sock, (struct sockaddr *) &server_address, + sizeof (server_address)); + + socklen_t sa_len = sizeof (server_address); + xgetsockname (server_sock, (struct sockaddr *) &server_address, &sa_len); + xlisten (server_sock, 5); + + pid_t my_pid = xfork (); + if (my_pid > 0) + { + xclose (server_sock); + return my_pid; + } + + struct sockaddr_in client_address; + socklen_t ca_len = sizeof (server_address); + int client_sock = xaccept (server_sock, (struct sockaddr *) &client_address, + &ca_len); + printf ("socket accepted %d\n", client_sock); + + _exit (0); +} + +static int +do_test (void) +{ + pid_t serv_pid; + struct sockaddr_in peer; + socklen_t peer_len; + + serv_pid = start_server (); + int client_sock = open_socket_inet_tcp (); + xconnect (client_sock, (const struct sockaddr *) &server_address, + sizeof (server_address)); + + /* A second connect with same arguments should fail with EISCONN. */ + int result = connect (client_sock, + (const struct sockaddr *) &server_address, + sizeof (server_address)); + if (result == 0 || errno != EISCONN) + FAIL_EXIT1 ("Second connect (%d), should fail with EISCONN: %m", + client_sock); + + peer_len = sizeof (peer); + xgetpeername (client_sock, (struct sockaddr *) &peer, &peer_len); + TEST_COMPARE (peer_len, sizeof (peer)); + TEST_COMPARE (peer.sin_port, server_address.sin_port); + TEST_COMPARE_BLOB (&peer.sin_addr, sizeof (peer.sin_addr), + &server_address.sin_addr, + sizeof (server_address.sin_addr)); + + int status; + xwaitpid (serv_pid, &status, 0); + TEST_COMPARE (status, 0); + + return 0; +} + +#include -- 2.44.0