From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by sourceware.org (Postfix) with ESMTP id 19F543858D20 for ; Wed, 1 May 2024 00:01:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 19F543858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=altlinux.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=altlinux.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 19F543858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=194.107.17.57 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714521709; cv=none; b=YPwz5uvS0TqyankAojPPUzo9BzaWqp9lEyhHoIdRii0vgGYfMak1RHnpA9ViysWNzPS5c+QPoBu0NbL8ORXfLrjQwFnCFg/Ryrl75L7KN9L98m6X5N2GdMNKPJv8Bnwjt24qMxanj++kglidCZzfezELh0+usC5H2a/zr53eD9Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714521709; c=relaxed/simple; bh=NRaquTKqRd4H2s6ylOnFP1/AiAjB5407iUfxyufTvm8=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=tbAv8KFF82eOho+nm5sSPwsUqWVpRbbrc0/wpnJIJr+S+7+0l9pkk2YrRmrtt8oBn2XLYd78aGxylax+DZQKgRl29UGmdv/cXhugYuoRiR59MUgTKKlgBJCQaPaLkUDgcIYPV2MwBQ7VBEOCKI9h4tIJ1QiuKSKRM5UPj87h16U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 11A4872C984; Wed, 1 May 2024 03:01:47 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 01E4F7CFF28; Wed, 1 May 2024 03:01:46 +0300 (IDT) Date: Wed, 1 May 2024 03:01:46 +0300 From: "Dmitry V. Levin" To: Gabi Falk Cc: libc-alpha@sourceware.org, "H.J. Lu" , Florian Weimer , Sam James Subject: Re: [PATCH 0/3] i586/i686: Fix multiple definitions in libc.a Message-ID: <20240501000146.GA15177@altlinux.org> References: <20240430200506.2717717-1-gabifalk@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240430200506.2717717-1-gabifalk@gmx.com> X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 30, 2024 at 08:05:01PM +0000, Gabi Falk wrote: > This patch fixes two issues related to multiple definitions of functions > in the static library built as PIC and adds a test to prevent such > issues from occurring in the future. > > Gabi Falk (3): > i586: Fix multiple definitions of __memcpy_chk and __mempcpy_chk > i686: Fix multiple definitions of __memmove_chk and __memset_chk > Add a test to check for duplicate definitions in the static library > > Makefile | 7 +++++++ > sysdeps/i386/i586/memcpy.S | 2 +- > sysdeps/i386/i686/memmove.S | 2 +- > sysdeps/i386/i686/memset.S | 2 +- > 4 files changed, 10 insertions(+), 3 deletions(-) For all the series: Reviewed-by: Dmitry V. Levin -- ldv