From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Cc: Joe Simmons-Talbott <josimmon@redhat.com>,
Siddhesh Poyarekar <siddhesh@sourceware.org>
Subject: [PATCH v3 0/4] More tunable fixes
Date: Mon, 6 May 2024 13:18:44 -0300 [thread overview]
Message-ID: <20240506161955.1570278-1-adhemerval.zanella@linaro.org> (raw)
The 680c597e9c3 commit made loader reject ill-formatted strings by
first tracking all set tunables and then applying them. However, it does
not take into consideration if the same tunable is set multiple times,
where parse_tunables_string appends the found tunable without checking
if it was already in the list. It leads to a stack-based buffer overflow
if the tunable is specified more than the total number of
tunables (BZ 31686).
While fixing this issue, I noted that the new glibc.rtld.enable_secure
check could be optimized a bit to avoid the string comparison on the
tunable loop.
I also found an issue where it does have the handle case where the
environment alias is handled before the GLIBC_TUNABLES, which will
change the tunable even if glibc.rtld.enable_secure it set to 0. Fixing
it allows us to optimize the environment alias parsing a bit, since only
tunable with aliases need to be checked (instead of the whole list).
Changes from v2:
* Fixed typos and improve comments.
Changes from v1:
* Do not change tunables internal position.
Adhemerval Zanella (4):
elf: Only process multiple tunable once (BZ 31686)
elf: Remove glibc.rtld.enable_secure check from parse_tunables_string
support: Add envp argument to support_capture_subprogram
elf: Make glibc.rtld.enable_secure ignore alias environment variables
elf/dl-tunables.c | 114 +++++++++++------
elf/tst-audit18.c | 2 +-
elf/tst-audit19b.c | 2 +-
elf/tst-audit22.c | 2 +-
elf/tst-audit23.c | 2 +-
elf/tst-audit25a.c | 4 +-
elf/tst-audit25b.c | 4 +-
elf/tst-glibc-hwcaps-2-cache.c | 2 +-
elf/tst-rtld-run-static.c | 4 +-
elf/tst-tunables-enable_secure.c | 136 ++++++++++++++++++---
elf/tst-tunables.c | 63 +++++++++-
scripts/gen-tunables.awk | 16 ++-
support/capture_subprocess.h | 9 +-
support/subprocess.h | 7 +-
support/support_capture_subprocess.c | 5 +-
support/support_subprocess.c | 5 +-
support/tst-support_capture_subprocess.c | 2 +-
sysdeps/aarch64/multiarch/memset_generic.S | 4 +
sysdeps/sparc/sparc64/rtld-memset.c | 3 +
sysdeps/x86/tst-hwcap-tunables.c | 2 +-
20 files changed, 310 insertions(+), 78 deletions(-)
--
2.43.0
next reply other threads:[~2024-05-06 16:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 16:18 Adhemerval Zanella [this message]
2024-05-06 16:18 ` [PATCH v3 1/4] elf: Only process multiple tunable once (BZ 31686) Adhemerval Zanella
2024-05-06 16:18 ` [PATCH v3 2/4] elf: Remove glibc.rtld.enable_secure check from parse_tunables_string Adhemerval Zanella
2024-05-06 16:18 ` [PATCH v3 3/4] support: Add envp argument to support_capture_subprogram Adhemerval Zanella
2024-05-06 16:18 ` [PATCH v3 4/4] elf: Make glibc.rtld.enable_secure ignore alias environment variables Adhemerval Zanella
2024-05-07 14:33 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506161955.1570278-1-adhemerval.zanella@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=josimmon@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).