From: "A. Wilcox" <AWilcox@Wilcox-Tech.com>
To: libc-alpha@sourceware.org
Cc: "A. Wilcox" <AWilcox@Wilcox-Tech.com>
Subject: [PATCH] x86: Ensure MINIMUM_X86_ISA_LEVEL=0 for baseline [BZ #31867]
Date: Sun, 9 Jun 2024 08:39:33 -0500 [thread overview]
Message-ID: <20240609133933.62366-1-AWilcox@Wilcox-Tech.com> (raw)
The value of MINIMUM_X86_ISA_LEVEL starts at 0 for true baseline x86
processors; 1 includes SSE and SSE2. Before this change, building glibc
for a target without SSE/SSE2 (such as a Pentium 3 or an Athlon XP)
would result in the following error:
/usr/lib/libc.so.6: CPU ISA level is lower than required
Fixes: 46c9997413 ("x86: Define MINIMUM_X86_ISA_LEVEL in config.h [BZ #31676]")
Signed-off-by: A. Wilcox <AWilcox@Wilcox-Tech.com>
---
sysdeps/x86/configure | 2 +-
sysdeps/x86/configure.ac | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sysdeps/x86/configure b/sysdeps/x86/configure
index d28d9bcb29..7cf243efb1 100644
--- a/sysdeps/x86/configure
+++ b/sysdeps/x86/configure
@@ -152,7 +152,7 @@ else
libc_cv_have_x86_isa_level=baseline
fi
if test $libc_cv_have_x86_isa_level = baseline; then
- printf "%s\n" "#define MINIMUM_X86_ISA_LEVEL 1" >>confdefs.h
+ printf "%s\n" "#define MINIMUM_X86_ISA_LEVEL 0" >>confdefs.h
else
printf "%s\n" "#define MINIMUM_X86_ISA_LEVEL $libc_cv_have_x86_isa_level" >>confdefs.h
diff --git a/sysdeps/x86/configure.ac b/sysdeps/x86/configure.ac
index 5b0acd03d2..2b1070cd98 100644
--- a/sysdeps/x86/configure.ac
+++ b/sysdeps/x86/configure.ac
@@ -106,7 +106,7 @@ else
libc_cv_have_x86_isa_level=baseline
fi
if test $libc_cv_have_x86_isa_level = baseline; then
- AC_DEFINE_UNQUOTED(MINIMUM_X86_ISA_LEVEL, 1)
+ AC_DEFINE_UNQUOTED(MINIMUM_X86_ISA_LEVEL, 0)
else
AC_DEFINE_UNQUOTED(MINIMUM_X86_ISA_LEVEL, $libc_cv_have_x86_isa_level)
fi
--
2.40.0
next reply other threads:[~2024-06-09 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-09 13:39 A. Wilcox [this message]
2024-06-09 21:18 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240609133933.62366-1-AWilcox@Wilcox-Tech.com \
--to=awilcox@wilcox-tech.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).