[PATCH v6] MIPSr6/math: Use builtin fma and fmaf

[PATCH v6] MIPSr6/math: Use builtin fma and fmaf

[YunQiang Su]

From: YunQiang Su <syq@gcc.gnu.org>

MIPSr6 has MADDF.s/MADDF.d instructions, which are fused.

In MIPS ISA, double support can be subsetted.  Only FMAF is enabled
for this case.

	* sysdeps/mips/fpu/math-use-builtins-fma.h

Signed-off-by: YunQiang Su <syq@gcc.gnu.org>
---
 sysdeps/mips/fpu/math-use-builtins-fma.h | 36 ++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 sysdeps/mips/fpu/math-use-builtins-fma.h

diff --git a/sysdeps/mips/fpu/math-use-builtins-fma.h b/sysdeps/mips/fpu/math-use-builtins-fma.h
new file mode 100644
index 0000000000..8528b77336
--- /dev/null
+++ b/sysdeps/mips/fpu/math-use-builtins-fma.h
@@ -0,0 +1,36 @@
+/* Copyright (C) 2024 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+/* MIPSr6 has MADDF.s/MADDF.d instructions, which are fused.  In MIPS
+ISA, double support can be subsetted.  Only FMAF is enabled for this
+case.  */
+
+#include <sysdep.h>
+
+#if __mips_isa_rev >= 6
+# ifdef __mips_single_float
+#  define USE_FMA_BUILTIN 0
+# else
+#  define USE_FMA_BUILTIN 1
+# endif
+# define USE_FMAF_BUILTIN 1
+#else
+# define USE_FMA_BUILTIN 0
+# define USE_FMAF_BUILTIN 0
+#endif
+#define USE_FMAL_BUILTIN 0
+#define USE_FMAF128_BUILTIN 0
-- 
2.39.3 (Apple Git-146)

Re: [PATCH v6] MIPSr6/math: Use builtin fma and fmaf

[YunQiang Su]

Gently ping and CC Andreas.

YunQiang Su <syq@debian.org> 于2024年6月21日周五 00:08写道：
>
> From: YunQiang Su <syq@gcc.gnu.org>
>
> MIPSr6 has MADDF.s/MADDF.d instructions, which are fused.
>
> In MIPS ISA, double support can be subsetted.  Only FMAF is enabled
> for this case.
>
>         * sysdeps/mips/fpu/math-use-builtins-fma.h
>
> Signed-off-by: YunQiang Su <syq@gcc.gnu.org>
> ---
>  sysdeps/mips/fpu/math-use-builtins-fma.h | 36 ++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644 sysdeps/mips/fpu/math-use-builtins-fma.h
>
> diff --git a/sysdeps/mips/fpu/math-use-builtins-fma.h b/sysdeps/mips/fpu/math-use-builtins-fma.h
> new file mode 100644
> index 0000000000..8528b77336
> --- /dev/null
> +++ b/sysdeps/mips/fpu/math-use-builtins-fma.h
> @@ -0,0 +1,36 @@
> +/* Copyright (C) 2024 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <https://www.gnu.org/licenses/>.  */
> +
> +/* MIPSr6 has MADDF.s/MADDF.d instructions, which are fused.  In MIPS
> +ISA, double support can be subsetted.  Only FMAF is enabled for this
> +case.  */
> +
> +#include <sysdep.h>
> +
> +#if __mips_isa_rev >= 6
> +# ifdef __mips_single_float
> +#  define USE_FMA_BUILTIN 0
> +# else
> +#  define USE_FMA_BUILTIN 1
> +# endif
> +# define USE_FMAF_BUILTIN 1
> +#else
> +# define USE_FMA_BUILTIN 0
> +# define USE_FMAF_BUILTIN 0
> +#endif
> +#define USE_FMAL_BUILTIN 0
> +#define USE_FMAF128_BUILTIN 0
> --
> 2.39.3 (Apple Git-146)
>

Re: [PATCH v6] MIPSr6/math: Use builtin fma and fmaf

[Adhemerval Zanella Netto]

On 25/06/24 00:02, YunQiang Su wrote:
> Gently ping and CC Andreas.
> 
> YunQiang Su <syq@debian.org> 于2024年6月21日周五 00:08写道：
>>
>> From: YunQiang Su <syq@gcc.gnu.org>
>>
>> MIPSr6 has MADDF.s/MADDF.d instructions, which are fused.
>>
>> In MIPS ISA, double support can be subsetted.  Only FMAF is enabled
>> for this case.
>>
>>         * sysdeps/mips/fpu/math-use-builtins-fma.h
>>
>> Signed-off-by: YunQiang Su <syq@gcc.gnu.org>

LGTM.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

>> ---
>>  sysdeps/mips/fpu/math-use-builtins-fma.h | 36 ++++++++++++++++++++++++
>>  1 file changed, 36 insertions(+)
>>  create mode 100644 sysdeps/mips/fpu/math-use-builtins-fma.h
>>
>> diff --git a/sysdeps/mips/fpu/math-use-builtins-fma.h b/sysdeps/mips/fpu/math-use-builtins-fma.h
>> new file mode 100644
>> index 0000000000..8528b77336
>> --- /dev/null
>> +++ b/sysdeps/mips/fpu/math-use-builtins-fma.h
>> @@ -0,0 +1,36 @@
>> +/* Copyright (C) 2024 Free Software Foundation, Inc.
>> +   This file is part of the GNU C Library.
>> +
>> +   The GNU C Library is free software; you can redistribute it and/or
>> +   modify it under the terms of the GNU Lesser General Public
>> +   License as published by the Free Software Foundation; either
>> +   version 2.1 of the License, or (at your option) any later version.
>> +
>> +   The GNU C Library is distributed in the hope that it will be useful,
>> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>> +   Lesser General Public License for more details.
>> +
>> +   You should have received a copy of the GNU Lesser General Public
>> +   License along with the GNU C Library; if not, see
>> +   <https://www.gnu.org/licenses/>.  */
>> +
>> +/* MIPSr6 has MADDF.s/MADDF.d instructions, which are fused.  In MIPS
>> +ISA, double support can be subsetted.  Only FMAF is enabled for this
>> +case.  */
>> +
>> +#include <sysdep.h>
>> +
>> +#if __mips_isa_rev >= 6
>> +# ifdef __mips_single_float
>> +#  define USE_FMA_BUILTIN 0
>> +# else
>> +#  define USE_FMA_BUILTIN 1
>> +# endif
>> +# define USE_FMAF_BUILTIN 1
>> +#else
>> +# define USE_FMA_BUILTIN 0
>> +# define USE_FMAF_BUILTIN 0
>> +#endif
>> +#define USE_FMAL_BUILTIN 0
>> +#define USE_FMAF128_BUILTIN 0
>> --
>> 2.39.3 (Apple Git-146)
>>