public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Cc: Anderson Nascimento <anderson@allelesecurity.com>,
	Carlos O'Donell <carlos@redhat.com>
Subject: [PATCH 7/8] Consolidate dl-osinfo.h into the generic implementation
Date: Tue,  2 Jun 2026 21:04:38 -0300	[thread overview]
Message-ID: <20260603000656.3287796-8-adhemerval.zanella@linaro.org> (raw)
In-Reply-To: <20260603000656.3287796-1-adhemerval.zanella@linaro.org>

The generic and the Linux _dl_setup_stack_chk_guard and
_dl_setup_pointer_guard are identical when the kernel provides the
AT_RANDOM auxiliary vector, which is always the case on the supported
Linux kernels; the generic version only adds a fallback for a missing
AT_RANDOM.  Remove the Linux-specific dl-osinfo.h and use the generic
one for all targets.

The removed header pulled in <dl-sysdep.h>, which is what transitively
declared __libc_enable_secure for dl-parse_auxv.h; include <unistd.h>
there directly so it no longer relies on that.  Include <string.h> in
the generic header so it is self-contained.
---
 sysdeps/generic/dl-osinfo.h             |  1 +
 sysdeps/unix/sysv/linux/dl-osinfo.h     | 54 -------------------------
 sysdeps/unix/sysv/linux/dl-parse_auxv.h |  1 +
 3 files changed, 2 insertions(+), 54 deletions(-)
 delete mode 100644 sysdeps/unix/sysv/linux/dl-osinfo.h

diff --git a/sysdeps/generic/dl-osinfo.h b/sysdeps/generic/dl-osinfo.h
index de46926abc9..5bb55cfe8a1 100644
--- a/sysdeps/generic/dl-osinfo.h
+++ b/sysdeps/generic/dl-osinfo.h
@@ -18,6 +18,7 @@
 
 #include <endian.h>
 #include <stdint.h>
+#include <string.h>
 
 static inline uintptr_t __attribute__ ((always_inline))
 _dl_setup_stack_chk_guard (void *dl_random)
diff --git a/sysdeps/unix/sysv/linux/dl-osinfo.h b/sysdeps/unix/sysv/linux/dl-osinfo.h
deleted file mode 100644
index 5ff92b76f96..00000000000
--- a/sysdeps/unix/sysv/linux/dl-osinfo.h
+++ /dev/null
@@ -1,54 +0,0 @@
-/* Operating system specific code for generic dynamic loader functions.  Linux.
-   Copyright (C) 2000-2026 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <https://www.gnu.org/licenses/>.  */
-
-#include <dl-sysdep.h>
-#include <endian.h>
-#include <fcntl.h>
-#include <stdint.h>
-#include <not-cancel.h>
-
-static inline uintptr_t __attribute__ ((always_inline))
-_dl_setup_stack_chk_guard (void *dl_random)
-{
-  union
-  {
-    uintptr_t num;
-    unsigned char bytes[sizeof (uintptr_t)];
-  } ret;
-
-  /* We need in the moment only 8 bytes on 32-bit platforms and 16
-     bytes on 64-bit platforms.  Therefore we can use the data
-     directly and not use the kernel-provided data to seed a PRNG.  */
-  memcpy (ret.bytes, dl_random, sizeof (ret));
-#if BYTE_ORDER == LITTLE_ENDIAN
-  ret.num &= ~(uintptr_t) 0xff;
-#elif BYTE_ORDER == BIG_ENDIAN
-  ret.num &= ~((uintptr_t) 0xff << (8 * (sizeof (ret) - 1)));
-#else
-# error "BYTE_ORDER unknown"
-#endif
-  return ret.num;
-}
-
-static inline uintptr_t __attribute__ ((always_inline))
-_dl_setup_pointer_guard (void *dl_random, uintptr_t stack_chk_guard)
-{
-  uintptr_t ret;
-  memcpy (&ret, (char *) dl_random + sizeof (ret), sizeof (ret));
-  return ret;
-}
diff --git a/sysdeps/unix/sysv/linux/dl-parse_auxv.h b/sysdeps/unix/sysv/linux/dl-parse_auxv.h
index 69b6905f7ce..d1cd4373239 100644
--- a/sysdeps/unix/sysv/linux/dl-parse_auxv.h
+++ b/sysdeps/unix/sysv/linux/dl-parse_auxv.h
@@ -22,6 +22,7 @@
 #include <ldsodefs.h>
 #include <link.h>
 #include <rseq-internal.h>
+#include <unistd.h>		/* For __libc_enable_secure.  */
 
 typedef ElfW(Addr) dl_parse_auxv_t[AT_MINSIGSTKSZ + 1];
 
-- 
2.43.0


  parent reply	other threads:[~2026-06-03  0:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03  0:04 [PATCH 0/8] Pointer guard hardening and consolidation Adhemerval Zanella
2026-06-03  0:04 ` [PATCH 1/8] elf: Propagate the pointer guard to ld.so loaded via static dlopen (BZ 34196) Adhemerval Zanella
2026-06-10  1:35   ` DJ Delorie
2026-06-10 12:14     ` Adhemerval Zanella Netto
2026-06-30 18:15   ` Sachin Monga
2026-06-30 19:56     ` Adhemerval Zanella Netto
2026-06-03  0:04 ` [PATCH 2/8] Consolidate pointer guard to use a relro variable instead of the TCB Adhemerval Zanella
2026-06-10  3:03   ` DJ Delorie
2026-06-03  0:04 ` [PATCH 3/8] Enable the pointer guard in the dynamic loader Adhemerval Zanella
2026-06-10 19:37   ` DJ Delorie
2026-06-03  0:04 ` [PATCH 4/8] Split pointer_guard.h into C and assembly headers Adhemerval Zanella
2026-06-10 20:12   ` DJ Delorie
2026-06-03  0:04 ` [PATCH 5/8] Consolidate the C pointer guard implementation into the generic header Adhemerval Zanella
2026-06-10 21:14   ` DJ Delorie
2026-06-11 18:59     ` Adhemerval Zanella Netto
2026-06-03  0:04 ` [PATCH 6/8] Add the pointer guard rotate to the assembly implementations Adhemerval Zanella
2026-06-10 21:36   ` DJ Delorie
2026-06-12 14:18     ` Adhemerval Zanella Netto
2026-06-03  0:04 ` Adhemerval Zanella [this message]
2026-06-10 21:43   ` [PATCH 7/8] Consolidate dl-osinfo.h into the generic implementation DJ Delorie
2026-06-03  0:04 ` [PATCH 8/8] elf: Scrub and reseed the AT_RANDOM bytes after deriving the guards (BZ 34197) Adhemerval Zanella
2026-06-10 22:05   ` DJ Delorie
2026-06-11 19:57     ` Adhemerval Zanella Netto
2026-06-11 20:25       ` DJ Delorie
2026-06-11 20:36         ` Adhemerval Zanella Netto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260603000656.3287796-8-adhemerval.zanella@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=anderson@allelesecurity.com \
    --cc=carlos@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).