From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 776443948A4A for ; Wed, 5 Apr 2023 14:07:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 776443948A4A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 335DOg3O005377 for ; Wed, 5 Apr 2023 14:07:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=4ANYUPdEFYPzk6DF2DHbhhjY75Dr9aIvd46A2JlfsBc=; b=X2An5/pzhwTSzkz/Z3vUlTEjr59d/3ZQqCmQwueiMF1KbTgylfyREerwAPT5abOBXWFB QT47/Y8SV6lGml1ZXqSPbzwOIkMWvM3wu9Dj+Jqd1zSzAmjfGP3FX1Yk4jwHVi2qRgAS OHxrRW3q0yXx9RD1r88Wo7PWRAv3qZ0fOKSI4I/ND4fTltxb3UmYABVwfyMFNrGwCcWT 4hp6InSm+HO+Pvm47jXGrToAnLldq8fLE5BqIKFGAehehFP6ININ0w2t/EVH7RBZ4BfK GRm4zN0svN1F+GMxDxs3hmw7/356uRcZoTXn1UugCXm+TBq+FXfHDEe+yCR49vjlS52W dQ== Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3ps9umh9vx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 05 Apr 2023 14:07:28 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 334NupVi003364 for ; Wed, 5 Apr 2023 14:07:27 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3ppc873ce5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 05 Apr 2023 14:07:26 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 335E7OEC29557368 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 5 Apr 2023 14:07:24 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 83F5B20049 for ; Wed, 5 Apr 2023 14:07:24 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5D38F20043 for ; Wed, 5 Apr 2023 14:07:24 +0000 (GMT) Received: from [9.171.34.131] (unknown [9.171.34.131]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP for ; Wed, 5 Apr 2023 14:07:24 +0000 (GMT) Message-ID: <204afb81-9dc6-f7fe-c707-a4f438815f55@linux.ibm.com> Date: Wed, 5 Apr 2023 16:07:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v5 1/1] memalign: Support scanning for aligned chunks. To: libc-alpha@sourceware.org References: Content-Language: en-US From: Stefan Liebler In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: dj-Qcd2qDv3Gf8n9JwzTht2j-_9fCMcI X-Proofpoint-GUID: dj-Qcd2qDv3Gf8n9JwzTht2j-_9fCMcI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-05_09,2023-04-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 spamscore=0 bulkscore=0 mlxlogscore=823 mlxscore=0 adultscore=0 priorityscore=1501 phishscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304050127 X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29.03.23 22:36, DJ Delorie via Libc-alpha wrote: > > Thanks! Pushed. > On s390 (31bit), I see the test fail: FAIL: malloc/tst-memalign-2-mcheck After adding those printfs ...: diff --git a/malloc/tst-memalign-2.c b/malloc/tst-memalign-2.c index 4996578e9f..adfebf8384 100644 --- a/malloc/tst-memalign-2.c +++ b/malloc/tst-memalign-2.c @@ -72,10 +72,12 @@ do_test (void) { tcache_allocs[i].ptr1 = memalign (tcache_allocs[i].alignment, tcache_allocs[i].size); CHECK (tcache_allocs[i].ptr1, tcache_allocs[i].alignment); + printf ("%d# ptr1=%p\n", i, tcache_allocs[i].ptr1); free (tcache_allocs[i].ptr1); /* This should return the same chunk as was just free'd. */ tcache_allocs[i].ptr2 = memalign (tcache_allocs[i].alignment, tcache_allocs[i].size); CHECK (tcache_allocs[i].ptr2, tcache_allocs[i].alignment); + printf ("%d# ptr2=%p\n", i, tcache_allocs[i].ptr2); free (tcache_allocs[i].ptr2); TEST_VERIFY (tcache_allocs[i].ptr1 == tcache_allocs[i].ptr2); ... I've got this output: 0# ptr1=0x55bc71b8 0# ptr2=0x55bc71b8 1# ptr1=0x55bc7210 1# ptr2=0x55bc7260 error: tst-memalign-2.c:83: not true: tcache_allocs[i].ptr1 == tcache_allocs[i].ptr2 2# ptr1=0x55bc72e0 2# ptr2=0x55bc72e0 error: 1 test failures malloc/tst-memalign-2 (without mcheck) is passing. PASS: malloc/tst-memalign-2 original exit status 0 0# ptr1=0x55c0e190 0# ptr2=0x55c0e190 1# ptr1=0x55c0e190 1# ptr2=0x55c0e190 2# ptr1=0x55c0e1c0 2# ptr2=0x55c0e1c0 Can you please help. Thanks, Stefan