From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51769 invoked by alias); 17 Oct 2018 10:28:14 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 51757 invoked by uid 89); 17 Oct 2018 10:28:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=H*Ad:D*ibm.com X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH] Fix race in pthread_mutex_lock while promoting to PTHREAD_MUTEX_ELISION_NP [BZ #23275] To: Florian Weimer Cc: GNU C Library , Torvald Riegel , "Carlos O'Donell" References: <874ldm3v09.fsf@oldenburg.str.redhat.com> From: Stefan Liebler Date: Wed, 17 Oct 2018 10:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <874ldm3v09.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit x-cbid: 18101710-0028-0000-0000-00000308A15E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18101710-0029-0000-0000-000023C3B32A Message-Id: <20603cf9-6427-d7da-8bf6-b2eed6abb61a@linux.ibm.com> X-SW-Source: 2018-10/txt/msg00287.txt.bz2 On 10/16/2018 03:01 PM, Florian Weimer wrote: > * Stefan Liebler: > >> The flag PTHREAD_MUTEX_NO_ELISION_NP is not explicitly checked before >> FORCE_ELISION is called. But only one of those two flags can be set. >> Your remaining assumption is correct. >> I've changed the comment in the three force-elision.h files. Is this >> okay? > > The comment looks good to me know. Thanks! > > Florian > Committed, bugzilla closed and target milestone is set to 2.29. Thanks, Stefan