From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by sourceware.org (Postfix) with ESMTPS id 7F0323858D37 for ; Wed, 20 Jul 2022 14:34:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F0323858D37 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-10d9213b77aso531591fac.5 for ; Wed, 20 Jul 2022 07:34:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=DhCsKOysvT2G1cZkgDXIdWNO8cluOvte7Afp4emSyvo=; b=RzrilpLfnso9ihT/9UlXKX/IxRTRIu9GohDCJ8//NrfhMVIZBDg8sE9e1C+Lt8OL1O fcKQK4bdudHfj60vLy7Htah1EZj7jUmwHlbX73eC5kTcJdhnuMYtAxXUzY8wwasa5GnW XOI2rEtwaLckWOY7kO3MCAIfpFlR0r/pB+OEoMaiV3bia0MfEX7pkRRtLqG9PYIvQe6d WL6BDFznITtBlNtXL42nAEN44BoycMxMLWazJeWJlQVDajjmZVSjFbjX5Hd82L/BROWW vXMPCsCJnQztGGvSRthx1+eCTQLD7Bo+V1JFAydIzIhcjcVOe97JuZ8Vb3nb7YSEfGw/ KLKg== X-Gm-Message-State: AJIora9MBrFDhi38Vu6b/D8p3AaLHhwDroFGq5am1noYcRMVfd0blQCN 1gHv8iY30EANwL/b7NU8nlw9SA== X-Google-Smtp-Source: AGRyM1uVCdw7fNEpa3ImAqTdJpUTbnLmG2L84gNladsYply8e5KTUPvlG+JLE5vjwc8DFZxApwqqEA== X-Received: by 2002:a05:6870:f286:b0:10b:8bcc:880a with SMTP id u6-20020a056870f28600b0010b8bcc880amr2653341oap.299.1658327667703; Wed, 20 Jul 2022 07:34:27 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:8ded:dd7a:8a21:1a2b:76c5? ([2804:431:c7cb:8ded:dd7a:8a21:1a2b:76c5]) by smtp.gmail.com with ESMTPSA id w21-20020a9d6755000000b0061c9c7813d4sm4267158otm.24.2022.07.20.07.34.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jul 2022 07:34:27 -0700 (PDT) Message-ID: <20ff09df-cd4e-c282-95cd-f73f95c8bf09@linaro.org> Date: Wed, 20 Jul 2022 11:34:24 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH v7 04/13] LoongArch: Thread-Local Storage Support Content-Language: en-US To: caiyinyu , libc-alpha@sourceware.org, joseph_myers@mentor.com, carlos@redhat.com, i.swmail@xen0n.name References: <20220719012056.1461897-1-caiyinyu@loongson.cn> <20220719012056.1461897-5-caiyinyu@loongson.cn> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20220719012056.1461897-5-caiyinyu@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2022 14:34:30 -0000 LGTM, thanks. Reviewed-by: Adhemerval Zanella On 18/07/22 22:20, caiyinyu wrote: > --- > sysdeps/loongarch/dl-tls.h | 46 ++++++++++++ > sysdeps/loongarch/libc-tls.c | 32 ++++++++ > sysdeps/loongarch/nptl/tls.h | 138 ++++++++++++++++++++++++++++++++++ > sysdeps/loongarch/stackinfo.h | 33 ++++++++ > 4 files changed, 249 insertions(+) > create mode 100644 sysdeps/loongarch/dl-tls.h > create mode 100644 sysdeps/loongarch/libc-tls.c > create mode 100644 sysdeps/loongarch/nptl/tls.h > create mode 100644 sysdeps/loongarch/stackinfo.h > > diff --git a/sysdeps/loongarch/dl-tls.h b/sysdeps/loongarch/dl-tls.h > new file mode 100644 > index 0000000000..f82edcae76 > --- /dev/null > +++ b/sysdeps/loongarch/dl-tls.h > @@ -0,0 +1,46 @@ > +/* Thread-local storage handling in the ELF dynamic linker. > + Copyright (C) 2022 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +/* Type used for the representation of TLS information in the GOT. */ > +typedef struct > +{ > + unsigned long int ti_module; > + unsigned long int ti_offset; > +} tls_index; > + > +/* The thread pointer points to the first static TLS block. */ > +#define TLS_TP_OFFSET 0 > + > +/* Dynamic thread vector pointers point to the start of each > + TLS block. */ > +#define TLS_DTV_OFFSET 0 > + > +/* Compute the value for a GOTTPREL reloc. */ > +#define TLS_TPREL_VALUE(sym_map, sym) \ > + ((sym_map)->l_tls_offset + (sym)->st_value - TLS_TP_OFFSET) > + > +/* Compute the value for a DTPREL reloc. */ > +#define TLS_DTPREL_VALUE(sym) ((sym)->st_value - TLS_DTV_OFFSET) > + > +extern void *__tls_get_addr (tls_index *ti); > + > +#define GET_ADDR_OFFSET (ti->ti_offset + TLS_DTV_OFFSET) > +#define __TLS_GET_ADDR(__ti) (__tls_get_addr (__ti) - TLS_DTV_OFFSET) > + > +/* Value used for dtv entries for which the allocation is delayed. */ > +#define TLS_DTV_UNALLOCATED ((void *) -1l) Ok. > diff --git a/sysdeps/loongarch/libc-tls.c b/sysdeps/loongarch/libc-tls.c > new file mode 100644 > index 0000000000..9285d11a7b > --- /dev/null > +++ b/sysdeps/loongarch/libc-tls.c > @@ -0,0 +1,32 @@ > +/* Thread-local storage handling in the ELF dynamic linker. > + Copyright (C) 2022 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +#include > +#include > + > +/* On LoongArch, linker optimizations are not required, so __tls_get_addr > + can be called even in statically linked binaries. In this case module > + must be always 1 and PT_TLS segment exist in the binary, otherwise it > + would not link. */ > + > +void * > +__tls_get_addr (tls_index *ti) > +{ > + dtv_t *dtv = THREAD_DTV (); > + return (char *) dtv[1].pointer.val + GET_ADDR_OFFSET; > +} Ok. > diff --git a/sysdeps/loongarch/nptl/tls.h b/sysdeps/loongarch/nptl/tls.h > new file mode 100644 > index 0000000000..3b271c4b60 > --- /dev/null > +++ b/sysdeps/loongarch/nptl/tls.h > @@ -0,0 +1,138 @@ > +/* Definition for thread-local data handling. > + Copyright (C) 2022 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +#ifndef _LOONGARCH_TLS_H > +#define _LOONGARCH_TLS_H 1 > + > +#include > + > +#ifndef __ASSEMBLER__ > +#include > +#include > +#include > +#include > + > +register void *__thread_self asm ("$tp"); > +#define READ_THREAD_POINTER() ({ __thread_self; }) > + > +/* Get system call information. */ > +#include > + > +/* The TP points to the start of the thread blocks. */ > +#define TLS_DTV_AT_TP 1 > +#define TLS_TCB_AT_TP 0 > + > +/* Get the thread descriptor definition. */ > +#include > + > +typedef struct > +{ > + dtv_t *dtv; > + void *private; > +} tcbhead_t; > + > +/* This is the size of the initial TCB. Because our TCB is before the thread > + pointer, we don't need this. */ > +#define TLS_INIT_TCB_SIZE 0 > + > +/* Alignment requirements for the initial TCB. */ > +#define TLS_INIT_TCB_ALIGN __alignof__(struct pthread) > + > +/* This is the size of the TCB. Because our TCB is before the thread > + pointer, we don't need this. */ > +#define TLS_TCB_SIZE 0 > + > +/* Alignment requirements for the TCB. */ > +#define TLS_TCB_ALIGN __alignof__(struct pthread) > + > +/* This is the size we need before TCB - actually, it includes the TCB. */ > +#define TLS_PRE_TCB_SIZE \ > + (sizeof (struct pthread) \ > + + ((sizeof (tcbhead_t) + TLS_TCB_ALIGN - 1) & ~(TLS_TCB_ALIGN - 1))) > + > +/* The thread pointer tp points to the end of the TCB. > + The pthread_descr structure is immediately in front of the TCB. */ > +#define TLS_TCB_OFFSET 0 > + > +/* Install the dtv pointer. The pointer passed is to the element with > + index -1 which contain the length. */ > +#define INSTALL_DTV(tcbp, dtvp) (((tcbhead_t *) (tcbp))[-1].dtv = (dtvp) + 1) > + > +/* Install new dtv for current thread. */ > +#define INSTALL_NEW_DTV(dtv) (THREAD_DTV () = (dtv)) > + > +/* Return dtv of given thread descriptor. */ > +#define GET_DTV(tcbp) (((tcbhead_t *) (tcbp))[-1].dtv) > + > +/* Code to initially initialize the thread pointer. */ > +#define TLS_INIT_TP(tcbp) \ > + ({ \ > + __thread_self = (char *) tcbp + TLS_TCB_OFFSET; \ > + NULL; \ > + }) > + > +/* Return the address of the dtv for the current thread. */ > +#define THREAD_DTV() \ > + (((tcbhead_t *) (READ_THREAD_POINTER () - TLS_TCB_OFFSET))[-1].dtv) > + > +/* Return the thread descriptor for the current thread. */ > +#define THREAD_SELF \ > + ((struct pthread *) (READ_THREAD_POINTER () - TLS_TCB_OFFSET \ > + - TLS_PRE_TCB_SIZE)) > + > +/* Value passed to 'clone' for initialization of the thread register. */ > +#define TLS_DEFINE_INIT_TP(tp, pd) \ > + void *tp = (void *) (pd) + TLS_TCB_OFFSET + TLS_PRE_TCB_SIZE > + > +/* Informs libthread_db that the thread pointer is register 2, which is used > + * to know how to do THREAD_SELF. */ > +#define DB_THREAD_SELF \ > + REGISTER (64, 64, 2 * 8, -TLS_TCB_OFFSET - TLS_PRE_TCB_SIZE) > + > +/* Access to data in the thread descriptor is easy. */ > +# include > + > +/* l_tls_offset == 0 is perfectly valid, so we have to use some different > + value to mean unset l_tls_offset. */ > +#define NO_TLS_OFFSET -1 > + > +/* Get and set the global scope generation counter in struct pthread. */ > +#define THREAD_GSCOPE_IN_TCB 1 > +#define THREAD_GSCOPE_FLAG_UNUSED 0 > +#define THREAD_GSCOPE_FLAG_USED 1 > +#define THREAD_GSCOPE_FLAG_WAIT 2 > +#define THREAD_GSCOPE_RESET_FLAG() \ > + do \ > + { \ > + int __res = atomic_exchange_rel (&THREAD_SELF->header.gscope_flag, \ > + THREAD_GSCOPE_FLAG_UNUSED); \ > + if (__res == THREAD_GSCOPE_FLAG_WAIT) \ > + lll_futex_wake (&THREAD_SELF->header.gscope_flag, 1, LLL_PRIVATE); \ > + } \ > + while (0) > +#define THREAD_GSCOPE_SET_FLAG() \ > + do \ > + { \ > + THREAD_SELF->header.gscope_flag = THREAD_GSCOPE_FLAG_USED; \ > + atomic_write_barrier (); \ > + } \ > + while (0) > + > +#endif /* __ASSEMBLER__ */ > + > +#endif /* tls.h */ Ok. > diff --git a/sysdeps/loongarch/stackinfo.h b/sysdeps/loongarch/stackinfo.h > new file mode 100644 > index 0000000000..ff8b9b7bf2 > --- /dev/null > +++ b/sysdeps/loongarch/stackinfo.h > @@ -0,0 +1,33 @@ > +/* Stack environment definitions for LoongArch. > + Copyright (C) 2022 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +/* This file contains a bit of information about the stack allocation > + of the processor. */ > + > +#ifndef _STACKINFO_H > +#define _STACKINFO_H 1 > + > +#include > + > +/* On LoongArch the stack grows down. */ > +#define _STACK_GROWS_DOWN 1 > + > +/* Default to a non-executable stack. */ > +#define DEFAULT_STACK_PERMS (PF_R | PF_W) > + > +#endif /* stackinfo.h */ Ok.