From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bumble.birch.relay.mailchannels.net (bumble.birch.relay.mailchannels.net [23.83.209.25]) by sourceware.org (Postfix) with ESMTPS id D07533858CDA for ; Wed, 26 Apr 2023 12:12:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D07533858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 2D99C88127D; Wed, 26 Apr 2023 12:12:52 +0000 (UTC) Received: from pdx1-sub0-mail-a304.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id CE21E8811FC; Wed, 26 Apr 2023 12:12:50 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1682511170; a=rsa-sha256; cv=none; b=kpE7NDm3T+IPzmviq19aFr/TsMzyfeEICLSzE3cUvLJcG0Htkb673A/EMS1RXs+eDST/mV Npx8b/+SHU3TjndklFtCV+iy0f/n72p7SOEm1EJC354GqzY1SZe9BtxBPdZyFSYsd4tVs/ y/mGzyomqQLFj9c2UC0LYQ3vYNXrRo1CMdaB7AtSGAieagIcdsK3fGkrlT0g1Y3HlZW2ia WeN8eGKkv/8yh4Bn2eyxe5G1pV0MvtvJJ00FBlK2CzU2HyUORcCoqWoMQ59jrYKsrkKVqC ZlyeO7NNHgviRoD1ODGP/HA/C43LkxxO202mbPSL1x11MQy6ufYCnKV5w4YbFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1682511170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r2yeydxi7DxO1aMdB7lmDO+A66VtLq9hUsRtZEHlWlQ=; b=twQQ0yCT9lGwxNNuGN+L/BqspFPsXspnZqyRu5UYlhwpss3BvGgu0a6YvZfXgSLZlQbSnT yHWuse78/R+aIEB4jSzRIU5at7JF4mM9xgFxX/3G2kiAQaz/w8cWL3ok2YLZV71MWYLwXg xkoanr1lcqUTJ17Heumj4m7hlk9hjhuBOfC8i6T6nF4qQwuV3Ei3J6GMiO0yvWJGQPzGWT oMxdfWF6BnEQFHFCGEfdfDSfMVupDfZg5NEMp1lhKfOFDz4+IzJDoIR/j/fRiMv+BSKoyE GmmKHeJGn+jEf2H5TlRu1U8ySKUaDfIykl4EaqDsRXmKRpfAfm7fz6hzthnftQ== ARC-Authentication-Results: i=1; rspamd-7f66b7b68c-qnm22; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Relation-Language: 6981559408c24d7e_1682511171902_3747955969 X-MC-Loop-Signature: 1682511171902:1271668317 X-MC-Ingress-Time: 1682511171902 Received: from pdx1-sub0-mail-a304.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.101.8.80 (trex/6.7.2); Wed, 26 Apr 2023 12:12:51 +0000 Received: from [192.168.0.182] (bras-vprn-toroon4834w-lp130-09-174-91-45-80.dsl.bell.ca [174.91.45.80]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a304.dreamhost.com (Postfix) with ESMTPSA id 4Q5yS23PTWzFT; Wed, 26 Apr 2023 05:12:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1682511170; bh=r2yeydxi7DxO1aMdB7lmDO+A66VtLq9hUsRtZEHlWlQ=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=oHuFVJ2y1ehi6viactBcXALsQm7IjYYerxjV3rd9Uuq0y2AjfuvIOBxyYneuJHZew nGLwvmahxkZjtUyrRyAOpkVmsbgooNTxlSclZtt1E33oYdlJBYsbleNNNgSTcIATnE 0kDHfBuoXO5pGxmGyzF7vvD0OCaUdCKGvl4V+lYw+MdzJxY1mp19oSPaoxaMww4aAV 8tyMOnnMx6AsJuQqRiTYPg33kVR6pg8x0YVh+StPjAqSYonBBTjsZPVRYaEZ4CwEev aSZIeUIUW39Q9EUUFqDRZvdWczTYb/lTf1DykKfS6YUckGTXhJbSvUGIrICa0jGzBx LNv3IwJusVYRA== Message-ID: <2165c42e-f316-eae8-d26c-87b11ec071fd@gotplt.org> Date: Wed, 26 Apr 2023 08:12:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] locale/programs/locarchive.c: Remove unnecessary check in add_locale_archive Content-Language: en-US To: =?UTF-8?B?RnLDqWTDqXJpYyBCw6lyYXQ=?= , libc-alpha@sourceware.org References: <20230426121033.921725-1-fberat@redhat.com> From: Siddhesh Poyarekar In-Reply-To: <20230426121033.921725-1-fberat@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3037.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-04-26 08:10, Frédéric Bérat wrote: > Since asprintf is called "if (mask & XPG_NORM_CODESET)" there is no point > in checking the mask again within the asprintf call. > --- LGTM. Reviewed-by: Siddhesh Poyarekar > locale/programs/locarchive.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/locale/programs/locarchive.c b/locale/programs/locarchive.c > index f8c6f79afa..71fd9f34fa 100644 > --- a/locale/programs/locarchive.c > +++ b/locale/programs/locarchive.c > @@ -1156,7 +1156,7 @@ add_locale_to_archive (struct locarhandle *ah, const char *name, > We will store it in the archive with a normalized name. */ > if (asprintf (&normalized_name, "%s%s%s.%s%s%s", > language, territory == NULL ? "" : "_", territory ?: "", > - (mask & XPG_NORM_CODESET) ? normalized_codeset : codeset, > + normalized_codeset, > modifier == NULL ? "" : "@", modifier ?: "") < 0) > { > free ((char *) normalized_codeset);