From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Subject: Re: [PATCH v5 12/14] ARC: Build Infrastructure
Date: Sat, 18 Apr 2020 05:46:35 +0000 [thread overview]
Message-ID: <21685c3a-203e-5a84-2672-ea707d101e2a@synopsys.com> (raw)
In-Reply-To: <74631387-33f2-79cd-b47c-cca704657426@synopsys.com>
On 4/17/20 5:12 PM, Vineet Gupta via Libc-alpha wrote:
> On 4/17/20 4:10 PM, Joseph Myers wrote:
>> On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote:
>>
>>> + GLIBC_PRIVATE {
>>> + # A copy of sigaction lives in libpthread, and needs these.
>>> + __default_rt_sa_restorer;
>>> + }
>>
>> Not a requirement for this port, given that this is GLIBC_PRIVATE so can
>> always be changed later, but does sigaction actually need to live in
>> libpthread?
>
> From my old branches, I added this back in 2018 when working on some cancellation
> failures.
>
>> Or given the work that's been done on moving functions from
>> libpthread to libc (and the corresponding dynamic linker work that mean
>> it's now possible to move versioned symbols like that), could the copy of
>> sigaction in libpthread be removed?
>
> I don't think there's any ARC specific code which requires a restorer copy in
> libpthread. I can remove this and give the build a spin to see if anything breaks.
As of today, libpthread_pic.a includes sigaction.os hence the need for export as
well: removing it from Version file causes build errors.
But when sigaction.os dependency is removed, this won't be needed.
next prev parent reply other threads:[~2020-04-18 5:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 2:56 [PATCH v5 00/14] glibc port to ARC processors Vineet Gupta
2020-04-09 2:56 ` [PATCH v5 01/14] ARC: ABI Implementation Vineet Gupta
2020-04-17 22:37 ` Joseph Myers
2020-04-17 23:30 ` Vineet Gupta
2020-04-09 2:56 ` [PATCH v5 02/14] ARC: startup and dynamic linking code Vineet Gupta
2020-04-17 22:42 ` Joseph Myers
2020-04-17 23:40 ` Vineet Gupta
2020-04-09 2:56 ` [PATCH v5 03/14] ARC: Thread Local Storage support Vineet Gupta
2020-04-17 22:44 ` Joseph Myers
2020-04-17 23:43 ` Vineet Gupta
2020-04-09 2:56 ` [PATCH v5 04/14] ARC: Atomics and Locking primitives Vineet Gupta
2020-04-09 2:56 ` [PATCH v5 05/14] ARC: math soft float support Vineet Gupta
2020-04-09 2:56 ` [PATCH v5 06/14] ARC: hardware floating point support Vineet Gupta
2020-04-17 22:59 ` Joseph Myers
2020-04-17 23:49 ` Vineet Gupta
2020-04-20 18:21 ` Joseph Myers
2020-04-09 2:56 ` [PATCH v5 07/14] ARC: Linux Syscall Interface Vineet Gupta
2020-04-09 2:56 ` [PATCH v5 08/14] ARC: Linux ABI Vineet Gupta
2020-04-17 23:02 ` Joseph Myers
2020-04-17 23:52 ` Vineet Gupta
2020-04-09 2:56 ` [PATCH v5 09/14] ARC: Linux Startup and Dynamic Loading Vineet Gupta
2020-04-09 2:56 ` [PATCH v5 10/14] ARC: ABI lists Vineet Gupta
2020-04-09 2:56 ` [PATCH v5 11/14] ARC: Update syscall-names.list for ARC specific syscalls Vineet Gupta
2020-04-17 23:05 ` Joseph Myers
2020-04-17 23:53 ` Vineet Gupta
2020-04-18 10:31 ` Florian Weimer
2020-04-20 18:24 ` Joseph Myers
2020-04-09 2:56 ` [PATCH v5 12/14] ARC: Build Infrastructure Vineet Gupta
2020-04-17 23:10 ` Joseph Myers
2020-04-18 0:12 ` Vineet Gupta
2020-04-18 5:46 ` Vineet Gupta [this message]
2020-04-09 2:56 ` [PATCH v5 13/14] build-many-glibcs.py: Enable ARC builds Vineet Gupta
2020-04-17 23:12 ` Joseph Myers
2020-04-17 23:57 ` Vineet Gupta
2020-04-09 2:56 ` [PATCH v5 14/14] Documentation for ARC port Vineet Gupta
2020-04-17 23:13 ` Joseph Myers
2020-04-17 23:58 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21685c3a-203e-5a84-2672-ea707d101e2a@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).