From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [IPv6:2607:f8b0:4864:20::933]) by sourceware.org (Postfix) with ESMTPS id 337123858402 for ; Thu, 11 Nov 2021 17:29:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 337123858402 Received: by mail-ua1-x933.google.com with SMTP id l43so13392899uad.4 for ; Thu, 11 Nov 2021 09:29:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=vlOYQoaYI1dBbFFQJIygLH/REaABdNjeWpJLl2rTEYI=; b=2dLPzVSI7pSWHNGueYtBfNt9DeiW9US4Y8+LUmbRLBB8yfPfQgSLeU1QWK9ITUqwJD QlUab/a1OVnc8pfvixt3x6tMhlaa+1blL7V+MTxBVdX6VcM0xHDvBomFwUhoFrxuGBnD pB8cQiK+1JJdUhk8oqC2D/NtAKt58mO1jPMtXOUejsSbqRy12Kb9wMzI8u78XKIYWT3s l2zwpKx0mmhudqT7Jnz9BXCjxVVAGi1UChAABgmAhNzzqOkguUXSUqPEuO3SZ9O2Q3mC MVvtJCgBdNzOBqcPICBURw0AW/tTfRKURToha1g245t5qKvQZBhk0QF6+X4pGWgNTC6C hLbQ== X-Gm-Message-State: AOAM530NKC7we0Gx7NCFz7a9F6BzrkpeLJAldrD7SGBKYZ0xvIWYz0zR nSszKoUAQCwgc/2m7AQIrltfIg== X-Google-Smtp-Source: ABdhPJzHuIrO51qDzYNbW3kdrtw/dzcL34ltkdX+K7byKuJS/cgeJRHsSi6OriMHMQ2s7LHMI7DM2g== X-Received: by 2002:ab0:2a10:: with SMTP id o16mr12610327uar.36.1636651777598; Thu, 11 Nov 2021 09:29:37 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:55a:48f2:1d0b:8ae8:643a? ([2804:431:c7cb:55a:48f2:1d0b:8ae8:643a]) by smtp.gmail.com with ESMTPSA id v1sm2509512uac.18.2021.11.11.09.29.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Nov 2021 09:29:37 -0800 (PST) Message-ID: <216e9e0f-2183-f38e-dda1-c467e8a24a35@linaro.org> Date: Thu, 11 Nov 2021 14:29:35 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH v5 03/22] elf: Do not fail for failed dlopem on audit modules (BZ #28061) Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard References: <20211109183347.2943786-1-adhemerval.zanella@linaro.org> <20211109183347.2943786-4-adhemerval.zanella@linaro.org> <877ddg5cvl.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <877ddg5cvl.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2021 17:29:41 -0000 On 10/11/2021 11:00, Florian Weimer wrote: > * Adhemerval Zanella: > >> So the assert() on _dl_open() can not really see if the state is >> consistent since it is _dt_main() that reset is. This patch removes >> the assert. > > H.J. also mentioned the dlmopen typo. “since it is _dt_main() that > reset is” seems to have multiple typos, too. Ack. > > Patch itself looks okay.