On 06/21/2018 01:00 PM, Zack Weinberg wrote:
> On Thu, Jun 21, 2018 at 2:46 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> After commit d76d3703551a362b472c866b5b6089f66f8daa8e ("Fix missing
>> timespec definition for sys/stat.h (BZ #21371)"), sanitizer builds start
>> to fail due to a conflicting definition of struct timespec in
>> <linux/time.h>.  Define _STRUCT_TIMESPEC, which is already checked in
>> the kernel header, to support including <linux/time.h> after
>> <sys/stat.h>.
> 
> Should it go the other way around as well?  That is, if
> _STRUCT_TIMESPEC is already defined, should we suppress our
> definition?

Hmm, sure, that would be possible.

> Either way I think there should be a comment saying that linux/time.h
> checks this macro.

It's in generic code, so I wasn't sure if it was okay to refer to 
<linux/time.h>.  But I can certainly add that.

What about the attached patch?

Thanks,
Florian