From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 87EEE386180C for ; Thu, 10 Sep 2020 17:29:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 87EEE386180C Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08AHCu9W176385; Thu, 10 Sep 2020 13:29:50 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 33frbg0f5h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Sep 2020 13:29:49 -0400 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 08AHDEPS180805; Thu, 10 Sep 2020 13:29:49 -0400 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com with ESMTP id 33frbg0f59-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Sep 2020 13:29:49 -0400 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 08AHSO82021589; Thu, 10 Sep 2020 17:29:48 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma03dal.us.ibm.com with ESMTP id 33c2a9krdk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Sep 2020 17:29:48 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 08AHTluO59376106 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 10 Sep 2020 17:29:47 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9F01DBE054; Thu, 10 Sep 2020 17:29:47 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 16EBEBE051; Thu, 10 Sep 2020 17:29:45 +0000 (GMT) Received: from [9.160.79.3] (unknown [9.160.79.3]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 10 Sep 2020 17:29:45 +0000 (GMT) Subject: Re: [PATCH v2] powerpc: Update ULPs and output for j0 with ibm128 To: "Carlos O'Donell" , Tulio Magno Quites Machado Filho , Joseph Myers Cc: patsy@redhat.com, libc-alpha@sourceware.org References: <20200909165830.64343-1-msc@linux.ibm.com> <87een93g2f.fsf@linux.ibm.com> From: Matheus Castanho Message-ID: <21e7d6ad-4f5d-6e27-be81-1efa751d57cc@linux.ibm.com> Date: Thu, 10 Sep 2020 14:29:44 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-10_05:2020-09-10, 2020-09-10 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 mlxscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 phishscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009100153 X-Spam-Status: No, score=-14.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Sep 2020 17:29:54 -0000 On 9/10/20 2:08 PM, Carlos O'Donell wrote: > On 9/10/20 9:40 AM, Tulio Magno Quites Machado Filho wrote: >> Joseph Myers writes: >> >>> On Wed, 9 Sep 2020, Matheus Castanho wrote: >>> >>>> Instead of updating the ldouble ULPs for j0 with an upstream GCC, >>>> constantly increasing their values, this patch regenerates them with a >>>> GCC compiled with the patch mentioned above. This way we have the actual >>>> precise ULPs listed in libm-test-ulps. Of course, when compiling with >>>> an upstream compiler some tests will fail as the calculated ULPs will be >>>> higher than the expected ones. For such tests, we mark the >>>> corresponding entries in math/auto-libm-test-in with >>>> xfail-rounding:ibm128-libgcc. >>> >>> xfail-rounding:ibm128-libgcc is intended for the sort of edge cases where >>> upstream GCC produces results that are wildly off. It's not intended for >>> these sorts of cases where it gives slightly bigger ulps that are still >>> within the accepted bounds. >> >> Carlos, Joseph, >> >> I'm afraid that Matheus is either in a deadlock or we need a clearer >> explanation of what is acceptable for ibm128. >> >> Notice that Matheus' first patch was rejected because results were greater >> than 9. > > It was later shown to me that >9 ULPs was acceptable for ibm128, my apologies > for not being clearer that I was withdrawing my objection. > >> With that said, would both of you accept the first version of this patch? >> https://patchwork.sourceware.org/project/glibc/patch/20200820183700.115087-1-msc@linux.ibm.com/ > > Yes. > > Patsy Griffin from my team also suggested this on September 2nd, she > is seeing these failures in our own testing. It would be good to have > them resolved. > Thank you all for the feedback and clarification. In this case, I have a slightly updated version of that initial patch, which also updates the ULPs for float128 to fix other failing tests. Just need someone to push it for me. Thanks, Matheus Castanho --- 8< --- >From c55d5ab5f386a85f04dcc3b9b71b92ac6523e321 Mon Sep 17 00:00:00 2001 From: Matheus Castanho Date: Thu, 20 Aug 2020 15:37:00 -0300 Subject: [PATCH] Update powerpc libm-test-ulps Before this patch, the following tests were failing: ppc and ppc64: FAIL: math/test-ldouble-j0 ppc64le: FAIL: math/test-float128-j0 FAIL: math/test-float64x-j0 FAIL: math/test-ibm128-j0 FAIL: math/test-ldouble-j0 --- sysdeps/powerpc/fpu/libm-test-ulps | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sysdeps/powerpc/fpu/libm-test-ulps b/sysdeps/powerpc/fpu/libm-test-ulps index cd2a5fed45..fa2555f22b 100644 --- a/sysdeps/powerpc/fpu/libm-test-ulps +++ b/sysdeps/powerpc/fpu/libm-test-ulps @@ -1317,13 +1317,13 @@ Function: "j0_downward": double: 2 float: 4 float128: 4 -ldouble: 11 +ldouble: 12 Function: "j0_towardzero": double: 5 float: 6 -float128: 2 -ldouble: 8 +float128: 4 +ldouble: 16 Function: "j0_upward": double: 4 -- 2.26.2