From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-108902-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 51424 invoked by alias); 22 Jan 2020 12:36:25 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 51387 invoked by uid 89); 22 Jan 2020 12:36:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-22.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-HELO:sk:mail-qt, HContent-Transfer-Encoding:8bit
X-HELO: mail-qt1-f194.google.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=to:cc:references:from:autocrypt:subject:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=C4AH44sPAXYQv4QADHoYSbMOmEIktVBbFRPqI0JiJ7c=;
        b=TAnv8kgbQUIKfKkDmUalb9ExPEdPIMp7bpBB2HcPg31f03ax5Pk5j9zOQg5LiSCxyQ
         n2EZR3Wl3rneu0Nmpxh9GRQQ9IPqAALu3jnumTDOmFpT2m2qBM22WVUnmobIktDJbnvX
         QHyq/D3Mwx4U+CrDcbRxU8Z5Yeco2+G/1U2clpjFIsygGjNfO6XAzSA9++w0r79c8rLE
         eA5YvqUt+AufLZUAV4fdRX8YBT7TfsJDD2klaNTHbq8dlwS/XXuRXsJ11ogoINjwXOeZ
         ASTyb/joPxZp6kEOssteV6HoVE/vJpzw3rRicM4WH3yy2iAQy2YKuF2SBkr2h87ce1Rh
         6T+g==
Return-Path: <adhemerval.zanella@linaro.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: libc-alpha@sourceware.org
References: <20200114185255.25813-1-samuel.thibault@ens-lyon.org>
 <20200114185255.25813-12-samuel.thibault@ens-lyon.org>
 <e312ce6d-817c-d76b-3ab7-dc88201a1890@linaro.org>
 <20200121220158.x5vtnsqtrbbagq5z@function>
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH 10/10] C11 threads: Move implementation to sysdeps/pthread
Message-ID: <2286917f-18b0-94d0-2085-f42462134ea6@linaro.org>
Date: Wed, 22 Jan 2020 16:09:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200121220158.x5vtnsqtrbbagq5z@function>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-SW-Source: 2020-01/txt/msg00506.txt.bz2



On 21/01/2020 19:01, Samuel Thibault wrote:
> 
>>> diff --git a/sysdeps/nptl/thrd_create.c b/sysdeps/nptl/thrd_create.c
>>> new file mode 100644
>>> index 0000000000..a9219db7bc
>>> --- /dev/null
>>> +++ b/sysdeps/nptl/thrd_create.c
>>> @@ -0,0 +1,2 @@
>>> +#define __pthread_create __pthread_create_2_1
>>> +#include "../pthread/thrd_create.c"
>>
>> I think it better to include fall path instead of relative one.
> 
> Do you mean using #include_next ? That does not work, gcc warns that it's
> discouraged in primary source file.

I meant 

#include <sysdeps/pthread/thrd_create.c>

I think it is clearly at source level to which file it refers and
require less change if the file is moved.