From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id B01813858D20 for ; Mon, 1 Apr 2024 16:50:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B01813858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B01813858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711990229; cv=none; b=taCk3wlWKLrfEJ0NYmf4FjxiHtchZ/g5tZgkLw4DeCJuYpnF7Ncei34Rm1BbFDmdnqpcudFg8z60obcXlDeU52pUKyQ+Mp5pk6guQn5QjJLfpYqckbMoTTOoJrVJ2XbUH0vd11eX1AVLSiHpLO3sniBVPQWCvorbQ0jRBXq5TM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711990229; c=relaxed/simple; bh=mrsW3F1MKV+wVk25ur7Mblw9ITA286xRv50RDyt6o+I=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=jTsNoExuobrlRLrCv38rItizrziIUV1PpBxuuCXfSP9Chnxd/giKBlX+6tQXfw12hYOF2s82zAjV3KN0/S3wnITpi0s4T4S/MX9UdsiK/N2ZfvqnO8Znh3ABpye036Bs+YQ1OD5+TSg0Xp/JA9tF89aZjmosV9kbwg5A7qFSJQU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 431FtBJL019121; Mon, 1 Apr 2024 16:50:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=2WcFRojX5a3VndpBAhvZc6CbRHwFyxCfimk8YeaZu2s=; b=W/Anvw/BBqnHJy1FAyV72/2cK6/sNkMkRnGsodOH+kv8fFb2t+JReiwSMTUzy6+3AlEP IucJPg3ZRB2jIj891M9NDCCg7q0G3BgKm93y66L3FAQ9118doMzjTM4MuEc4jPvTqeHj j9MIFBi24znYNZqBxsmLmlf7UXxL1l62F9jk6Jvyemdz+eGU3NQevezSnEMsQ8gMxbXL 5WZGMUpeHy60lAioKfiF8oug7SGdcoWf/4V/LBriHqVciqT98cjWwkGGuM/auIJ3ylM+ LqT54CKEzrD+rh4TenOaecHfnmJyM62Oo/uYhzbwTtQuYen8+Yi8UcTcBV4oztUVCWzp mQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3x7yyv8486-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Apr 2024 16:50:25 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 431GoPmS008246; Mon, 1 Apr 2024 16:50:25 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3x7yyv8484-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Apr 2024 16:50:24 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 431GTrlx029616; Mon, 1 Apr 2024 16:50:24 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3x6ys2rtfq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Apr 2024 16:50:24 +0000 Received: from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com [10.39.53.229]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 431GoLnn24707768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 1 Apr 2024 16:50:24 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9F54758061; Mon, 1 Apr 2024 16:50:21 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 43C8E5806E; Mon, 1 Apr 2024 16:50:21 +0000 (GMT) Received: from [9.61.153.201] (unknown [9.61.153.201]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 1 Apr 2024 16:50:21 +0000 (GMT) Message-ID: <22d79923-aa3a-4d75-be5a-9797e6d6bcd8@linux.ibm.com> Date: Mon, 1 Apr 2024 11:50:20 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/12] powerpc: Add missing arch flags on rounding ifunc variants To: "H.J. Lu" , Adhemerval Zanella Cc: libc-alpha@sourceware.org References: <20231228172026.2013007-1-adhemerval.zanella@linaro.org> <20231228172026.2013007-3-adhemerval.zanella@linaro.org> Content-Language: en-US From: Peter Bergner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ciymCIgODS380p_WPgLV0M9U_FfVw_aK X-Proofpoint-GUID: 4yHFcpAkSUYbKI_7LYQ2DD1a4A4qNqbc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-01_11,2024-04-01_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 mlxscore=0 impostorscore=0 spamscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2403210000 definitions=main-2404010117 X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/1/24 8:59 AM, H.J. Lu wrote: > On Thu, Dec 28, 2023 at 9:21 AM Adhemerval Zanella > wrote: >> >> The ifunc variants now uses the powerpc implementation which in turn >> uses the compiler builtin. Without the proper -mcpu switch the builtin >> does not generate the expected optimization. >> >> Checked on powerpc-linux-gnu. >> --- >> sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile >> index 64317506c6..2f5c0eded6 100644 >> --- a/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile >> +++ b/sysdeps/powerpc/powerpc32/power4/fpu/multiarch/Makefile >> @@ -34,6 +34,12 @@ CFLAGS-s_modff-power5+.c = -mcpu=power5+ >> CFLAGS-s_logbl-power7.c = -mcpu=power7 >> CFLAGS-s_logb-power7.c = -mcpu=power7 >> CFLAGS-s_logbf-power7.c = -mcpu=power7 >> +CFLAGS-s_round-power5+.c += -mcpu=power5+ >> +CFLAGS-s_roundf-power5+.c += -mcpu=power5+ >> +CFLAGS-s_floor-power5+.c += -mcpu=power5+ >> +CFLAGS-s_floorf-power5+.c += -mcpu=power5+ >> +CFLAGS-s_trunc-power5+.c += -mcpu=power5+ >> +CFLAGS-s_truncf-power5+.c += -mcpu=power5+ >> >> # These files quiet sNaNs in a way that is optimized away without >> # -fsignaling-nans. >> -- >> 2.34.1 >> > > LGTM. > > Reviewed-by: H.J. Lu This predated me taking over the Power port, but... LGTM too. Reviewed-by: Peter Bergner Peter