From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by sourceware.org (Postfix) with ESMTPS id 353D53858D20 for ; Fri, 3 Feb 2023 16:20:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 353D53858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-16a073ace03so1694077fac.7 for ; Fri, 03 Feb 2023 08:20:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VtCWZunDEwgSY71naXLkxy5g7Pga0WXlchfsjteMfFc=; b=niep9+IdAonG8NgZcjRB+NBqWHs+hoKhNQNkmlzSQ40fJQNXuSCSwqBYFtMTprO1Zg xCb0JHDMu2D2mNpy+tWJKcf03czs8+J51nqMzJSncMIjSYMa425eqaFxABnsCByRPBJz mwppHjTilaXY8oXsTcrc4guZkQi2iOnwmHDfWVyM3nyC3Nk22LvXqc2sdMwBtZHYbgUh cfPa3rFLxYFPNvznvZIBFlcQjYW9bEwPvV2bFzYCXHBCQDLg7z+oDATMWpXU+TpsUHsQ F9X0IuRxEA+Rdn8nf/LDQCxewjpaU1oJtf6beCeI8OuX154DiPcbQnSk+m+NeUamgf/d /0Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VtCWZunDEwgSY71naXLkxy5g7Pga0WXlchfsjteMfFc=; b=XRxlP0jcgag3Lhg5DGy36zMm1AAc8q3Qux5pSezUcPYxwTbX5MYCLr1oW0MDQxIdjc XZW4nkbTb00gBQUTe2ANOCY5AxdzcJ71uyLv24yVqvr4rD6jVpeLjDLTWaIMce8bPa4e taBf4nwFG9Reaa0MEi23QZ6hfyllsgDGWK6Eo6oc7Y00Ii9BtFPA8iEn1jufCQExORXV EevPYf0EwvhmoVmYDpru2Cl6cngBWyEimTNG+NHYGRQB00cZ9qtAlWg4Yeyaxfe69Odl dkyZPt8HMaWDdnDow5e5wpb1wxu9MwgdjMJJJmZr4EfWfPKNjfr7GzL59GFc+zvgG6IC heZw== X-Gm-Message-State: AO0yUKXMnpsxcysEO7IO3spNwU6nDdG7GBuGq8b9OxwIQsRXn04s1716 lsOubN9bTw5UYeCh7pXpQB8n+U/UdpuNNn2G16g= X-Google-Smtp-Source: AK7set/SF1CvMesHgW6Gbc1CKyhWZnMDNzeZMwtMV0Vryco0cHUbqjhP3fklggknCOdyO8pah9oLMg== X-Received: by 2002:a05:6870:2401:b0:169:6803:28de with SMTP id n1-20020a056870240100b00169680328demr4802475oap.41.1675441252479; Fri, 03 Feb 2023 08:20:52 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c2:1887:71e4:6a44:32a:be62? ([2804:1b3:a7c2:1887:71e4:6a44:32a:be62]) by smtp.gmail.com with ESMTPSA id ee15-20020a056870c80f00b0014fb4bdc746sm1007488oab.8.2023.02.03.08.20.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 08:20:51 -0800 (PST) Message-ID: <22e884be-a0ad-c201-c31f-92b3e1fa13e4@linaro.org> Date: Fri, 3 Feb 2023 13:20:49 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH] Remove pthread-pi-defines.sym Content-Language: en-US To: Andreas Schwab , libc-alpha@sourceware.org References: <87r0v63h0x.fsf@igel.home> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87r0v63h0x.fsf@igel.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03/02/23 12:28, Andreas Schwab wrote: > It became unused with the removal of the assembler implementation of the > pthread functions. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > nptl/Makefile | 3 +-- > nptl/pthread-pi-defines.sym | 9 --------- > 2 files changed, 1 insertion(+), 11 deletions(-) > delete mode 100644 nptl/pthread-pi-defines.sym > > diff --git a/nptl/Makefile b/nptl/Makefile > index 6d1ae452c8..8cec6faee3 100644 > --- a/nptl/Makefile > +++ b/nptl/Makefile > @@ -339,8 +339,7 @@ xtests += tst-eintr1 > > test-srcs = tst-oddstacklimit > > -gen-as-const-headers = unwindbuf.sym \ > - pthread-pi-defines.sym > +gen-as-const-headers = unwindbuf.sym > > gen-py-const-headers := nptl_lock_constants.pysym > pretty-printers := nptl-printers.py > diff --git a/nptl/pthread-pi-defines.sym b/nptl/pthread-pi-defines.sym > deleted file mode 100644 > index 0ac51dba98..0000000000 > --- a/nptl/pthread-pi-defines.sym > +++ /dev/null > @@ -1,9 +0,0 @@ > -#include > - > --- These PI macros are used by assembly code. > - > -MUTEX_KIND offsetof (pthread_mutex_t, __data.__kind) > -ROBUST_BIT PTHREAD_MUTEX_ROBUST_NORMAL_NP > -PI_BIT PTHREAD_MUTEX_PRIO_INHERIT_NP > -PS_BIT PTHREAD_MUTEX_PSHARED_BIT > -TID_MASK FUTEX_TID_MASK