public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, Andreas Schwab <schwab@suse.de>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Make copy of <bits/std_abs.h> from GCC 7 [BZ #21573]
Date: Tue, 13 Jun 2017 20:13:00 -0000	[thread overview]
Message-ID: <230d2cab-8085-bb7e-68cc-38de409397a7@redhat.com> (raw)
In-Reply-To: <CAMe9rOoXF7-40n-n7z8JdNeyc6CBPYk1AeK73KT_pmBvDdxAcQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

On 06/13/2017 01:54 PM, H.J. Lu wrote:
> -    echo "#include <$1>" | $CXX -M -MP -x c++ - | sed -n "/$1:/{s/:\$//;p}"
> +    echo "#include <$1>" | $CXX -M -MP -x c++ - | sed -n "\,$1:,{s/:\$//;p}"
>    }
>    CXX_CSTDLIB_HEADER="$(find_cxx_header cstdlib)"
> +  # Also make a copy of <bits/std_abs.h> from GCC 7 to prevent it from
> +  # including /usr/include/stdlib.h.
> +  CXX_CSTDLIB_HEADER="$CXX_CSTDLIB_HEADER $(find_cxx_header bits/std_abs.h)"

I think the attached patch is needed to suppress the error message if
the header does not exist.  (Regenerated configure file not shown in the
patch.)

Thanks,
Florian

[-- Attachment #2: find_cxx_header.patch --]
[-- Type: text/x-patch, Size: 693 bytes --]

configure: Suppress expected compiler error message

2017-06-13  Florian Weimer  <fweimer@redhat.com>

	* configure.ac (find_cxx_header): Suppress compiler error message.

diff --git a/configure.ac b/configure.ac
index d74bd44..3f486d6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1187,7 +1187,8 @@ AC_SUBST(CXX_SYSINCLUDES)
 # copy of those headers in Makerules.
 if test -n "$CXX"; then
   find_cxx_header () {
-    echo "#include <$1>" | $CXX -M -MP -x c++ - | sed -n "\,$1:,{s/:\$//;p}"
+    echo "#include <$1>" | $CXX -M -MP -x c++ - 2>/dev/null \
+	 | sed -n "\,$1:,{s/:\$//;p}"
   }
   CXX_CSTDLIB_HEADER="$(find_cxx_header cstdlib)"
   CXX_CMATH_HEADER="$(find_cxx_header cmath)"

  parent reply	other threads:[~2017-06-13 20:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13 11:38 H.J. Lu
2017-06-13 11:40 ` Andreas Schwab
2017-06-13 11:44   ` H.J. Lu
2017-06-13 11:46     ` Andreas Schwab
2017-06-13 11:54       ` H.J. Lu
2017-06-13 15:32         ` H.J. Lu
2017-06-13 18:13           ` H.J. Lu
2017-06-13 20:13         ` Florian Weimer [this message]
2017-06-13 20:21           ` H.J. Lu
2017-09-07 17:29             ` H.J. Lu
2017-09-11 15:53               ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=230d2cab-8085-bb7e-68cc-38de409397a7@redhat.com \
    --to=fweimer@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).