From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id A3A69385801B for ; Thu, 14 Jul 2022 11:33:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A3A69385801B Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 4707566952; Thu, 14 Jul 2022 07:33:29 -0400 (EDT) Message-ID: <23a3fdf115790373979ad819b0d6e8cd3f0d4b69.camel@xry111.site> Subject: Re: [PATCH v6 00/13] GLIBC LoongArch PATCHES From: Xi Ruoyao To: Adhemerval Zanella Netto , libc-alpha@sourceware.org, caiyinyu , Carlos O'Donell Cc: joseph_myers@mentor.com Date: Thu, 14 Jul 2022 19:33:27 +0800 In-Reply-To: References: <20220708065255.2316410-1-caiyinyu@loongson.cn> <7cbacfadd642bafc42076eb5b7455a0acb7c720f.camel@xry111.site> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.3 MIME-Version: 1.0 X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FROM_SUSPICIOUS_NTLD, LIKELY_SPAM_FROM, PDS_OTHER_BAD_TLD, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2022 11:33:35 -0000 On Wed, 2022-07-13 at 16:55 -0300, Adhemerval Zanella Netto wrote: > I finished my review for the port and it looks ok in general, however the= re > some pieces that would require a v7: >=20 > =C2=A0 1. Add R_LARCH_NONE handling on bootstrap, binutils 2.38 does gene= rated it=20 > =C2=A0=C2=A0=C2=A0=C2=A0 and from previous discussion it should be consid= ered a missed=20 > =C2=A0=C2=A0=C2=A0=C2=A0 optimizations instead of a linker error. >=20 > =C2=A0 2. Remove the __loongarch_soft_float parts, since there is no supp= ort for > =C2=A0=C2=A0=C2=A0=C2=A0 soft floating-point. >=20 > =C2=A0 3. Remove sysdeps/unix/sysv/linux/loongarch/ldconfig.h, this file = is not > =C2=A0=C2=A0=C2=A0=C2=A0 required. >=20 > =C2=A0 4. Some minor style issues. >=20 > =C2=A0 5. Either remove HAVE_GETTIMEOFDAY_VSYSCALL or add a gettimeofday = ifunc > =C2=A0=C2=A0=C2=A0=C2=A0 optimization. >=20 > The only part really prevent port inclusion is 1.=C2=A0 I am also assumin= g ifunc=20 > is support (at least you have added support on the Linux ABI part) with > binutils 2.38.=C2=A0 If not, you will need to remove support until you fi= x it on > binutils. >=20 > And also, you need to check and report the test results using the expecte= d > defined release branches, using out-of-tree branches are not acceptable f= or > inclusion. The series tested with Linux-5.19-rc4, Binutils-2.38, and GCC-12.1.=20 Some kernel patches used but they are only boot protocols and hardware drivers, not related to userspace ABI so Glibc should be unaffected.=20 Some Binutils and GCC patches used but they are all already committed to upstream. To work around binutils issues, I added R_LARCH_NONE back to RTLD_BOOTSTRAP, and disabled IFUNC (by adding libc_cv_ld_gnu_indirect_function=3Dno into preconfigure). Result: XPASS: conform/UNIX98/ndbm.h/linknamespace XPASS: conform/XOPEN2K/ndbm.h/linknamespace XPASS: conform/XOPEN2K8/ndbm.h/linknamespace XPASS: conform/XPG42/ndbm.h/linknamespace UNSUPPORTED: crypt/cert UNSUPPORTED: elf/tst-env-setuid UNSUPPORTED: elf/tst-env-setuid-tunables XPASS: elf/tst-protected1a XPASS: elf/tst-protected1b UNSUPPORTED: elf/tst-valgrind-smoke UNSUPPORTED: misc/tst-adjtimex UNSUPPORTED: misc/tst-clock_adjtime UNSUPPORTED: misc/tst-ntp_adjtime UNSUPPORTED: misc/tst-pkey UNSUPPORTED: misc/tst-rseq UNSUPPORTED: misc/tst-rseq-disable UNSUPPORTED: nptl/test-cond-printers UNSUPPORTED: nptl/test-condattr-printers UNSUPPORTED: nptl/test-mutex-printers UNSUPPORTED: nptl/test-mutexattr-printers UNSUPPORTED: nptl/test-rwlock-printers UNSUPPORTED: nptl/test-rwlockattr-printers UNSUPPORTED: nptl/tst-pthread-gdb-attach UNSUPPORTED: nptl/tst-pthread-gdb-attach-static UNSUPPORTED: nptl/tst-rseq-nptl UNSUPPORTED: stdlib/tst-secure-getenv UNSUPPORTED: time/tst-clock_settime UNSUPPORTED: time/tst-settimeofday Summary of test results: 4536 PASS 22 UNSUPPORTED 12 XFAIL 6 XPASS --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University