From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40436 invoked by alias); 6 Jul 2018 12:46:34 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 23051 invoked by uid 89); 6 Jul 2018 12:46:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:5ec2 X-HELO: mx1.redhat.com Subject: Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions To: Adhemerval Zanella , libc-alpha@sourceware.org References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-2-git-send-email-adhemerval.zanella@linaro.org> From: Florian Weimer Message-ID: <23dd1909-5ec2-34b7-9672-827251a4be65@redhat.com> Date: Fri, 06 Jul 2018 12:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1517591084-11347-2-git-send-email-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00183.txt.bz2 On 02/02/2018 06:04 PM, Adhemerval Zanella wrote: > @@ -139,7 +139,9 @@ libpthread-routines = nptl-init vars events version pt-interp \ > pthread_mutex_getprioceiling \ > pthread_mutex_setprioceiling \ > pthread_setname pthread_getname \ > - pthread_setattr_default_np pthread_getattr_default_np > + pthread_setattr_default_np pthread_getattr_default_np \ > + thrd_create thrd_current thrd_detach thrd_equal \ thrd_current should live in libc, not in libpthread. Same for thrd_equal, I suppose. You should just duplicate the comparison, seeing that we haven't done that particular cleanup for pthread_equal yet. Not sure about thrd_sleep and thrd_yield, but I lean towards libc there as well. Thanks, Florian