From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1B544385770D for ; Mon, 29 Jan 2024 21:07:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B544385770D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1B544385770D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706562435; cv=none; b=b03M+fnHaTTRLtiXzSNbCnn5FacHXXVQiOYhMCD6ygW6xSKp6X0+jhYzvXana1+6wyeJuWqnpQMdSAzVtskmpt2yjAB5R+mGnLjAJ82/LjbT7RQgXvGKDlV4DwohucaRp3Stadseo1Q/6OVr1Jph3qEpOTc8bohCsBomhacdBBs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706562435; c=relaxed/simple; bh=K8FFGiy7sP/sKmSiQpo8U1hzTlesUG2aSA3PrAMR3Nk=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=T7dRRS9VRBW1S/WV8LA7YKP6uZ+lpwv9JtxCi8KCCvNPIFqi8EEBxb85lhwYwqb7BjZ+bnPZ088siwkblQyEZSxM/HNeYP6mfF0z33WoJodn/OL5AAY/jtAxVv91y6W/E7JJRlHNnij3+clBUt/h0FPSx9/1eImlaz/1zXYI+5o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706562433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ThQDJE3O4liVCpf2wlnbapUZcbP9x4CuBpeci8VUR6o=; b=VwlqNjNCrcg4IznCzUYCxaIwEmC0aEUhSwOZJsSLQfWGhDlDH6ioKJ7TqEKM8bjbn/ESP5 KNaehTCSYazZsCWoHpUosV5uFZrcbfHKt7yjt1ZBowI5tl9UWulkc/2VoRjwTP9Sp/eb2H DWqmApUiMM1jf4Rt+HMPNLG4SWP9DcQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-UvqJuCqfM22NGfaVP0YL0A-1; Mon, 29 Jan 2024 16:07:12 -0500 X-MC-Unique: UvqJuCqfM22NGfaVP0YL0A-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40efb0b5079so6228165e9.1 for ; Mon, 29 Jan 2024 13:07:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706562430; x=1707167230; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ThQDJE3O4liVCpf2wlnbapUZcbP9x4CuBpeci8VUR6o=; b=c0nnVVUzCHi/EuySMLL19i9ZU/aaGc639b8Q/xI6r3sow3TFf1kiS1nReagM9nOa6a WSrIUpe8aAU85RqyeePq2EkAvQ8nFs6Bi2qoq/bivyC60JHZXq1m1mgWFZSKtb+p1Qv1 AiM/PXeJ2OojKxxrXl3RA15i/ElmiLsBWrEMaJqxTFmD55HbeEwZi8Qz0hgwMSWYwmw2 0u+L0yPUxOLsFnc0l6vW0mh3HfWn6wqFkYLwsVpOTDYzx/2F2tFUXgRJL3dUKbEku2of edVKF/EWGVmVZzJRyzBN5CHcTJIclfHHXV9+deEeAlHRgSfDT0iHx4uJszjSXBGo0Exh PTJA== X-Gm-Message-State: AOJu0YxnWkM4K0Rq32Z0here/l0MDgEwWn4nG1WvWP1VE01AbKBbIQ+2 6q/QTcbrm7SuTWO6pm4d5mLSdy49vXxebM5K6cDQLnR8zjJxozdl6UtSqg7rUFhkzXNESTMYDVZ gF/waQHZwFBrHkebz6ca1m3vlSycXjkptkV3/VUAyk627yc7/upOoH7OqaaihJ26/6A== X-Received: by 2002:a05:600c:358d:b0:40e:b981:db9a with SMTP id p13-20020a05600c358d00b0040eb981db9amr7093259wmq.7.1706562430610; Mon, 29 Jan 2024 13:07:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IFHA+xzYwK2plkPCa1xGzB5+iaH/nXkI1bIHGaelEFEK6rQH8uwBeHcpYXP1zXGqYtb3YPRgg== X-Received: by 2002:a05:600c:358d:b0:40e:b981:db9a with SMTP id p13-20020a05600c358d00b0040eb981db9amr7093251wmq.7.1706562430315; Mon, 29 Jan 2024 13:07:10 -0800 (PST) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id v9-20020a05600c470900b0040d87100733sm11118452wmo.39.2024.01.29.13.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 13:07:10 -0800 (PST) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rUYqS-000Yh0-VT; Mon, 29 Jan 2024 21:07:08 +0000 Date: Mon, 29 Jan 2024 21:07:08 +0000 (UTC) From: Joseph Myers To: Jakub Jelinek cc: libc-alpha@sourceware.org Subject: Re: [PATCH] v3: Use gcc __builtin_stdc_* builtins in stdbit.h if possible In-Reply-To: Message-ID: <23ea145a-5250-3770-9789-c48ea4b417eb@redhat.com> References: <7aa693ad-514e-7b7a-8d3-2c59af649ca@redhat.com> <1b65b9a1-2ae6-52f-c352-8ae2ba52ee24@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 26 Jan 2024, Jakub Jelinek wrote: > So like this then (only stdbit.texi changed since last patch)? Yes. > +ui > +leading_zeros (uc a, us b, ui c, ul d, ull e) > +{ > + return (stdc_leading_zeros (a) > + + stdc_leading_zeros (b) > + + stdc_leading_zeros (c) > + + stdc_leading_zeros (d) > + + stdc_leading_zeros (e)); > +} I don't see what these functions are for. They don't seem to be used at all, and the existing tests thoroughly cover the type-generic macros as applied to non-_BitInt types, so additional tests that only verify that such calls can be compiled for non-_BitInt types don't seem to add much value. -- Joseph S. Myers josmyers@redhat.com