From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dog.birch.relay.mailchannels.net (dog.birch.relay.mailchannels.net [23.83.209.48]) by sourceware.org (Postfix) with ESMTPS id E230D3858C52 for ; Wed, 4 Oct 2023 14:53:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E230D3858C52 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=sourceware.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 530EF2C22F5; Wed, 4 Oct 2023 14:53:12 +0000 (UTC) Received: from pdx1-sub0-mail-a234.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D4E272C18D0; Wed, 4 Oct 2023 14:53:11 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1696431191; a=rsa-sha256; cv=none; b=3eIBzHIjKmtD5KqkOXXaEwxoQ/GNnWNpH2DomlV4998DzxETtpoFB+ICh3LWmWz6MB4Ypv 75LrdKwQxwoKcT/1N9iYZL1uhZAtavQ0JT+QGHaljguihis+VR4N36diO9+otAfFRcRJ3s ZtyO3JKYZyNuak8dpHRyyRwSIKh9Q8U4585KpywIO2htzBIGpwinW/bXwTtgzyzsfyc9x+ GkS10ZCcrvGYItA6k9hSSRbfG8qkegag3ZzaKhE7CQCb1bj4Nfd69H8EaNNVKGSY0TL8yb WVNjGj1QV2RO4B4Z/KAjtYIrF7DFchQemOgC9WUqS1Nehc5IYXMbfBTA9LpyoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1696431191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TixhlsxYdK95XPp3lYzdBAU5p/UOF/2RQKjJDrEXwiA=; b=3Lglo3TC/BqwfDV29spPX1aZCmFB549iFisZLvLJ5GZZLyMIMAWkyl98zsLTPltqaLEOMH LFj2J3UziVJNPkwODcJlfFsAPeYCaCuVSgW8v1ZEQhGpZIEJDsgD20d5cObh9PxmQrj3hP kSw76ZEZWgxVb4py1puIrFeFgvGsL0X8tXIEJz4+U7a6NLwCLzDqMJ1C/LhSHXq08AIt1w lHvI0f46PBrlStjZb2W5dwZ/Uz5gIMgMsVzpbaQlGE5buL5STt0lQvZK/J23WsacxcVO7n BIYD6xwY3NSL2iSXfkW9WR42S0XtZrCCMgYQNhfumr3JO4c8Tl2KUNbaF9V6Hg== ARC-Authentication-Results: i=1; rspamd-7c449d4847-dd9d6; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Harmony-Tart: 091b94c2166609e5_1696431192140_3004691642 X-MC-Loop-Signature: 1696431192140:1453330090 X-MC-Ingress-Time: 1696431192140 Received: from pdx1-sub0-mail-a234.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.101.66.70 (trex/6.9.1); Wed, 04 Oct 2023 14:53:12 +0000 Received: from [192.168.2.12] (bras-vprn-toroon4834w-lp130-02-142-113-138-41.dsl.bell.ca [142.113.138.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a234.dreamhost.com (Postfix) with ESMTPSA id 4S0yNl1ykgz22; Wed, 4 Oct 2023 07:53:11 -0700 (PDT) Message-ID: <240d1f1a-685a-2281-531f-00fd4f2cf1a6@sourceware.org> Date: Wed, 4 Oct 2023 10:53:10 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/2] aarch64: Make glibc.mem.tagging SXID_ERASE Content-Language: en-US To: Szabolcs Nagy , libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.org, fweimer@redhat.com, carlos@redhat.com References: From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1167.3 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-04 10:51, Szabolcs Nagy wrote: > personally i think setuid binaries should not touch the > env, just ignore it, so everything SXID_IGNORE. > > it's not just the string twiddling but tunables_strdup > is a problem too (it can fail, needs early alloc,..). > ideally tunables_init would be a nop with AT_SECURE and > otherwise parsed the env var without malloc and touching > the env[] array passed by the kernel. > Sure, that could be a less contentious change. I'll send v2 with it. Thanks, Sid