From: Paul E Murphy <murphyp@linux.ibm.com>
To: "Gabriel F. T. Gomes" <gabriel@inconstante.net.br>,
libc-alpha@sourceware.org
Subject: Re: [PATCH v2 10/30] ldbl-128ibm-compat: Add err.h functions
Date: Fri, 08 Nov 2019 20:22:00 -0000 [thread overview]
Message-ID: <24bd169d-65d8-98bf-baec-f67d97f46548@linux.ibm.com> (raw)
In-Reply-To: <20191025153410.15405-11-gabriel@inconstante.net.br>
On 10/25/19 10:33 AM, Gabriel F. T. Gomes wrote:
> From: "Gabriel F. T. Gomes" <gabrielftg@linux.ibm.com>
>
> No changes since v1.
>
> -- 8< --
> Use the recently added, internal functions, __vwarnx_internal and
> __vwarn_internal, to provide err.h functions that can take long double
> arguments with IEEE binary128 format on platforms where long double can
> also take double format or some non-IEEE format (currently, this means
> powerpc64le).
>
> Tested for powerpc64le.
> ---
> misc/errP.h | 28 ++++++
> sysdeps/ieee754/ldbl-128ibm-compat/Makefile | 4 +
> sysdeps/ieee754/ldbl-128ibm-compat/Versions | 9 ++
> .../ieee754/ldbl-128ibm-compat/ieee128-err.c | 93 +++++++++++++++++++
> 4 files changed, 134 insertions(+)
> create mode 100644 misc/errP.h
> create mode 100644 sysdeps/ieee754/ldbl-128ibm-compat/ieee128-err.c
>
> diff --git a/misc/errP.h b/misc/errP.h
These are also declared in includes/err.h. Is there a subtle configury
that prevents their usage?
> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Versions b/sysdeps/ieee754/ldbl-128ibm-compat/Versions
OK.
> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/ieee128-err.c b/sysdeps/ieee754/ldbl-128ibm-compat/ieee128-err.c
> new file mode 100644
> index 0000000000..8a34508e5e
> --- /dev/null
> +++ b/sysdeps/ieee754/ldbl-128ibm-compat/ieee128-err.c
> @@ -0,0 +1,93 @@
> +/* Wrappers for err.h functions. IEEE128 version.
> + Copyright (C) 2018 Free Software Foundation, Inc.
Trivial nit, I think the year needs updated in a few places, and likely
for the previous patches too.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +#include <stdarg.h>
> +#include <misc/errP.h>
> +#include <libio/libioP.h>
> +
> +#define VA(call) \
> +{ \
> + va_list ap; \
> + va_start (ap, format); \
> + IEEE128_CALL (call); \
> + va_end (ap); \
> +}
> +
> +#define IEEE128_ALIAS(name) \
> + strong_alias (___ieee128_##name, __##name##ieee128)
> +
> +#define IEEE128_DECL(name) ___ieee128_##name
> +#define IEEE128_CALL(name) ___ieee128_##name
> +
> +void
> +IEEE128_DECL (vwarn) (const char *format, __gnuc_va_list ap)
> +{
> + __vwarn_internal (format, ap, PRINTF_LDBL_USES_FLOAT128);
> +}
> +IEEE128_ALIAS (vwarn)
> +
> +void
> +IEEE128_DECL (vwarnx) (const char *format, __gnuc_va_list ap)
> +{
> + __vwarnx_internal (format, ap, PRINTF_LDBL_USES_FLOAT128);
> +}
> +IEEE128_ALIAS (vwarnx)
> +
> +void
> +IEEE128_DECL (warn) (const char *format, ...)
> +{
> + VA (vwarn (format, ap))
> +}
> +IEEE128_ALIAS (warn)
> +
> +void
> +IEEE128_DECL (warnx) (const char *format, ...)
> +{
> + VA (vwarnx (format, ap))
> +}
> +IEEE128_ALIAS (warnx)
OK
> +
> +void
> +IEEE128_DECL (verr) (int status, const char *format, __gnuc_va_list ap)
> +{
> + IEEE128_CALL (vwarn) (format, ap);
> + exit (status);
> +}
> +IEEE128_ALIAS (verr)
> +
> +void
> +IEEE128_DECL (verrx) (int status, const char *format, __gnuc_va_list ap)
> +{
> + IEEE128_CALL (vwarnx) (format, ap);
> + exit (status);
> +}
> +IEEE128_ALIAS (verrx)
I notice the nldbl wrappers call __vwarn{,x}_internal directly with the
respective mode option. I think it is OK as is.
> +
> +void
> +IEEE128_DECL (err) (int status, const char *format, ...)
> +{
> + VA (verr (status, format, ap))
> +}
> +IEEE128_ALIAS (err)
> +
> +void
> +IEEE128_DECL (errx) (int status, const char *format, ...)
> +{
> + VA (verrx (status, format, ap))
> +}
> +IEEE128_ALIAS (errx)
>
OK.
next prev parent reply other threads:[~2019-11-08 20:22 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 15:34 [PATCH v2 00/30] Add IEEE long double <-> string functions for powerpc64le Gabriel F. T. Gomes
2019-10-25 15:34 ` [PATCH v2 02/30] ldbl-128ibm-compat: Add wide character printing functions Gabriel F. T. Gomes
2019-11-04 15:08 ` Paul E Murphy
2019-11-04 18:10 ` Gabriel F. T. Gomes
2019-11-04 20:11 ` Paul E Murphy
2019-10-25 15:34 ` [PATCH v2 01/30] ldbl-128ibm-compat: Add regular " Gabriel F. T. Gomes
2019-10-29 15:42 ` Paul E Murphy
2019-10-30 16:10 ` Gabriel F. T. Gomes
2019-10-25 15:34 ` [PATCH v2 03/30] ldbl-128ibm-compat: Add regular character, fortified " Gabriel F. T. Gomes
2019-11-04 15:43 ` Paul E Murphy
2019-11-05 19:37 ` Gabriel F. T. Gomes
2019-11-08 16:44 ` Paul E Murphy
2019-10-25 15:35 ` [PATCH v2 10/30] ldbl-128ibm-compat: Add err.h functions Gabriel F. T. Gomes
2019-11-08 20:22 ` Paul E Murphy [this message]
2019-11-13 14:24 ` Gabriel F. T. Gomes
2019-11-27 19:11 ` Gabriel F. T. Gomes
2019-10-25 15:35 ` [PATCH v2 07/30] ldbl-128ibm-compat: Add regular character scanning functions Gabriel F. T. Gomes
2019-11-14 21:36 ` Paul E Murphy
2019-10-25 15:35 ` [PATCH v2 14/30] ldbl-128ibm-compat: Add obstack printing functions Gabriel F. T. Gomes
2019-11-08 23:42 ` Paul E Murphy
2019-11-27 19:11 ` Gabriel F. T. Gomes
2019-10-25 15:35 ` [PATCH v2 13/30] ldbl-128ibm-compat: Add ISO C99 versions of scanf functions Gabriel F. T. Gomes
2019-11-08 23:26 ` Paul E Murphy
2019-11-21 13:44 ` Gabriel F. T. Gomes
2019-11-22 22:49 ` Gabriel F. T. Gomes
2019-11-27 19:13 ` Gabriel F. T. Gomes
2019-10-25 15:35 ` [PATCH v2 08/30] ldbl-128ibm-compat: Add wide character scanning functions Gabriel F. T. Gomes
2019-11-04 17:47 ` Paul E Murphy
2019-11-11 14:33 ` Gabriel F. T. Gomes
2019-11-22 22:34 ` Gabriel F. T. Gomes
2019-10-25 15:35 ` [PATCH v2 09/30] ldbl-128ibm-compat: Add argp_error and argp_failure Gabriel F. T. Gomes
2019-11-08 19:58 ` Paul E Murphy
2019-10-25 15:35 ` [PATCH v2 05/30] ldbl-128ibm-compat: Test double values Gabriel F. T. Gomes
2019-11-04 16:16 ` Paul E Murphy
2019-10-25 15:35 ` [PATCH v2 15/30] ldbl-128ibm-compat: Add syslog functions Gabriel F. T. Gomes
2019-11-14 17:47 ` Paul E Murphy
2019-11-14 18:25 ` Florian Weimer
2019-11-27 19:12 ` Gabriel F. T. Gomes
2019-10-25 15:35 ` [PATCH v2 06/30] ldbl-128ibm-compat: Test positional arguments Gabriel F. T. Gomes
2019-11-04 16:55 ` Paul E Murphy
2019-11-06 17:28 ` Gabriel F. T. Gomes
2019-10-25 15:35 ` [PATCH v2 11/30] ldbl-128ibm-compat: Add error.h functions Gabriel F. T. Gomes
2019-11-08 22:21 ` Paul E Murphy
2019-10-25 15:36 ` [PATCH v2 20/30] Refactor *cvt functions implementation (2/5) Gabriel F. T. Gomes
2019-10-25 15:36 ` [PATCH v2 23/30] Refactor *cvt functions implementation (5/5) Gabriel F. T. Gomes
2019-11-14 23:12 ` Paul E Murphy
2019-11-27 17:42 ` Gabriel F. T. Gomes
2019-10-25 15:36 ` [PATCH v2 22/30] Refactor *cvt functions implementation (4/5) Gabriel F. T. Gomes
2019-10-25 15:36 ` [PATCH v2 12/30] ldbl-128ibm-compat: Reuse tests for err.h and error.h functions Gabriel F. T. Gomes
2019-11-08 22:25 ` Paul E Murphy
2019-10-25 15:36 ` [PATCH v2 19/30] Refactor *cvt functions implementation (1/5) Gabriel F. T. Gomes
2019-10-25 15:36 ` [PATCH v2 16/30] ldbl-128ibm-compat: Add strfmon_l with IEEE long double format Gabriel F. T. Gomes
2019-11-14 18:03 ` Paul E Murphy
2019-11-27 17:43 ` Gabriel F. T. Gomes
2019-12-03 16:57 ` Gabriel F. T. Gomes
2019-10-25 15:36 ` [PATCH v2 21/30] Refactor *cvt functions implementation (3/5) Gabriel F. T. Gomes
2019-10-25 15:36 ` [PATCH v2 04/30] ldbl-128ibm-compat: Add wide character, fortified printing functions Gabriel F. T. Gomes
2019-11-04 16:10 ` Paul E Murphy
2019-10-25 15:36 ` [PATCH v2 18/30] ldbl-128ibm-compat: Add tests for strfroml, strtold, and wcstold Gabriel F. T. Gomes
2019-11-14 18:26 ` Paul E Murphy
2019-11-27 17:47 ` Gabriel F. T. Gomes
2019-12-03 16:58 ` Gabriel F. T. Gomes
2019-10-25 15:37 ` [PATCH v2 25/30] Do not redirect calls to __GI_* symbols, when redirecting to *ieee128 Gabriel F. T. Gomes
2019-10-25 15:37 ` [PATCH v2 30/30] RFC: powerpc64le: Enable support for IEEE long double Gabriel F. T. Gomes
2019-10-25 15:37 ` [PATCH v2 28/30] ldbl-128ibm-compat: Do not mix -mabi=*longdouble and -mlong-double-128 Gabriel F. T. Gomes
2019-10-25 15:37 ` [PATCH v2 17/30] ldbl-128ibm-compat: Add tests for strfmon and strfmon_l Gabriel F. T. Gomes
2019-11-14 18:11 ` Paul E Murphy
2019-12-03 16:58 ` Gabriel F. T. Gomes
2019-10-25 15:37 ` [PATCH v2 26/30] ldbl-128ibm-compat: Compiler flags for stdio functions Gabriel F. T. Gomes
2019-10-25 15:37 ` [PATCH v2 27/30] Avoid compat symbols for totalorder in powerpc64le IEEE long double Gabriel F. T. Gomes
2019-10-25 15:37 ` [PATCH v2 24/30] ldbl-128ibm-compat: Add *cvt functions Gabriel F. T. Gomes
2019-10-25 15:37 ` [PATCH v2 29/30] powerpc64le: Require a compiler with -mno-gnu-attribute Gabriel F. T. Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24bd169d-65d8-98bf-baec-f67d97f46548@linux.ibm.com \
--to=murphyp@linux.ibm.com \
--cc=gabriel@inconstante.net.br \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).