From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>, libc-alpha@sourceware.org
Cc: fweimer@redhat.com, Eyal Itkin <eyalit@checkpoint.com>
Subject: Re: [PATCH] Harden tcache double-free check
Date: Wed, 7 Jul 2021 15:27:14 -0300 [thread overview]
Message-ID: <24d562e9-d406-97ed-77f2-978a17e8a184@linaro.org> (raw)
In-Reply-To: <96413cd5-9222-4c98-a85f-3ef077888710@sourceware.org>
On 07/07/2021 15:12, Siddhesh Poyarekar wrote:
> On 7/7/21 11:39 PM, Adhemerval Zanella via Libc-alpha wrote:
>> Yes, but it is essentially what you are doing here: query getrandom
>> with GRND_NONBLOCK a falling back to clock_gettime. And we also
>> have the random_bits from include/random-bits.h.
>>
>> I think we would better to consolidate it with only one implementation.
>
> The randomness needs are quite different, but I see your point. We could make a separate random_bits64 to cater to these two use cases. Can it be a separate patch though? I'll put it on top of this one.
I think it can be separate consolidation, what I am trying to avoid is
multiple random_bits implementation which different semantics within
glibc.
next prev parent reply other threads:[~2021-07-07 18:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 1:29 Siddhesh Poyarekar
2021-07-07 17:17 ` Florian Weimer
2021-07-07 17:34 ` [PATCH v2] " Siddhesh Poyarekar
2021-07-07 17:35 ` [PATCH] " Adhemerval Zanella
2021-07-07 17:58 ` Siddhesh Poyarekar
2021-07-07 18:09 ` Adhemerval Zanella
2021-07-07 18:12 ` Siddhesh Poyarekar
2021-07-07 18:27 ` Adhemerval Zanella [this message]
2021-07-07 18:28 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24d562e9-d406-97ed-77f2-978a17e8a184@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=eyalit@checkpoint.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).