From: "Wang, Kemi" <kemi.wang@intel.com>
To: Rical Jasan <rj@2c3t.io>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Florian Weimer <fweimer@redhat.com>,
Carlos Donell <carlos@redhat.com>,
Glibc alpha <libc-alpha@sourceware.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
"Chen, Tim C" <tim.c.chen@intel.com>,
"Kleen, Andi" <andi.kleen@intel.com>,
"Huang, Ying" <ying.huang@intel.com>,
"Lu, Aaron" <aaron.lu@intel.com>,
"Li, Aubrey" <aubrey.li@intel.com>
Subject: RE: [PATCH v2 5/5] Manual: Add manual for pthread mutex
Date: Wed, 18 Jul 2018 07:56:00 -0000 [thread overview]
Message-ID: <25017BF213203E48912DB000DE5F5E1E6B83838E@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <ba8c7061-580d-5bb8-5076-1093ebd86dfa@2c3t.io>
OK. I will take a look at it.
-----Original Message-----
From: Rical Jasan [mailto:rj@2c3t.io]
Sent: Wednesday, July 18, 2018 3:34 PM
To: Wang, Kemi <kemi.wang@intel.com>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>; Florian Weimer <fweimer@redhat.com>; Carlos Donell <carlos@redhat.com>; Glibc alpha <libc-alpha@sourceware.org>; Dave Hansen <dave.hansen@linux.intel.com>; Chen, Tim C <tim.c.chen@intel.com>; Kleen, Andi <andi.kleen@intel.com>; Huang, Ying <ying.huang@intel.com>; Lu, Aaron <aaron.lu@intel.com>; Li, Aubrey <aubrey.li@intel.com>
Subject: Re: [PATCH v2 5/5] Manual: Add manual for pthread mutex
On 07/12/2018 11:52 PM, Kemi Wang wrote:
> Pthread mutex is not described in the documentation, so I started to
> document pthread mutex with PTHREAD_MUTEX_QUEUESPINNER type here at least.
>
> Signed-off-by: Kemi Wang <kemi.wang@intel.com>
> ---
> manual/Makefile | 2 +-
> manual/mutex.texi | 68
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 69 insertions(+), 1 deletion(-) create mode 100644
> manual/mutex.texi
I don't think this patch should create a new chapter. There is already threads.texi---woefully incomplete as it may be (one and a half pages in the PDF and over 100 functions in the .texi file documented in comments as undocumented). There are currently two sections in threads.texi:
Thread-specific Data and Non-POSIX Extensions. I think this patch should introduce a new section in that chapter; something like Mutexes.
This issue is independent of the content, which I'll review separately.
Rical
next prev parent reply other threads:[~2018-07-18 7:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 6:55 [PATCH v2 0/5] Add a new mutex type PTHREAD_MUTEX_QUEUESPINNER_NP Kemi Wang
2018-07-13 6:55 ` [PATCH v2 2/5] MCS lock: Enhance legacy MCS lock algorithm Kemi Wang
2018-07-13 6:55 ` [PATCH v2 1/5] Mutex: Queue spinners to reduce cache line bouncing and ensure fairness Kemi Wang
2018-07-13 6:55 ` [PATCH v2 3/5] Mutex: add unit tests for new type Kemi Wang
2018-07-13 6:55 ` [PATCH v2 4/5] BENCHMARK: add a benchmark for testing new type of mutex Kemi Wang
2018-07-13 6:55 ` [PATCH v2 5/5] Manual: Add manual for pthread mutex Kemi Wang
2018-07-18 7:34 ` Rical Jasan
2018-07-18 7:56 ` Wang, Kemi [this message]
2018-08-02 0:38 ` [PATCH v2 0/5] Add a new mutex type PTHREAD_MUTEX_QUEUESPINNER_NP kemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25017BF213203E48912DB000DE5F5E1E6B83838E@SHSMSX101.ccr.corp.intel.com \
--to=kemi.wang@intel.com \
--cc=aaron.lu@intel.com \
--cc=adhemerval.zanella@linaro.org \
--cc=andi.kleen@intel.com \
--cc=aubrey.li@intel.com \
--cc=carlos@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=rj@2c3t.io \
--cc=tim.c.chen@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).