From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by sourceware.org (Postfix) with ESMTPS id 5CF0E384A87E for ; Thu, 18 Mar 2021 17:54:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5CF0E384A87E Received: by mail-qt1-x836.google.com with SMTP id u7so4718751qtq.12 for ; Thu, 18 Mar 2021 10:54:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=r/HxTjMj7gFoCYJWNtIML1KBff9HZFV3mzy1wzD5YTE=; b=VktaVIw4GjOUfoSbwyS9sUEPAHB9NOoFe9wsudWVRBPSJigJFHg4uDjm8+z+euTfgG 9GzIrBmPwhkq9FUWygGKSgyzWJS0iK1drEFEwDPMmkD8tLjamw/xuPJukQQb1DgAegR5 8QXyJvxEiBaROUUA3MYrdw2hrtUpWBU3mZwrVeoO19Z+igvOjnzuwcaYgkrfnCVNTgGV XmFlAPgTDAIBFUooMnVUgrqoix8nwQmJtrCde9fZ7tw/yBu+OP1y2OaYmMjg7SY5PSPB xAhX2rx0R63rbBID8T2e0ZyD7CCgExi1bk5/W4n4PLgPIsfFZgKRou+X9Bw/Fvkwz6fD EI+Q== X-Gm-Message-State: AOAM533QYXtMafLwAW0a/AqMjnh3tEnztE3kji0dmR41eN2SALsZhuWU y7Dgx3gZDQMYQoMVHXoLLOwdo8EqmCeSJl9n X-Google-Smtp-Source: ABdhPJzZUYng4xgqTZva/i3UP45o82AhSROQrsaH69sWpn3qKFHCv2SY9Sdsq/jPiFhXvAYZm0jgNw== X-Received: by 2002:ac8:519a:: with SMTP id c26mr4809682qtn.342.1616090070727; Thu, 18 Mar 2021 10:54:30 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id g7sm1962731qti.20.2021.03.18.10.54.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Mar 2021 10:54:30 -0700 (PDT) Subject: Re: [PATCH v3 14/37] nptl: Move __nptl_deallocate_tsd into libc To: Florian Weimer Cc: libc-alpha@sourceware.org References: <87v99oqt5d.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: <25493b00-e905-8a00-5664-589d330874d2@linaro.org> Date: Thu, 18 Mar 2021 14:54:27 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87v99oqt5d.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Mar 2021 17:54:32 -0000 On 18/03/2021 14:16, Florian Weimer wrote: > * Adhemerval Zanella: > >>> diff --git a/nptl/nptl_deallocate_tsd.c b/nptl/nptl_deallocate_tsd.c >>> new file mode 100644 >>> index 0000000000..c665f4a08a >>> --- /dev/null >>> +++ b/nptl/nptl_deallocate_tsd.c >>> @@ -0,0 +1,112 @@ >>> +/* Deallocation thread-specific data structures related to pthread_key_create. >> >> I think this line is too long. > > I count 78 characters, so it should be fine? Ack.