From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by sourceware.org (Postfix) with ESMTPS id 033843858407 for ; Fri, 17 Dec 2021 18:54:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 033843858407 Received: by mail-qk1-x735.google.com with SMTP id de30so3143959qkb.0 for ; Fri, 17 Dec 2021 10:54:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZVfaHuSXVaMW9qScgFcug5yklfThuL9nmXapp/iCYsA=; b=yBX2IV4mpfXxoSr73NUjc5uRaORccm5LJ6PACZDLdblclYadzPTiDyBfGKXoS8ewMH 2psXNcQHPAGqO6GQBkFa3sNz56trzcDVYwkfwzC6F6+B/BY8WmF+6/MkVpC+tGV5zidA DukbSBUimqwibYKdRQgd7+q8mHkm1zs+NUvon1bgoeDc0r9BE1PbN3nbikminiqsmVfs 1BTbFpASycylaqzIC4M2UiTppascIZWKbLozn/Kwklj4QsiOIwNMFCbSDc/tub5zmmzc JQEHRInZFOf4sdx2F1y8QLOBD/jIle5sif0z3Fa0tkw4vn68fn8BD7mC/FLqk/+VlCwZ h6Dw== X-Gm-Message-State: AOAM530pMhTzfvZS7dBBdaJi86p32wZjMuNXDlO8CPgFiw1DqLLdU1/8 RMphavXv3Pw3zKipWwg8P/cDgKflnZofAUi9 X-Google-Smtp-Source: ABdhPJxKHBPrGDIDvdW9T62sg68+QDSrjy4JWJGoOyCiU8ql2GU8e/Ut/6ervOu9TNSQAHKN6LXyqw== X-Received: by 2002:a37:a5d5:: with SMTP id o204mr2752262qke.10.1639767298533; Fri, 17 Dec 2021 10:54:58 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:103f:7084:332e:7513:f115? ([2804:431:c7ca:103f:7084:332e:7513:f115]) by smtp.gmail.com with ESMTPSA id w10sm7845742qtj.37.2021.12.17.10.54.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Dec 2021 10:54:58 -0800 (PST) Message-ID: <254fb83c-721c-25bd-076a-f91433be8d0c@linaro.org> Date: Fri, 17 Dec 2021 15:54:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v6 07/20] elf: Add _dl_audit_preinit Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-8-adhemerval.zanella@linaro.org> <877dc3i27z.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <877dc3i27z.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 18:55:00 -0000 On 17/12/2021 14:13, Florian Weimer wrote: > * Adhemerval Zanella: > >> diff --git a/elf/dl-audit.c b/elf/dl-audit.c >> index 8e4c65fdaf..a968cbde16 100644 >> --- a/elf/dl-audit.c >> +++ b/elf/dl-audit.c >> @@ -122,6 +122,21 @@ _dl_audit_objclose (struct link_map *l, Lmid_t nsid) >> } >> } >> >> +void >> +_dl_audit_preinit (struct link_map *l) >> +{ >> + if (__glibc_likely (GLRO(dl_naudit) < 0)) >> + return; > > Typo, should be == 0, I think. Ack.