From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5AA1A385840C for ; Fri, 28 Jan 2022 17:20:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5AA1A385840C Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-364-yBF4uAoXPbCTqP7HaclhpA-1; Fri, 28 Jan 2022 12:20:43 -0500 X-MC-Unique: yBF4uAoXPbCTqP7HaclhpA-1 Received: by mail-qk1-f197.google.com with SMTP id i26-20020a05620a075a00b0047ec29823c0so5315377qki.6 for ; Fri, 28 Jan 2022 09:20:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=wSaguRZx+ASC2vhmWyAzfAKJT2WDeYViklHM5Dnaw6Q=; b=Z7JinBQwI2AJTtrmbXfeGBnz8iactG6gBqgEKk4yajTwCZCNs1N+hu4Uw2JA2eScD2 V40w9oXMAXs1/a9M468tRu701pLK8z5n6FMItnrSNvK14vcULeIhW6bvF+9ZCEGjDJnq LixCk0UDjxIgHLz6Op80QS6YT9HkN9Eg8oXGelDd0HcaSJYEiXIwnDhmeNz9ubKjJ8AB Ak0rFn/aORPBKV/8yBAE5qV5wb3/l0YoJIP1FdQhZGpihuOTQqczbHUBG3V2RE+RiR9V OR8g/HCJzk8YG+QkNtVpuvAU6zdQ3ooSa4dWLTx39Jh+s4FNVMHxL3q+B6Vz3ts1liln mb4g== X-Gm-Message-State: AOAM532+z+LGfauRU+SGFuCVUVJAI8AocPW+wCjoQofMwbcCdluxix6l UPpLTXItvITU4QUPKH/2fnWbDArCCWiWl6L9UupQMJhScCrxEI2F9Zmzg8Zny3QWjEpHAFASdcf C0K+uNbvajnZ8pVdUfTw5 X-Received: by 2002:a05:622a:14d4:: with SMTP id u20mr5295626qtx.262.1643390443022; Fri, 28 Jan 2022 09:20:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJwmUlfztS3e8Oa1/q0E1wwoOEhnKaxlAc+mxPN/YLlqTHCzUPdEVFE6EbbVFBAxuLKhk1RY5Q== X-Received: by 2002:a05:622a:14d4:: with SMTP id u20mr5295609qtx.262.1643390442769; Fri, 28 Jan 2022 09:20:42 -0800 (PST) Received: from [192.168.0.241] (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id bj19sm36808qkb.109.2022.01.28.09.20.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jan 2022 09:20:42 -0800 (PST) Message-ID: <25fed982-cac8-113b-f5aa-66a54df679fc@redhat.com> Date: Fri, 28 Jan 2022 12:20:41 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] Fix elf/loadfail test build dependencies To: Szabolcs Nagy , libc-alpha@sourceware.org References: <20220128133617.4077738-1-szabolcs.nagy@arm.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20220128133617.4077738-1-szabolcs.nagy@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 17:20:49 -0000 On 1/28/22 08:36, Szabolcs Nagy via Libc-alpha wrote: > There was no direct or indirect make dependency on testobj3.so so the > test could fail with > > /B/elf/loadfail: failed to load shared object: testobj3.so: cannot open > shared object file: No such file or directory Good catch. OK for glibc 2.35. Reviewed-by: Carlos O'Donell > --- > elf/Makefile | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/elf/Makefile b/elf/Makefile > index 718e826290..1fa1a519a5 100644 > --- a/elf/Makefile > +++ b/elf/Makefile > @@ -1468,7 +1468,9 @@ preloadtest-ENV = \ > > LDFLAGS-loadfail = -rdynamic > > -$(objpfx)loadfail.out: $(objpfx)failobj.so > +$(objpfx)loadfail.out: $(objpfx)failobj.so $(objpfx)testobj1.so \ > + $(objpfx)testobj2.so $(objpfx)testobj3.so \ > + $(objpfx)testobj4.so $(objpfx)testobj5.so > > LDFLAGS-multiload = -rdynamic > CFLAGS-multiload.c += -DOBJDIR=\"$(elf-objpfx)\" -- Cheers, Carlos.