From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: Florian Weimer <fw@deneb.enyo.de>,
Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] manual: Document __wur usage under _FORTIFY_SOURCE
Date: Fri, 24 Mar 2023 11:23:01 -0400 [thread overview]
Message-ID: <261a3c2b-3008-ab78-47ac-2b0c700500b3@sourceware.org> (raw)
In-Reply-To: <877cv62na6.fsf@mid.deneb.enyo.de>
On 2023-03-24 11:15, Florian Weimer wrote:
>> diff --git a/manual/maint.texi b/manual/maint.texi
>> index 76d4a1a147..ae651c2a4a 100644
>> --- a/manual/maint.texi
>> +++ b/manual/maint.texi
>> @@ -206,7 +206,10 @@ to the function call are safe, the call may be replaced by a call to its
>> hardened variant that does additional safety checks at runtime. Some
>> hardened variants need the size of the buffer to perform access
>> validation and this is provided by the @code{__builtin_object_size} or
>> -the @code{__builtin_dynamic_object_size} builtin functions.
>> +the @code{__builtin_dynamic_object_size} builtin functions. The macro
>> +also enables additional compile time diagnostics, such as unchecked
>> +return values from some functions, to encourage developers to add error
>> +checking for those functions.
>
> Maybe repeat _FORTIFY_SOURCE it's been a while since it's been
> mentioned?
Ack, will do.
> Note that now that GCC supports [[nodiscard]] (with the standard way
> to suppress it), we could apply that to functions even outside
> _FORTIFY_SOURCE, I think. That's a separate matter, of course.
Yes, I've wondered that too. I'll start a separate thread about that later.
Thanks,
Sid
next prev parent reply other threads:[~2023-03-24 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 14:40 Siddhesh Poyarekar
2023-03-24 15:15 ` Florian Weimer
2023-03-24 15:23 ` Siddhesh Poyarekar [this message]
2023-03-24 15:25 ` [PATCH v2] " Siddhesh Poyarekar
2023-04-03 13:54 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=261a3c2b-3008-ab78-47ac-2b0c700500b3@sourceware.org \
--to=siddhesh@sourceware.org \
--cc=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).