From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from quail.birch.relay.mailchannels.net (quail.birch.relay.mailchannels.net [23.83.209.151]) by sourceware.org (Postfix) with ESMTPS id 3E34A3858D28 for ; Wed, 21 Jun 2023 11:43:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E34A3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C1A827E1700; Wed, 21 Jun 2023 11:43:00 +0000 (UTC) Received: from pdx1-sub0-mail-a243.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 4D1DC7E1FC9; Wed, 21 Jun 2023 11:43:00 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1687347780; a=rsa-sha256; cv=none; b=38dZ2jMj9H6uXRtOfqrEHhEfVg90x8fKJKadxN/AFPcWWU17kmLTKRjBptwtWME0mAWAD2 ZUfQSk5kdwipQOab82rVhbUVlRNABojh3XM1FvKAYa/K8R3H40DrgJZCxnw/6cS6yvKSqw HlfjjOoWZZguY4r9WvLILw9rboKj+QjVSBwyODZuE5F0ryYm4GIWcZgXAmOGb6ouO0nR/5 cIkyISXoMkwA6lI2lC1Ak2STzvua8T8c6DiRvu0LQOOVHFBWfCvrwcCA4djXh146AznBeE os8ahrHsYa6T0bAu4gG/SMxq5mRFbvzmIBkc/1JCirDfMg+vrfIQzOZKVdz6qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1687347780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sntf845nd12EVBJm9BlaKjEpdL6AcHAQ7NkbrIokUaQ=; b=kkejFwgn8UOoaMS8NxT26smzUmtv7dSd0NjEM3zs0qEWeW1dEbbQ0JN7FaqXS7B2LksHBj zKB56QBHOtLK4iBKrs9lklZBX+gBYqNv2lk/fDZTycd90+N1IuyGXLyskSiHYBtpsYNUep 4XD56TfQ72xlrgiVLpQypicuOIsc4RxLnJwf/RtXMqtwdRb73q5xCKbsoCakO+c4lpcAcT 6omBT+8Q8IsvHjJ3v0CBm+jZy60YyJkdCnAwncaUyxW3iVuAPTKFlQ7UKKyen5HCseal3a 2+ulZSa68VMSkWPFRNd97jgv04vy//zHzDBGGfp0y4ExeAs8lgzhWD4XHBitLQ== ARC-Authentication-Results: i=1; rspamd-85899d6fcc-rt5pv; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Madly-Tank: 72626cb43fea8e20_1687347780558_4162786707 X-MC-Loop-Signature: 1687347780558:323783578 X-MC-Ingress-Time: 1687347780558 Received: from pdx1-sub0-mail-a243.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.125.42.143 (trex/6.9.1); Wed, 21 Jun 2023 11:43:00 +0000 Received: from [192.168.0.182] (unknown [174.91.45.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a243.dreamhost.com (Postfix) with ESMTPSA id 4QmM7l6TDNz2t; Wed, 21 Jun 2023 04:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1687347780; bh=sntf845nd12EVBJm9BlaKjEpdL6AcHAQ7NkbrIokUaQ=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=jtEuTO8fvu+St+tqMcUeYrYSVxy/merspbRh71iQg+LkSbltfXqVp7AgA6QxNfBVX 91JjOtvK5sRVPm18vGrtodWUOQaonpTG5IPNtqyGeY/uo6XFAa4f43bcn9xgjSU4jd iBTMbw8CbAV7lTSUrnynlstdXWgfPKgBSABRESHglq1ecr9hkO6U4RjQBwzpQ/hCWN 30c1gs05xC9AngAhjT4oaQEMgcyito2gbldTGkTUoh8MVEf7EP09eiGZQjMNIoVOeR QC+hwUpoMBcPEGv8n9ZWe2Ikk1ik/hu10APFEq7JUZRuLydMunPLFeqtuzV0S2e6Pi TK9BOn2AEcj/A== Message-ID: <26737a50-4839-57a3-7b17-7d1c43c5bbe4@gotplt.org> Date: Wed, 21 Jun 2023 07:42:48 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 21/21] benchtests: fix warn unused result Content-Language: en-US To: =?UTF-8?B?RnLDqWTDqXJpYyBCw6lyYXQ=?= , libc-alpha@sourceware.org References: <20230620181910.1506893-1-fberat@redhat.com> <20230620181910.1506893-22-fberat@redhat.com> From: Siddhesh Poyarekar In-Reply-To: <20230620181910.1506893-22-fberat@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3037.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-06-20 14:19, Frédéric Bérat wrote: > Few tests needed to properly check for asprintf and system calls return > values with _FORTIFY_SOURCE enabled. Reviewed-by: Siddhesh Poyarekar > --- > benchtests/bench-strcoll.c | 6 +++++- > sysdeps/unix/sysv/linux/s390/tst-ptrace-singleblock.c | 3 ++- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/benchtests/bench-strcoll.c b/benchtests/bench-strcoll.c > index b3cd5ce8a9..0bd9ada5f6 100644 > --- a/benchtests/bench-strcoll.c > +++ b/benchtests/bench-strcoll.c > @@ -254,7 +254,11 @@ main (void) > } > > char *filename; > - asprintf (&filename, INPUT_PREFIX "%s", input_files[i]); > + if (asprintf (&filename, INPUT_PREFIX "%s", input_files[i]) < 0) > + { > + printf ("asprintf failed, aborting!\n"); > + return ERROR_FILENAME; > + } > result = bench_file (json_ctx, input_files[i], filename, locale + 1); > > if (result != OK) > diff --git a/sysdeps/unix/sysv/linux/s390/tst-ptrace-singleblock.c b/sysdeps/unix/sysv/linux/s390/tst-ptrace-singleblock.c > index e5cdb2b2a1..4631ec9f0b 100644 > --- a/sysdeps/unix/sysv/linux/s390/tst-ptrace-singleblock.c > +++ b/sysdeps/unix/sysv/linux/s390/tst-ptrace-singleblock.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -44,7 +45,7 @@ tracee_func (int pid) > char str[80]; > sprintf (str, "cat /proc/%d/maps", pid); > puts (str); > - system (str); > + xsystem (str); > fflush (stdout); > > TEST_VERIFY_EXIT (ptrace (PTRACE_TRACEME) == 0);