From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zimbra.cs.ucla.edu (zimbra.cs.ucla.edu [131.179.128.68]) by sourceware.org (Postfix) with ESMTPS id 4EC4F3857C4E for ; Mon, 5 Oct 2020 21:35:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4EC4F3857C4E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cs.ucla.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eggert@cs.ucla.edu Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CBF491600DA; Mon, 5 Oct 2020 14:35:04 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id uDmRvSlUUxan; Mon, 5 Oct 2020 14:35:04 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 316A11600F8; Mon, 5 Oct 2020 14:35:04 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id MSM0NXpoyo7M; Mon, 5 Oct 2020 14:35:04 -0700 (PDT) Received: from [192.168.0.102] (cpe-23-243-218-95.socal.res.rr.com [23.243.218.95]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0A3591600DA; Mon, 5 Oct 2020 14:35:04 -0700 (PDT) Subject: Re: /usr/include/aio.h To: Jonny Grant Cc: libc-alpha@sourceware.org References: <1585f908-1ee9-5d00-1dd4-3fa16c70b042@jguk.org> <5772b104-aa7a-4cc4-e242-fd341b395ef8@cs.ucla.edu> <1ef3ddcc-881a-ca26-b6dd-d3a37862da82@jguk.org> <9a7422e9-bd6d-e705-2d23-11bb13249931@cs.ucla.edu> <8a220a04-8a32-39e0-0208-9637a30ff7cc@jguk.org> From: Paul Eggert Message-ID: <26968fa6-cea0-9986-0f78-fbbec1bae8d3@cs.ucla.edu> Date: Mon, 5 Oct 2020 14:35:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <8a220a04-8a32-39e0-0208-9637a30ff7cc@jguk.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2020 21:35:06 -0000 On 10/5/20 1:53 PM, Jonny Grant wrote: > > It looks like everything would compile fine with the enum alone as follows: > > enum > { > AIO_CANCELED = 0, > AIO_NOTCANCELED = 1, > AIO_ALLDONE = 2 > }; Everything in glibc, most likely yes. But application code that uses "#ifdef AIO_NOTCANCELLED" wouldn't work. > > Could this comment patch be considered? > Yes, it should be fine.