From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by sourceware.org (Postfix) with ESMTPS id 075103857C63 for ; Fri, 10 Dec 2021 13:58:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 075103857C63 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R101e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04357; MF=rongwei.wang@linux.alibaba.com; NM=1; PH=DS; RN=5; SR=0; TI=SMTPD_---0V-AKG93_1639144687; Received: from 30.240.97.30(mailfrom:rongwei.wang@linux.alibaba.com fp:SMTPD_---0V-AKG93_1639144687) by smtp.aliyun-inc.com(127.0.0.1); Fri, 10 Dec 2021 21:58:08 +0800 Message-ID: <27109838-766d-43bd-8a75-239d0f387d80@linux.alibaba.com> Date: Fri, 10 Dec 2021 21:58:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:95.0) Gecko/20100101 Thunderbird/95.0 Subject: Re: [PATCH v5 0/2] fix p_align on PT_LOAD segment in DSO isn't honored Content-Language: en-US To: "H.J. Lu" Cc: GNU C Library , Florian Weimer , xuyu@linux.alibaba.com, gavin.dg@linux.alibaba.com References: <20211204045848.71105-1-rongwei.wang@linux.alibaba.com> <20211210123911.86568-1-rongwei.wang@linux.alibaba.com> From: Rongwei Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 13:58:20 -0000 Hi On 12/10/21 9:13 PM, H.J. Lu wrote: > On Fri, Dec 10, 2021 at 4:39 AM Rongwei Wang > wrote: >> >> Hi >> >> This patch mainly to fix a reported bug: >> >> "p_align on PT_LOAD segment in DSO isn't honored" >> https://sourceware.org/bugzilla/show_bug.cgi?id=28676 >> >> A testcase had been builded by H.J.Lu: >> https://sourceware.org/bugzilla/attachment.cgi?id=13838 >> >> And in Patch 1/1, I also show a simple testcase which >> modified from H.J.Lu. >> >> And a similar bug in ELF binary was also reported: >> https://bugzilla.kernel.org/show_bug.cgi?id=215275 > > I submitted a kernel patch: > > https://lore.kernel.org/lkml/20211209174052.370537-1-hjl.tools@gmail.com/T/ > > Hopefully, it will be landed soon. Nice! And if available, you can CC my email. And I think this patch can help us to introduce .text hugepages transparently. > >> A related fix patch could been found: >> https://lore.kernel.org/linux-mm/20211009092658.59665-4-rongwei.wang@linux.alibaba.com/ >> Originally, we send this patch for introducing .text >> hugepages, was not aware of it's bug. And now, I am >> not sure whether kernel maintainer will regards it as >> a bug. But it deserved try again. >> >> Thanks. >> >> Changelog: >> >> v4 -> v5 >> - Patch "Add a testcase to check alignment of PT_LOAD segment" >> add new testcase for PT_LOAD segment >> - Patch "elf: Properly align PT_LOAD segments" >> fix map_start to use map_start_aligned when second mmap failed >> >> v3 -> v4 >> - Patch "elf: Properly align PT_LOAD segments" >> Call unmap when the second mmap fails. >> >> v2 -> v3 >> - Patch "elf: Properly align PT_LOAD segments" >> move mapalign into 'struct loadcmd' >> fix some coding style >> >> RFC/v1 -> v2 >> >> - Patch "elf: align the mapping address of LOAD segments with p_align" >> fix coding format and add testcase in commit. >> >> RFC link: >> https://patchwork.sourceware.org/project/glibc/patch/20211204045848.71105-2-rongwei.wang@linux.alibaba.com/ >> >> H.J. Lu (1): >> Add a testcase to check alignment of PT_LOAD segment >> >> Rongwei Wang (1): >> elf: Properly align PT_LOAD segments >> >> elf/Makefile | 14 +++++++++++-- >> elf/dl-load.c | 1 + >> elf/dl-load.h | 2 +- >> elf/dl-map-segments.h | 49 +++++++++++++++++++++++++++++++++++++++---- >> elf/tst-align3.c | 37 ++++++++++++++++++++++++++++++++ >> elf/tst-alignmod3.c | 31 +++++++++++++++++++++++++++ >> 6 files changed, 127 insertions(+), 7 deletions(-) >> create mode 100644 elf/tst-align3.c >> create mode 100644 elf/tst-alignmod3.c >> >> -- >> 2.27.0 >> > > LGTM. > > Reviewed-by: H.J. Lu > > Can you check it in? I have some doubts. I had subscribed linux-kernel mail list long time, but I can not find your patch. Do you have received any review mail? Tnanks. > > Thanks. > > -- > H.J. >