From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99521 invoked by alias); 2 Jun 2017 14:05:18 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 99509 invoked by uid 89); 2 Jun 2017 14:05:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1033BC0587D3 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1033BC0587D3 Subject: Re: [PATCH] getaddrinfo: Always allocate canonical name on the heap To: Adhemerval Zanella References: <20170511100718.1F66A401E714A@oldenburg.str.redhat.com> <52802461-8188-52e7-eeba-9cdce0be340d@linaro.org> Cc: libc-alpha@sourceware.org From: Florian Weimer Message-ID: <2738bd73-a636-1e6e-7eb0-225c99d91b5d@redhat.com> Date: Fri, 02 Jun 2017 14:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <52802461-8188-52e7-eeba-9cdce0be340d@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00098.txt.bz2 On 06/02/2017 03:56 PM, Adhemerval Zanella wrote: >> +static char * >> +getcanonname (service_user *nip, struct gaih_addrtuple *at, const char *name) >> +{ >> + return strdup (name); >> +} > I think you need to use __strdup here, I am seeing check-local-plt failures on > master. On which architecture? I don't get see it on x86-64. I can push a fix blindly (based on the headers, it indeed needs to be __strdup). Thanks, Florian