Re: [PATCH v2 18/30] ldbl-128ibm-compat: Add tests for strfroml, strtold, and wcstold

[Paul E Murphy <murphyp@linux.ibm.com>]

On 10/25/19 10:33 AM, Gabriel F. T. Gomes wrote:
> From: "Gabriel F. T. Gomes" <gabrielftg@linux.ibm.com>
> 
> No changes since v1.
> 
> -- 8< --
> Since the commit
> 
> commit 86a0f56158bd9cbaf2d640e2e6c66539f4cbbcc1
> Author: Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>
> Date:   Thu Jun 28 13:57:50 2018 +0530
> 
>      ldbl-128ibm-compat: Introduce ieee128 symbols
> 
> IEEE long double versions of strfroml, strtold, and wcstold have been
> prepared, but not exposed (which will only happen when the full support
> for IEEE long double is complete).  This patch adds tests for these
> functions in both IBM and IEEE long double mode.

> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile
> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ibm128.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ibm128.c
> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ieee128.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ieee128.c

OK

> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ldbl-compat.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-strfrom-ldbl-compat.c
OK

> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ibm128.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ibm128.c
> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ieee128.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ieee128.c

OK

> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ldbl-compat.c b/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ldbl-compat.c
> new file mode 100644
> index 0000000000..8b9e300147
> --- /dev/null
> +++ b/sysdeps/ieee754/ldbl-128ibm-compat/test-wcstold-ldbl-compat.c
> @@ -0,0 +1,36 @@
> +/* Test for the long double variant of wcstold.
> +   Copyright (C) 2019 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <http://www.gnu.org/licenses/>.  */
> +
> +#include <wchar.h>
> +
> +#include <support/check.h>
> +
> +static int
> +do_test (void)
> +{
> +  const wchar_t *input = L"-1.0000000000";
> +  long double read;
> +
> +  read = wcstold (input, NULL);
> +  if (read != (long double) -1)

Trivial nit, any reason to avoid using -1.0L directly (likewise for 
test-wcstold-ldbl-compat.c)?

> +    support_record_failure ();
> +
> +  return 0;
> +}
> +
> +#include <support/test-driver.c>
>