From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by sourceware.org (Postfix) with ESMTPS id BD5223854835 for ; Thu, 18 Mar 2021 12:43:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BD5223854835 Received: by mail-qv1-xf32.google.com with SMTP id h3so3062588qvh.8 for ; Thu, 18 Mar 2021 05:43:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ECJSMxcO7L4lHbw1x8iXVJoGbALxfknHe00nnqtBvJs=; b=RauYWl5JL1D/Sg7E+qUilMwHpBIIQqM+ci7jgo9sYRYiwlsL11OqB+kht/Ov12251t vZwY8cyRUMiZ+V7yyW7rL4ltQQmCyuzWcVkvcAAnK1Iu6s7HEmZiCiEkN60h+0+tsS6v J8Lpr5gXl1s28ab8nBpzA4DLlng+I1NhfoudsWuRNPT0JvI2hT8T/NajNxaAv9cqFZIz azxZwDnsC3wqpNwfEpw3Ncp8d3eCObjqY2NPdOkdTy2xeUBDWfy+ixzCF1OAjp9DzYZt fkRi0mrDM61NdsRQbXDgf3f3Q1BabzeihkqtsKQrdMZfl+bm9u/l9F6BABPbT2jc3xTh 77Ww== X-Gm-Message-State: AOAM530SWruG9RhlP2T4CI9m8oksbTK79EnNgClIz5/8tVngvRkFydCj zbnfOXU2h4Bh0Dql85YQC3/UUCyNihOnIgSZ X-Google-Smtp-Source: ABdhPJwH1ZQHClkzpB4bVN7BZNoiHKAh0Cg+RGBfbvViJre8pnCTFqdOYanWjJ+1nx7kKlsSlFL8Vw== X-Received: by 2002:ad4:4cca:: with SMTP id i10mr4086037qvz.49.1616071397334; Thu, 18 Mar 2021 05:43:17 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id j26sm1350543qtp.30.2021.03.18.05.43.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Mar 2021 05:43:17 -0700 (PDT) Subject: Re: [PATCH v3 12/37] nptl_db: Introduce DB_MAIN_ARRAY_VARIABLE To: libc-alpha@sourceware.org, Florian Weimer References: From: Adhemerval Zanella Message-ID: <28040a96-c8e8-ea6c-2ad0-a2bbf16778c3@linaro.org> Date: Thu, 18 Mar 2021 09:43:13 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Mar 2021 12:43:19 -0000 LGTM, thanks. Reviewed-by: Adhemerval Zanella On 16/03/2021 14:29, Florian Weimer via Libc-alpha wrote: > And document the reason for DB_ARRAY_VARIABLE. > --- > nptl_db/db-symbols.awk | 1 + > nptl_db/structs.def | 5 +++++ > 2 files changed, 6 insertions(+) > > diff --git a/nptl_db/db-symbols.awk b/nptl_db/db-symbols.awk > index eb089e188a..9e981537c8 100644 > --- a/nptl_db/db-symbols.awk > +++ b/nptl_db/db-symbols.awk > @@ -4,6 +4,7 @@ > BEGIN { > %define DB_RTLD_VARIABLE(name) /* Nothing. */ > %define DB_MAIN_VARIABLE(name) /* Nothing. */ > +%define DB_MAIN_ARRAY_VARIABLE(name) /* Nothing. */ > %define DB_LOOKUP_NAME(idx, name) required[STRINGIFY (name)] = 1; > %define DB_LOOKUP_NAME_TH_UNIQUE(idx, name) th_unique[STRINGIFY (name)] = 1; > %include "db-symbols.h" > diff --git a/nptl_db/structs.def b/nptl_db/structs.def > index d0e1cb659a..1522c96f8f 100644 > --- a/nptl_db/structs.def > +++ b/nptl_db/structs.def > @@ -26,9 +26,14 @@ > # define DB_RTLD_VARIABLE(name) DB_VARIABLE (name) > #endif > > +/* DB_MAIN_VARIABLE and DB_MAIN_ARRAY_VARIABLE are not covered by the > + libpthread symbol check in db-symbols.awk. */ > #ifndef DB_MAIN_VARIABLE > # define DB_MAIN_VARIABLE(name) DB_VARIABLE (name) > #endif > +#ifndef DB_MAIN_ARRAY_VARIABLE > +# define DB_MAIN_ARRAY_VARIABLE(name) DB_ARRAY_VARIABLE (name) > +#endif > > #ifndef DB_RTLD_GLOBAL_FIELD > # if !IS_IN (libpthread) >