From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) by sourceware.org (Postfix) with ESMTPS id E7DA5383D03E for ; Wed, 2 Jun 2021 14:01:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E7DA5383D03E Received: by mail-qv1-xf2f.google.com with SMTP id u33so1322062qvf.9 for ; Wed, 02 Jun 2021 07:01:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AozU+azJMgi833VWeUOW2P3SVJZSVQX27lVoaM1AEUQ=; b=ua3K/CDeYsVGxdcYAloEsj4y1Bx0j5PDcC7FHqICf8WbF+SRNoh2kJY5nb7+wtCQJO UYKsOoveth28kNCEBvMzdx2cmpJBS+2ysohUy4JpGIqZJgu/+lRk5qZ615pZB3LvYBed bmY4G+NCuxI6VLy9lkS2EeZfrSano95NtLhiEtmg/1Dgf9C93Gs4Vx3wh6cbRX98pxEW W3nEblGvWFpDCSsUxaKWrynYPNbVy86/QSwFhuyq1BKBp8YA8uvqcuJ7icMqQ7pK2pIP cT01Rswz5sG8tQqulX4rhpcAlsRURdwJnoLqmKJDsnP6LX6Q/l6sMX2bqklsqCUAFfGx XO0Q== X-Gm-Message-State: AOAM533tBPBJLDLnDH/Qn1ZUpBQ+cF/ty+d7uAue6J2lSyxxDLEzQDXN rWGhgYaEdxuBSUPzeTBWw6E8cCvJhB700w== X-Google-Smtp-Source: ABdhPJzGlfhXpe2OB1lHb4L5jUIq7VSVQt3g9qP/UFHLD+/UvTWh6hSqVUFGkTYdVisOxcnIQFEz6w== X-Received: by 2002:ad4:58d2:: with SMTP id dh18mr14220882qvb.12.1622642490354; Wed, 02 Jun 2021 07:01:30 -0700 (PDT) Received: from [192.168.1.4] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id d24sm12512217qtm.70.2021.06.02.07.01.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 07:01:30 -0700 (PDT) Subject: Re: [PATCH v3] nptl: Deallocate the thread stack on setup failure (BZ #19511) To: Andreas Schwab Cc: Adhemerval Zanella via Libc-alpha References: <20210527172823.3461314-3-adhemerval.zanella@linaro.org> <20210602125644.3725112-1-adhemerval.zanella@linaro.org> <87r1hkjtwj.fsf@igel.home> <4e623fa1-419e-5c54-2da3-61a2c3f143ed@linaro.org> <87mts8jsda.fsf@igel.home> From: Adhemerval Zanella Message-ID: <28311d99-55b0-808f-5130-1a9895b9cf77@linaro.org> Date: Wed, 2 Jun 2021 11:01:27 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87mts8jsda.fsf@igel.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 14:01:41 -0000 On 02/06/2021 10:41, Andreas Schwab wrote: > On Jun 02 2021, Adhemerval Zanella wrote: > >> On 02/06/2021 10:08, Andreas Schwab wrote: >>> On Jun 02 2021, Adhemerval Zanella via Libc-alpha wrote: >>> >>>> diff --git a/nptl/descr.h b/nptl/descr.h >>>> index 3de9535449..9d8297b45f 100644 >>>> --- a/nptl/descr.h >>>> +++ b/nptl/descr.h >>>> @@ -340,8 +340,9 @@ struct pthread >>>> /* True if thread must stop at startup time. */ >>>> bool stopped_start; >>>> >>>> - /* Formerly used for dealing with cancellation. */ >>>> - int parent_cancelhandling_unsed; >>>> + /* Indicate that a thread creation setup has failed (for instance the >>>> + scheduler or affinity). */ >>>> + int setup_failed; >>> >>> Perhaps this should be turned into a bitfield? >> >> I do not want to change the 'struct parent' layout or size with this >> patch. > > I didn't say you should change the layout. I don't have a strong preference here, maybe use a 'bool' then?