From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v6 02/10] stdlib: Add arc4random tests
Date: Tue, 28 Jun 2022 13:58:12 -0300 [thread overview]
Message-ID: <28589349-8C6F-45E3-8A8B-DB434DB3B069@linaro.org> (raw)
In-Reply-To: <87sfnpf188.fsf@oldenburg.str.redhat.com>
> On 28 Jun 2022, at 08:59, Florian Weimer <fweimer@redhat.com> wrote:
>
> * Adhemerval Zanella:
>
>> diff --git a/stdlib/tst-arc4random-chacha20.c b/stdlib/tst-arc4random-chacha20.c
>> new file mode 100644
>> index 0000000000..dd0ef6d8ba
>> --- /dev/null
>> +++ b/stdlib/tst-arc4random-chacha20.c
>> @@ -0,0 +1,166 @@
>
>> + <http://www.gnu.org/licenses/>. */
>
> https://, not http://. This impacts the other new files.
Ack.
>
>> +#include <support/check.h>
>> +#include <sys/cdefs.h>
>> +
>> +/* It does not define CHACHA20_XOR_FINAL to check what glibc actual uses. */
>
> Please rephrase what is ”it” in this context? Missing space after ”.”.
I changed to:
/* The test does not define CHACHA20_XOR_FINAL to mimic what arc4random
actual does. */
>
>> + /* Check with the expected internal arc4random keystream buffer. Some
>> + architecture optimization expectes a buffer with a minimum size of
>> + multiple of ChaCha20 blocksize, so they might not be prepared to
>> + handle smaller buffers. */
>
> “a minimum size which is a multiple of the ChaCha20 block size”?
Ack.
>
> Thanks,
> Florian
>
next prev parent reply other threads:[~2022-06-28 16:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 19:14 [PATCH v6 00/10] Add arc4random support Adhemerval Zanella
2022-05-18 19:14 ` [PATCH v6 01/10] stdlib: Add arc4random, arc4random_buf, and arc4random_uniform (BZ #4417) Adhemerval Zanella
2022-06-02 9:44 ` Yann Droneaud
2022-06-10 17:26 ` Adhemerval Zanella
2022-05-18 19:14 ` [PATCH v6 02/10] stdlib: Add arc4random tests Adhemerval Zanella
2022-06-28 11:59 ` Florian Weimer
2022-06-28 16:58 ` Adhemerval Zanella [this message]
2022-05-18 19:14 ` [PATCH v6 03/10] benchtests: Add arc4random benchtest Adhemerval Zanella
2022-06-28 12:01 ` Florian Weimer
2022-06-28 17:06 ` Adhemerval Zanella
2022-06-28 17:13 ` Noah Goldstein
2022-06-28 17:14 ` Noah Goldstein
2022-06-28 17:22 ` Adhemerval Zanella
2022-05-18 19:14 ` [PATCH v6 04/10] aarch64: Add optimized chacha20 Adhemerval Zanella
2022-06-28 12:03 ` Florian Weimer
2022-06-28 17:39 ` Adhemerval Zanella
2022-05-18 19:14 ` [PATCH v6 05/10] x86: Add SSE2 " Adhemerval Zanella
2022-05-18 20:44 ` Noah Goldstein
2022-05-18 19:14 ` [PATCH v6 06/10] x86: Add AVX2 " Adhemerval Zanella
2022-05-18 19:14 ` [PATCH v6 07/10] powerpc64: Add " Adhemerval Zanella
2022-05-18 19:14 ` [PATCH v6 08/10] s390x: " Adhemerval Zanella
2022-05-18 19:14 ` [PATCH v6 09/10] stdlib: Add TLS optimization to arc4random Adhemerval Zanella
2022-06-28 12:19 ` Florian Weimer
2022-06-28 19:45 ` Adhemerval Zanella
2022-05-18 19:14 ` [PATCH v6 10/10] manual: Add documentation for arc4random functions Adhemerval Zanella
2022-06-28 12:09 ` Florian Weimer
2022-06-28 19:15 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28589349-8C6F-45E3-8A8B-DB434DB3B069@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).