From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com [IPv6:2001:4860:4864:20::2a]) by sourceware.org (Postfix) with ESMTPS id D9A163851154 for ; Tue, 28 Jun 2022 16:58:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D9A163851154 Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-101bb9275bcso17823768fac.8 for ; Tue, 28 Jun 2022 09:58:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=0mduyeWuThYhl64xPT48/BysjqglumX2mD6TNvx/odE=; b=tQVHvGv8rKWHFYJ47nl0Zu4hRUhtgFnpNgpFqI2AfL48AY2ybKSwPlE5BjCdWbEWUo Q2tQuDOTCD8XoP9T/oSWr61Wb2HaVJJedniOiPRnNfY7NtZrxca2+mMk6TbEGkXKW4Zo FSDQg5i/lmYZEfrh2LXKj+xgT9d6l5db9PEy+crek+6r1KtwHOsRxM1KFYYyN4nBRSO7 Goi/MM8u3/aSt0NOCVPjBeTqQDuXquIuB/7r854GjJq3HQz/VWx9rf4piwuQ4wWYuFTy HFR3Th+qOU+VSjVmw3/PDFhU0w0GUnE3oZjsLBfVfggvnC/53DVh1LBcyM8y23T/zIQH VClQ== X-Gm-Message-State: AJIora+DetKAzF8Txtig7FhrwN/px0n3n6VQLh27IpOe0vpvF2mdO52a 8RMXKxoYEqAkmBBZ054zRcHu08Jkux39U1OO X-Google-Smtp-Source: AGRyM1tK64FKKpyOF9eQ+jdTbM0/ZPbmUUbDGOMMEQVmql3OGF5rWUz+QFCTnih9w2okLr8l4vFUiQ== X-Received: by 2002:a05:6870:c1cd:b0:fe:1295:6e34 with SMTP id i13-20020a056870c1cd00b000fe12956e34mr343390oad.137.1656435495143; Tue, 28 Jun 2022 09:58:15 -0700 (PDT) Received: from smtpclient.apple ([2804:431:c7ca:6d95:25db:29b6:be9b:9202]) by smtp.gmail.com with ESMTPSA id l83-20020aca3e56000000b0032f0fd7e1f8sm7234721oia.39.2022.06.28.09.58.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jun 2022 09:58:14 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: [PATCH v6 02/10] stdlib: Add arc4random tests From: Adhemerval Zanella In-Reply-To: <87sfnpf188.fsf@oldenburg.str.redhat.com> Date: Tue, 28 Jun 2022 13:58:12 -0300 Cc: libc-alpha@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <28589349-8C6F-45E3-8A8B-DB434DB3B069@linaro.org> References: <20220518191424.3630729-1-adhemerval.zanella@linaro.org> <20220518191424.3630729-3-adhemerval.zanella@linaro.org> <87sfnpf188.fsf@oldenburg.str.redhat.com> To: Florian Weimer X-Mailer: Apple Mail (2.3696.100.31) X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 16:58:18 -0000 > On 28 Jun 2022, at 08:59, Florian Weimer wrote: >=20 > * Adhemerval Zanella: >=20 >> diff --git a/stdlib/tst-arc4random-chacha20.c = b/stdlib/tst-arc4random-chacha20.c >> new file mode 100644 >> index 0000000000..dd0ef6d8ba >> --- /dev/null >> +++ b/stdlib/tst-arc4random-chacha20.c >> @@ -0,0 +1,166 @@ >=20 >> + . */ >=20 > https://, not http://. This impacts the other new files. Ack. >=20 >> +#include >> +#include >> + >> +/* It does not define CHACHA20_XOR_FINAL to check what glibc actual = uses. */ >=20 > Please rephrase what is =E2=80=9Dit=E2=80=9D in this context? Missing = space after =E2=80=9D.=E2=80=9D. I changed to: /* The test does not define CHACHA20_XOR_FINAL to mimic what arc4random actual does. */ >=20 >> + /* Check with the expected internal arc4random keystream buffer. = Some >> + architecture optimization expectes a buffer with a minimum size = of >> + multiple of ChaCha20 blocksize, so they might not be prepared = to >> + handle smaller buffers. */ >=20 > =E2=80=9Ca minimum size which is a multiple of the ChaCha20 block = size=E2=80=9D? Ack. >=20 > Thanks, > Florian >=20