From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 185C1385780C for ; Tue, 24 May 2022 00:25:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 185C1385780C Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-110-LGFzjdYCMQOTYBq4q_5kQQ-1; Mon, 23 May 2022 20:25:35 -0400 X-MC-Unique: LGFzjdYCMQOTYBq4q_5kQQ-1 Received: by mail-qt1-f199.google.com with SMTP id o5-20020ac84285000000b002f942e1ab04so10372qtl.7 for ; Mon, 23 May 2022 17:25:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=WZj49e8czvPQyVIyuEknp3Y7f2UF0WWVvCC4jFJGl+8=; b=brEmieA8ZPo+NU0smbQzCD/UjfiOLUl+CeVbvixrL9Iqk3K9UYT9/ixnYmljZbXShq T4aRWOt9Wd8sJHRbhIib99HKfTG4+jHt/xAlAKWAiFTP9vqbtWGXaDzZsgRqtlTSWry7 QqTrc0Xq0rMEUAhZFDrxxh//V7Nt+cWoaWaT0fQaiR6i9OkVj+w0HAVBRHTIewcRud9O sO6TZog6Ghwsf7GDXUQAYBHfk+ylioO+0AeaMnBd1nS8JekPK8a2oYXCcDSPf+TPKX4H P1sKD9LydOCC3Kho0U2KYHuZkU/KEwdRr0o3n7QvB43bwmZCZ9qc4ra0PkeoXTFIFYfu srJQ== X-Gm-Message-State: AOAM5321WP91JS2NCTCP30bQMxYFhbLvx49tvYn3YRrdvjX5ORws87ed b5b185k6UMn/Dym3bh0R69Zk+PpDDx2sWiaQTIoT5OxVyTj9RlW4YuEsiOkKf+sb2fCVe1bdL+l 4yMjb/5PNGqJ0+sI6lnIS X-Received: by 2002:a05:620a:22e4:b0:69b:fe7a:27bc with SMTP id p4-20020a05620a22e400b0069bfe7a27bcmr14776569qki.166.1653351934863; Mon, 23 May 2022 17:25:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxg9eIgQlldP1Aq78RcwWW/EUmd/nqURV+6cd1ce1sGH3/JZbtyloT8d6g9ZbDNn+s+gbuQGQ== X-Received: by 2002:a05:620a:22e4:b0:69b:fe7a:27bc with SMTP id p4-20020a05620a22e400b0069bfe7a27bcmr14776561qki.166.1653351934670; Mon, 23 May 2022 17:25:34 -0700 (PDT) Received: from [192.168.0.241] (135-23-175-80.cpe.pppoe.ca. [135.23.175.80]) by smtp.gmail.com with ESMTPSA id ew6-20020a05622a514600b002f39b99f69esm5356421qtb.56.2022.05.23.17.25.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 17:25:34 -0700 (PDT) Message-ID: <2863974b-6b29-6a4a-a1cd-d5c5f3ca1bb7@redhat.com> Date: Mon, 23 May 2022 20:25:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [glibc] elf: Rewrite long RESOLVE_MAP macro to an always_inline static function To: Fangrui Song Cc: libc-alpha , Adhemerval Zanella , Siddhesh Poyarekar References: <20220523190646.4D9683858D32@sourceware.org> <20220524002138.tz7df7rnmon7gj7i@google.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20220524002138.tz7df7rnmon7gj7i@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2022 00:25:38 -0000 On 5/23/22 20:21, Fangrui Song wrote: > On 2022-05-23, Carlos O'Donell wrote: >> On 5/23/22 15:06, Fangrui Song via Glibc-cvs wrote: >>> https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a8b11bd1f8dc68795b377138b5d94638ef75a50d >>> >>> commit a8b11bd1f8dc68795b377138b5d94638ef75a50d >>> Author: Nicholas Guriev >>> Date:   Mon May 23 12:06:44 2022 -0700 >>> >>>     elf: Rewrite long RESOLVE_MAP macro to an always_inline static function >>> >>>     An __always_inline static function is better to find where exactly a >>>     crash happens, so one can step into the function with GDB. >>> >>>     Reviewed-by: Fangrui Song >>> >> >> Fangrui, >> >> It looks like we missed the Signed-off-by from the original author? The original >> authors posts contained it, but this commit lacks it. >> >> Could you please commit a change to dl-reloc.c which adds the "Copyright The GNU >> Toolchain Authors." following how it is done for other files (after other Copyright >> lines e.g. malloc/malloc.c example)? >> >> It would be valuable if the commit message referenced this commit to ensure future >> readers can put the two together. Mentioning we missed the original Signed-off-by >> might be good too. >> >> Thank you. > > Hi Carlos, appreciate you comment:)  I am sorry that I was thinking > "seems that most commits don't have Signed-off-by:, the tag seems redundant." > > With your reply, I have searched around and found this rule: > > https://sourceware.org/glibc/wiki/Contribution%20checklist > >> The glibc project does not require tags from anyone other than the >> original author of the patch, but other people involved in passing along >> the patch can add their own Signed-off-by if they wish. > > Again, sorry for my mistake... I have found `The GNU Toolchain Authors.` > at 3.5. Update copyright information and will follow some existing > commits to add the tag. Thank you very much. I apologize that we as a community do not have process which is easy to follow and self correcting (git commit hooks which DTRT). And I very much appreciate you help reviewing patches :-) -- Cheers, Carlos.